Received-SPF: pass (google.com: domain of linux-kernel+bounces-55459-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Sai Krishna Gajula <saikrishnag@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>
Subject: RE: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
Thread-Topic: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
Thread-Index: AQHaUpimwvoWGDyRoEKlOp7YcAsKuLD9qxHA
Date: Tue, 6 Feb 2024 18:29:52 +0000
Message-ID: 
 <BY3PR18MB470744E7FFCCC1B38A0B4E8AA0462@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20240125110601.124209-1-saikrishnag@marvell.com>
 <20240125172803.01189ac4@kernel.org>
 <BY3PR18MB47071D86D89384FFA46286D3A07E2@BY3PR18MB4707.namprd18.prod.outlook.com>
In-Reply-To: 
 <BY3PR18MB47071D86D89384FFA46286D3A07E2@BY3PR18MB4707.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ug44lmgyJs+wCn8W4kw7eCIvfC3Zr2DQEMTGG+0AQ52udZcj0R35unBsJRwv?=
 =?us-ascii?Q?+uHiLxRgc4ogFeyxxWtKbG+fY1nruaP4Eu+kEBM91tRKOWBsBxFFCDP99efi?=
 =?us-ascii?Q?brulQo+57ABBaIVJve+G7LTal5O/1iMYMRQzO80sbdJ5ndLzVgQvC20z9c4f?=
 =?us-ascii?Q?5F+gzVnPVtoHKepiSYDTdlsWOtTtPbNoshArmX6dVWquUnWrXKqkDV7K0Pr8?=
 =?us-ascii?Q?eOz9FAaEwl1T96ubY4oYZQyZjGY9UJYYf8/GxQfNQB57OFKxxKJuz5Pe54i3?=
 =?us-ascii?Q?OjYm2DwDy6gL4l4igvA/XTr4agAQwxho9xRVGF2AylQVVwH6sPTkfDEJDS8k?=
 =?us-ascii?Q?QbNepBfhIGDzZLxcYLqwV0zN7QNNeDMOj0c2VfBCOgfXhmoRBMHVLd1v+ASc?=
 =?us-ascii?Q?X/3pcKhwoC0IfkOwMAANzUchMCvMFm9jTMIK44t0JzlwNWQPCc2UznbY7mtg?=
 =?us-ascii?Q?2+URrA57TpiB1xGU1A4HSCCbnai1UHwlF9Wp7ram8mML9w5R0jfyOqu2LE1l?=
 =?us-ascii?Q?RsyxHCWnpLdHMaWGFgBrmV0gSKMuY9+d0cTbdKsaEqkuk4lhjOQdo0xMIwvN?=
 =?us-ascii?Q?8Zc3hiAw3n7uZJex3Um2N2aC97EBsPjL3LgbQZR9Nd3rk6GCgQQ20Ef8c/zq?=
 =?us-ascii?Q?rkJQqGkieOuxNodO9rjJh3x6FXonZsymKljrRDFaTKtzuKdJ6DBVs3runjpz?=
 =?us-ascii?Q?uM4mleHN3J/ieR4wSQHn7fC0FvbYXrRKDUwVHoLHzKkzE6lhBDdSncouw/BM?=
 =?us-ascii?Q?tKnhFejdhGutraQValEmEzeTmsyuL4MCyjPQ+RrCE4mMUET0ECkc1Q6ZUNmy?=
 =?us-ascii?Q?UwsymKZDy+4nXhV+sJnc6tInfQZg1oBylt52Hmylo7LijmlWYYzqBtOCjBqh?=
 =?us-ascii?Q?jCZgYCguD1DR9lJgLfAYDYnm7Two77MIz9xKydXCdx5SNE3hVwQeLavf50K0?=
 =?us-ascii?Q?oqgXbfgS8XD7EaxjowKUA6y8YcP8PatDyXZAVzl4NYMOUCE2IlsjuA6FySou?=
 =?us-ascii?Q?Bp6eoDnpc57qBfyAC/tXoHqRpD6wtj5izjoCzniYVM2jlVKqsfTzwMxnnsoP?=
 =?us-ascii?Q?686ml+78fwx6UICEPI24pecHsBIjsVtwfhZWY4FG5GVfCTVdqsznCw5TMreT?=
 =?us-ascii?Q?NIZJwAUOP4HtqQEGNMJPXLrzbQYuWAwM29mgJjwHu5llDTvwkqBFM4bhQBFu?=
 =?us-ascii?Q?wOr+4VZcK39jPKWj4hQypaDETra4rmCjMJ94F5kAAfo3WrNqlINsTZm1XNpk?=
 =?us-ascii?Q?vq2/9ZXOGVYZmjLpKfnDpy/94G09+saflqRnqQ2ZqpzcfvUhtgAtNoE475y3?=
 =?us-ascii?Q?meZJm6luU0umB72sg96Re+Sh4Mzdi8U0QjCSASKV/1Xd6kQ7Hc+ISUkNMp3Q?=
 =?us-ascii?Q?OuOJVH0PYQlqs4b5A3qNYiJUWabbJdXFxj/DGggHX9Mx5L6n95uiflexAkIx?=
 =?us-ascii?Q?6I/43KG2rZpe4ToI6QUfEDplZyb/UtraS8NuBxi3OEhneshJNdf5fl1bMAj7?=
 =?us-ascii?Q?SPg/sp72lTh/M108V6AJO5wyW8e8xarCwthT6FVG8f2HLU+YmLhldWYoK7HU?=
 =?us-ascii?Q?jgRl5FuyD6Tut9vdy9R8te+oR4cYQU0xpRBgKwYC?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dba4fb30-f596-4c72-7921-08dc27419c6a
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 18:29:53.0213
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WsEZ2zG+Z5WHgPf4A1ybJE9Bc7uajJGROjbLgFq75zVfMWExJiR5pV6sP7sKKiErNx+V7W/MPIwa4liWI4vA2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB6028
X-Proofpoint-ORIG-GUID: 7Vh1uKYIi2MsVsJ_H0Ph_arp7LLqu-rO
X-Proofpoint-GUID: 7Vh1uKYIi2MsVsJ_H0Ph_arp7LLqu-rO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-06_11,2024-01-31_01,2023-05-22_02

> -----Original Message-----
> From: Sai Krishna Gajula
> Sent: Monday, January 29, 2024 3:21 PM
> To: Jakub Kicinski <kuba@kernel.org>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
>=20
>=20
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@kernel.org>
> > Sent: Friday, January 26, 2024 6:58 AM
> > To: Sai Krishna Gajula <saikrishnag@marvell.com>
> > Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> > Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> > <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya
> > Sundeep Bhatta <sbhatta@marvell.com>
> > Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during
> > probe
> >
> > On Thu, 25 Jan 2024 16:36:01 +0530 Sai Krishna wrote:
> > > Reset CGX/RPM MAC HW statistics at the time of driver probe()
> > >
> > > Also added a devlink option to do the same at runtime, this will be
> > > helpful during debug.
> > >
> > > Usage: Reset MAC stats
> > > devlink dev param  set  pci/0002:03:00.0 name mac_stats_reset value
> > > true cmode runtime
> >
> > Where are the stats reported? It'd be more intuitive to add the
> > ability to reset stats to whatever interface is used to report them.
> > Or one of your reset interfaces (devlink dev reload).
>=20
> We are using debugfs interface to report the stats. As you had indicated
> previously not to take input to debugfs, we implemented devlink interface=
 to
> reset the MAC stats.

If you recommend us to implement the reset MAC stats using debugfs instead =
of devlink, we will implement the same and submit patch V2, please suggest.

Thanks,
Sai