Received-SPF: pass (google.com: domain of linux-kernel+bounces-55461-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 06 Feb 2024 19:36:53 +0100
From: Francesco Dolcini <francesco@dolcini.it>
To: Andrew Davis <afd@ti.com>, Nishanth Menon <nm@ti.com>,
 Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
CC: Francesco Dolcini <francesco.dolcini@toradex.com>,
 linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: ti: verdin-am62: mallow: add TPM device
User-Agent: K-9 Mail for Android
In-Reply-To: <65a24f21-4cc6-4843-b838-b1c7020ca45d@ti.com>
References: <20240126165136.28543-1-francesco@dolcini.it> <65a24f21-4cc6-4843-b838-b1c7020ca45d@ti.com>
Message-ID: <26F9C286-606C-40C6-994E-EABDFFCDFDC4@dolcini.it>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable


Il 6 febbraio 2024 19:29:13 CET, Andrew Davis <afd@ti=2Ecom> ha scritto:
>On 1/26/24 10:51 AM, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco=2Edolcini@toradex=2Ecom>
>>=20
>> Add TPM device to Mallow device tree file, the device is connected to
>> the SoC with SPI1/CS1, the same SPI interface is also available on an
>> extension header together with an additional CS0 signal=2E
>>=20
>> Signed-off-by: Francesco Dolcini <francesco=2Edolcini@toradex=2Ecom>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am62-verdin-mallow=2Edtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>=20
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-mallow=2Edtsi b/arch=
/arm64/boot/dts/ti/k3-am62-verdin-mallow=2Edtsi
>> index 17b93534f658=2E=2E77b1beb638ad 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-mallow=2Edtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-mallow=2Edtsi
>> @@ -127,6 +127,16 @@ &main_spi1 {
>>   		    <&pinctrl_qspi1_cs2_gpio>;
>>   	cs-gpios =3D <0>, <&main_gpio0 12 GPIO_ACTIVE_LOW>;
>>   	status =3D "okay";
>> +
>> +	tpm@1 {
>> +		compatible =3D "infineon,slb9670", "tcg,tpm_tis-spi";
>> +		reg =3D <1>;
>> +		pinctrl-names =3D "default";
>> +		pinctrl-0 =3D <&pinctrl_qspi1_dqs_gpio>;
>> +		interrupt-parent =3D <&main_gpio1>;
>> +		interrupts =3D <18 IRQ_TYPE_EDGE_FALLING>;
>
>Just a heads-up, the SLB9670 datasheet says this device uses
>an active low interrupt (IRQ_TYPE_LEVEL_LOW)=2E Using TYPE_EDGE
>here can cause missed interrupts if the line stays low for
>multiple interrupts=2E


The driver interrupt handler would need to take care of it, if needed=2E

The SOC does not support level interrupt, so there is no other solution, a=
m I wrong?
=20
Francesco