Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3230261rdb; Tue, 6 Feb 2024 10:49:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGvvEvyq2wX/beCg9nNEobG5tiFE01ETG6zc+IxJ1bisq2+mfwGbsCLmbc9kFqOy5j4FZCM X-Received: by 2002:a17:906:80d3:b0:a38:4b2c:8178 with SMTP id a19-20020a17090680d300b00a384b2c8178mr850070ejx.19.1707245351606; Tue, 06 Feb 2024 10:49:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707245351; cv=pass; d=google.com; s=arc-20160816; b=D0zeNhidon2+WlQa2vZiJ5bXnNkPyuNB+BNRDmiv3pqy5ScZyZS32YsrlBl3dpUcCG sjPJuDzCHUslFYEDVY8OM76FLmxTRsFSOm1mdrK4vAFcANpmXWfvl17O16O6zyHT4xV1 JeGgUrm6/xYn6gPP5GOoa/ibRZm9b03TuvS3QqBpVDgRNa+ozlnhO+/FwjGTjZCQZl4o lO9Xj6Vvu3XP5lTCs5cu7ItOp71bPeW7cNK4CuNXBYzMuxsbf2FJ/TiwUs/yBfq1QhBX EjzlmsmX+S8kRPni5eCoukDv4CLB+hSPCummsDCKmOo1mWDlLXBzIjOYlOaiitz/iCOF WcuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=D0LGXNxavVyyanxOOZ+WuCkGeFHzn0tcuRzDMjcoaOY=; fh=zNrPfgeIzkiBHMS1WYXAZ8Q9QQTYjSsMQpTZJqyGRfU=; b=CrxBBnt7A+3ut8GiDkQ+CMFl3jYsVb4Y1UvjYtXDt6rUizANcnthB98SaDZwRpWoW6 3nSLpqKqrENA2nAPXk8HhKZ7PL1wMs4pV5gsbQ9XeTVwkC6qYKHBJLvOhj6QfseTAOkL JOa2fpIY7zRNp/MLTjyfJH8uW8mk7WIS0VA3qQE63fRwJKm9n+o2ZO0xyrZ+iTrdu6U/ 0O1MleblLD2jP4v4LfjCW+ANfklCuZK6e7cFxYj5rp3M5RxepAGoQkmKtfyimmtSsuz/ hoosxpYD2wJWpFzIPuIYgma1Mnr0K6A/LQIgkokfTnGk1cdU/0sQawnFYrUGdD84ZJx7 K0JQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=McVqnQj2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55489-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCUzl3J/hxPJAzLANMowtWn1APTD5EQ2TbuT1/hUlU5mWjHyjBy2jrE/4nJSknZ3rxpA+FdkptIaj/RemWMV/dx1tBrGWKV1BSPQjwDZQg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a26-20020a1709065f9a00b00a384ce07ca0si375052eju.713.2024.02.06.10.49.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:49:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=McVqnQj2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55489-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5BC5A1F25624 for ; Tue, 6 Feb 2024 18:49:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C1F51CFB6; Tue, 6 Feb 2024 18:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="McVqnQj2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83ADA200AC; Tue, 6 Feb 2024 18:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245072; cv=none; b=LhRs3fyw8QieIoVdsh0JPWWPdAuPn6pbqDlXtM0BH7j74ltlB3mxteHjs7Gn/4x085d1Vy0yMZGfMbKEmqTaQc+nGEoIhvQe4orGbrN2LWklkRXSdadOBsqGIGkan8m0P+yyz6nsqt23AB+QPSRwBdYmVTIA+DLwvg3CFFiOylA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245072; c=relaxed/simple; bh=/LwfzEaBhm/92vOpLp6mT7VMsHzXGBh5BGuIoF2VfF8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=L0+xt5uIIIwntMQbRzcsI3sJggpDk/GGgPb3LAT3obD4+hMEZTYZ4Qc5Ja5U4z6ygii4EB6w8NdTb+xPI+/loyOxTdsekFpKrI56ZXit6lAetSmUOcl65m5y4k9GfjNS73SohHkTlas6jVOKkhCKXtwS+GLs4f4KgfGehi10gBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=McVqnQj2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8B75C4167E; Tue, 6 Feb 2024 18:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707245072; bh=/LwfzEaBhm/92vOpLp6mT7VMsHzXGBh5BGuIoF2VfF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=McVqnQj29spOlhBIlxA2o3rEq3DIAfsdefRmcLD/1rvBN75qDwiYuK3Ub01Zi/MaC KoZIRiQSUWTmg+6dK39oGHJsrksfS20e974lyNA3T9cqMJHEVmydIS+QEOWlhSNGWF rZGIF6oZicGoGgH8Zna/l6YgYztObs3p7dD104YqVddbFu8D9VYYTom0h/8FTu+3N2 FWLXcFpGs2tNRizjiEzuEGzCgS6UQJ4TLVfCaqH8OMNr1V7q4XXDFKsj7rK8hQHagB I77nlKH/jCsw4VXwguAtbpPt3/ChhM192grQniJ5C6sI1qxZIXTwepRFIwsnIoadxt d7F9Bk06Ps/rQ== From: SeongJae Park To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Minchan Kim , Yu Zhao , Barry Song , SeongJae Park , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , David Hildenbrand , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH v2] mm/swap: fix race when skipping swapcache Date: Tue, 6 Feb 2024 10:44:29 -0800 Message-Id: <20240206184429.247502-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206182559.32264-1-ryncsn@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Kairui, On Wed, 7 Feb 2024 02:25:59 +0800 Kairui Song wrote: > From: Kairui Song > [...] > --- > Update from V1: > - Add some words on ZRAM case, it will discard swap content on swap_free so the race window is a bit different but cure is the same. [Barry Song] > - Update comments make it cleaner [Huang, Ying] > - Add a function place holder to fix CONFIG_SWAP=n built [SeongJae Park] I confirm the build issue[1] that I reported yesterday is gone with this version. Thank you for fixing it! [1] https://lore.kernel.org/linux-mm/20240206022409.202536-1-sj@kernel.org Thanks, SJ [...]