Received-SPF: pass (google.com: domain of linux-kernel+bounces-55491-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <12718838-7038-4d47-9287-e699e8808143@oracle.com>
Date: Tue, 6 Feb 2024 18:44:36 +0000
User-Agent: Mozilla Thunderbird
From: John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH v3 00/15] block atomic writes
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com, ojaswin@linux.ibm.com,
        bvanassche@acm.org
References: <20240124113841.31824-1-john.g.garry@oracle.com>
 <20240129061839.GA19796@lst.de>
Content-Language: en-US
Organization: Oracle Corporation
In-Reply-To: <20240129061839.GA19796@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NWVIbEpNNmhvWHJ0TGR2L2Yvd1BCSkh5UVEwWWJhbUJKejlCc1JWdlcvU0VI?=
 =?utf-8?B?dTVncWdPSEVIU1FPRkkvbDI0d2NZUlhGS05JYW1tcUpWUXJlNDFCUjhScXRF?=
 =?utf-8?B?RVMxcXYvcU5pb3pPMXZPNmxKN1Jod0ppOTFGZlFvNUxnRjBnd2ptTldPbGVB?=
 =?utf-8?B?cFphbGVldWw0N3AyUnArKzI1dmtrU2YraUxCa1A4bmluQVNhdURKRTRQTWtM?=
 =?utf-8?B?aEFaTEFjcG5HL2F2bGpsM0l4UE8yMlBoU21iUGY0L1R6MHVkZzNMQStqREY1?=
 =?utf-8?B?L1FsdE9ZdmdPM3Q1UGRpeEgzem95TG5xRnhXVkZRdFI5S3hPRG11THFpSndX?=
 =?utf-8?B?eDR0ZTJlOU1ScTJkVGFFeUQwVFpPT2dzclVJdkNvSFFlVXNNWkEvQlMvWnZF?=
 =?utf-8?B?NTlqYUJJZEJabmZNVTlDTjZLakxoMzFlUzM4OWozaDNBWGlQcUErWVgzQWQz?=
 =?utf-8?B?S1pwbUd1UTdxYVlJbzQxc09TanpPQTk4Z1J1WlQ5aVNZR3RNbXNsN3M5QXpS?=
 =?utf-8?B?QjdST3lCWmYyTncxVG9xT3oyWTlwMmMxanJNbkhhN2ZoUkp0Nnp1ZFN4dzFC?=
 =?utf-8?B?cEY3Y0lvaER5S052YVoxRGlUTi9vRC8yVXowYmRQcytDN1VnY1N1aDJLdjNB?=
 =?utf-8?B?aE1hRUg1ZFZON2M3Z0dyNzdkVWQvSU5TTWVYM0wyQWUrVFN6d2lmL0FnaXJB?=
 =?utf-8?B?YnlaRXFLall6N0dsaHB2dENya0RYb0lMelBtdmpOK05ORThnSnZSSW92R1Z2?=
 =?utf-8?B?TlkwNDlMZ0k3S3Z3U2lSL2l3dkhiU1BIWTErckdDdzJIRjF4bGQrZ2QzY2Vs?=
 =?utf-8?B?bFhya3E1c04rNjhFM2hQbUVwMnROWmJOSzFIWjZqUGMxam9YTTZZMnBtNzhJ?=
 =?utf-8?B?M2NIcitwRWpFR0l5WnQ3Mmo3TXd0M0lFdGozZ3h4clRBa3d5c2RFK1l6MVVp?=
 =?utf-8?B?WWFhbFNnM0lObmltVnNFWVRKUWdFSUdNK3d0bG9nRG92NUpLeENQV21NVVFz?=
 =?utf-8?B?eVN2RlhXVEttMm9ObGtjUlFWemRXOXN2WTZEdnl6d3cvd1pEMlZHaGMxY0ZR?=
 =?utf-8?B?R1hPbFhVb2xzUHd3NGdrbEZQVWN3Y3lrZzdoTndna0pMQVRyL3FCOTNHMlBl?=
 =?utf-8?B?ZmI0K01uSG5jN2tVZGJlSWp4MzR0MThJUHgxWE5GbVhlTW00L1RTa1RVRm4y?=
 =?utf-8?B?WThKMkd2emV4MENKMTdPZzRKUHZ6cE1KbTJzSXRBelc1NXpONjAzZURiV2Rt?=
 =?utf-8?B?b2FhVHNEMG15d1diZFlybjRrdUFMdjJ6Q0txeVZoMW83MjBRMDJBaHN4VWw3?=
 =?utf-8?B?MmJ6U0IxKzhoL1JQNUxNU2tzdkp6YXlET0ZOeStPYlo2NWRqakZiUVpqd2dP?=
 =?utf-8?B?N2V4TEVidGpEM3l5d3RtYW9tVWVERGowK1VHREU5WEpTdXUraGRHUTJ6S0lQ?=
 =?utf-8?B?U3o0N0ticzY0dHB3VmMyQ3FoSzNidE1mNTdrc0N5SFZtWUp5RVJzQWkwL01V?=
 =?utf-8?B?Q2I0UXQ1M3RDczVFVXBJZzgwc3BORmdGLzlIcHNkYnB2Y2l3ajB6SHo5dkxs?=
 =?utf-8?B?MHRZNk9CSHVOUnplMVNvclliTkdTeXgxOVAwTlpiTHBYbGRFQmxoejk1bERh?=
 =?utf-8?B?UTN6QUpIN1duMFJ4RXRHaGw2bmxXbkowdnZ4K1F1eVRUSzN2dmxXQjNGamlz?=
 =?utf-8?B?WmlIa0tRbEJxb1pKSUExczdMT2Z0ZEFQdi9LdlpDWjFRajM4VEl3Si9BWVdt?=
 =?utf-8?B?YVViRUpKRHEyR2w4and2MzkrQ05rM1hFL210N3ZKRWdUSzQ1eWtQTmRnVFVL?=
 =?utf-8?B?dEh4b2JvcnVHcS9WS3loZjYxVE5OWDdVRjE0RXlKd2lxNlBQZmlVbzR5NUM4?=
 =?utf-8?B?bk9kMGFLbm5QU2wyVjJaYy9HZUtqQVRiczNKS1UrYnF1aG9POXRyeHJiNE5r?=
 =?utf-8?B?cCs1clJOZmk1aTNHc3plMTg2OVhralZKUVEvRFZHVGwyR1RMY25sSnpBTnZm?=
 =?utf-8?B?cUdKK2lYbWVISXRXZGlVQWJoSzVmT0FidTlybTVTaElvZEhrUU5zK09qK2dn?=
 =?utf-8?B?bEhYTHdaT1BzVkJXL3BlbXV6ZVp6enUzS1ppMXJXMllQWGVjS1lRQ1FtaG9F?=
 =?utf-8?Q?q6OkHUi3jipaOykfTxGJFw+93?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	vCXVJrPlzNHWUmcOmE7gAI4zK6I6XqV71IeHMj0xurpSSw0KNBoyYfI0bJv8Ame5sykw6KKBx3qh2Czp09EWWiH/JA7McKdX3tp30GUd5ES8uuu+sDihw4WzCcgB5iyUEjowfLw88OExfEp8OKBw+biXr48Ib8W+AtH9yN8pjoOqhK//Aj0OA+9R+SILR36UOYuZ8v742fzyWBy+NBGaH9AnigW7ty+GxuQpraGmFsw/wxcdqw1dezS2kV58kgDRT7fIEEl3+d2XBM2Tou/GWDrnX5iUplDGlw1tIUIP4580ANL7zEoWBV3TlrmRrXDig9Rky5gDaM56aVF+s6oqGN7G9ci2j9wDPZKVBGakWf1aPle/H2xlBv6cxAuy7qrABtXxig0N5WfthPf5WAd5EJUwblPol78Y5RkgruPTHV1V5hKgLg00ducHHe0SlOOuFb/zcPX03hVGPFvDpzbdDT/tMDus/9s/AKfq7wr6cwtjGz0McRWfBl0F2VUH+4FbVdYW0ZTpwKKkaIT+tEDdkqDd65p1BnBS3X2j9Pw+0GLPNaj7tCJ4Hw9uxB+FnFgJfM9jFodcringQjPDdmIdtXRd9ai9WDXHxfHr7JstT9I=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63129165-4f8a-4e2b-40cd-08dc2743ae6e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 18:44:42.5355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LGMnUfI7n6P740hLMn00wTIVVhPVp/JnBmIxuW9wHoME6WtJSLgkmPo4E1hldcgEOFKdQXCt/ep2rsDgj1GQhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7902
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-06_11,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402060129
X-Proofpoint-GUID: 1myyke-Cek1EO5mUsaYzQIfvyxfUM6H5
X-Proofpoint-ORIG-GUID: 1myyke-Cek1EO5mUsaYzQIfvyxfUM6H5

On 29/01/2024 06:18, Christoph Hellwig wrote:
> Do you have a git tree with all patches somewhere?
> 

Hi Christoph,

Please let me know if you had a chance to look at this series or what 
your plans are.

BTW, about testing, it would be good to know your thoughts on power-fail 
testing.

I have done much testing for ensuring that writes are properly issued to 
HW with no undesired splitting/merging, etc for normal operation. I have 
also tested crashing the kernel only to see if atomic writes get 
corrupted. This all looks ok.

About PF testing, I have an NVMe M.2 drive, but it supports just 4K 
nawupf. In addition, unfortunately the port on my machine does not allow 
me to power it off, so I need to plug out the power cable to test PF :(

We do also support atomic writes on our SCSI storage servers, but it is 
not practically possible to PF them.

For actual PF testing, I have been using fio in crc64 verify mode with a 
couple of tweaks to support atomic writes.

What I find from limited testing for XFS and bdev atomic writes on that 
NVMe card is that indeed 4K writes are PF-safe, but 16K (this is an 
arbitrary large block size which I chose) is not. But I think all cards 
will be 4K PF safe, even if not declared.

Thanks,
John