Received-SPF: pass (google.com: domain of linux-kernel+bounces-55508-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <28f55bf4-4ce6-4913-837e-2d04d53ff2df@amd.com>
Date: Tue, 6 Feb 2024 12:56:48 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] crypto: ccp - State in dmesg that TSME is enabled
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: John Allen <john.allen@amd.com>, linux-crypto@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>
References: <20240205154602.21411-1-bp@alien8.de>
From: Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ
 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w
 IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj
 aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV
 kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ
 h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01
 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP
 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP
 r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG
 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ
 mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD
 h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC
 zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49
 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD
 ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K
 oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1
 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr
 NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN
 y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym
 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY
 vFkWitqCJg==
In-Reply-To: <20240205154602.21411-1-bp@alien8.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUpHeHpPQ0hRaFd1M0Y5MGRLOG91dXZoaS9TL014TU9SaTUzRWJVZkV3Ym9G?=
 =?utf-8?B?eHZSRzV6NEhsNTh1dlBRY0VvQm14T21lWW1GcitSZWE3aEhvTE5RSWlIRWxt?=
 =?utf-8?B?bWtzU1BBN0twZXJmZlhuN0Q4eEYwTUE1MXFuTm13WG1ZN3RqaUJudzQrdkta?=
 =?utf-8?B?V3VjMERPbnZ0RCtZYjIrNVQwTDN3RTZwZ2R3WDJNQ0N5eVoxcDVwczdGVUYv?=
 =?utf-8?B?cXdKUlFiWVJ5U2tqVXNjVjZlbkhqWTZrcXBQQklNeXIzbXFGZml3eFdWY2wz?=
 =?utf-8?B?eUs3SjZFSEhSNmR2UFZGNm9DVisvV1RWL1FSUUdNMmJla3RjRlBFQUNaZmx5?=
 =?utf-8?B?eWlHMjdKb0Roa3B2MGczNUhTb2hNNytUYktrb2o0Y0RJU2lhS2dobWxBdDUy?=
 =?utf-8?B?WkFGd3lnd2liQTF5cVJSV245ZmZVUUVXLzNBTzdoL254U3hqNCtNdHRyRGFm?=
 =?utf-8?B?VFpTeHlnY2Z5aGdWY0JodjZieUNFMXdQaTZuQnBoazYwZ2ZxV0xOQUpMSlNM?=
 =?utf-8?B?eDRvak9pR2s2N25FRDZ4aHBXalVLcDNaVEhsRTY1aGI1d3g5Q1VIRFVlQUtP?=
 =?utf-8?B?RlhBR3JjajBOTkxzYXE1cTBoamJEUmh0WDVVektJT2pMTEUwV2MzK2J1YlBp?=
 =?utf-8?B?VmlBaEdUL1N5enVkZnYzZlk3WFBERGFhT2RvRTNLWlFBbUZaM280VVdYMmYy?=
 =?utf-8?B?bUZSYm91NW9QM3B0T0pCTlc1ZWxMOGYvZUNtUjdBdnFoNG00T1pBaDgwQVha?=
 =?utf-8?B?dTRyeS8wd3A4TEp5TUVFK1Q1czBsZ1BITGM0Vy9SeEJCcUZ5NG9WejZqTzJB?=
 =?utf-8?B?VzVLa3VZRXNiNk5rSHNqZit1T3lMTS92d3ZqYVZIT3hKVGdqb3R5UzdnejEv?=
 =?utf-8?B?ZE5EMHNCdjNrVzZmNWR4a0lGL0hpU0dhVGV1MThpcUFSVjR1ZExuSy9ja0Va?=
 =?utf-8?B?MW9ZQnN2dDY2NjFHaG9Gemx1L3l3UnVqdFVxeEJnbjRmVW1BOTBYOE1jZVBK?=
 =?utf-8?B?cFRVRDV2ZFFLNXJFZHd2QWF5ZTd3Z3UxMFlaMHNKRGQzSkY5Q1hRamh4RkdL?=
 =?utf-8?B?RWtUdUNEeXl1MVdaRTE4dGYvZjlBVjdkTmZzR2FOdjh4NHhvYVdJVGxmUnha?=
 =?utf-8?B?NlMvZVRnSllodmdmQUdpUE9XdjNQak54MzViQ24xTVN2YUV0YWFZcjRsa0k5?=
 =?utf-8?B?MVM2TzBUSXBVTkltcTRyWDZZcmF5OEU5cnp5c0p6a0hVVTg3TFRNRm55d0p4?=
 =?utf-8?B?Wlk3UEpuR1BKY29wTTlJeFZic2x3YlNvTFNaeUJ0ZjhEQTVUN3l6US9jZFRl?=
 =?utf-8?B?aTdJNGM5N09yTEo5VTdSc0Z0SStobHQrZ2R0YmpScVpPSFBIOGRWUVl0eXVW?=
 =?utf-8?B?S3VNeUlEaHFmQ2hDZyt6V2FDcUxiVkNnSFZXYjV6dWhKZGRPd1grb0RJa1Y4?=
 =?utf-8?B?SEtvYkxvc2dDSzVtOVFQTnU4RDcvRFNoQnJCK1ZoVndBeGFzMlBvNTk3ckhT?=
 =?utf-8?B?dmVUNmxiUUNQdVV5UjBhcWJ1c1ptei9ZQ1BSREZsanBUQVAzQzAwUFF5c2wr?=
 =?utf-8?B?dTREb1JuWmIyN21WOHpaZlN6OUI5emZqLzd2cmdmNWJibG93RUN3RkY4S1Ns?=
 =?utf-8?B?TmR0NVhEQWZTWjRiQ1JUcnVjcTM4dDdUYUN1NmtvRkg3SWNoelZSZS95OHFj?=
 =?utf-8?B?T2xselp0U0tkdEMxTmxDN1gvZDE2RHdVVVlpSnh1dnFBVjlYaVlxY0RSZ2wr?=
 =?utf-8?B?RHMvT1JPTGJVRkxJS3F0b1QyRjdic3pZYjBjczFQZWtwYnlIL1F5R0lNaW1n?=
 =?utf-8?B?dk9kUGV4L096TjNPbHlYR2E4d0RqemNWbEkrLzNqRC96ZUs0WXJuZUtBZk1H?=
 =?utf-8?B?bk9pb3Fod1dLUWhDdnduYzMrWm5LWkptMlN1REhWRW5QU1JrU0pnTHUwOVFN?=
 =?utf-8?B?QXhDT1krMXBLTnY4WlhsQmw2SXBKb21BaUlVVTFVd3FsbEFRM25jMUwzdzZj?=
 =?utf-8?B?aXJTODA3S2xQU2xSYzhXVkk3MGlVa3JhUGV3STY5TTVDc2RrbVlHclR6ckVn?=
 =?utf-8?B?R2tiSGJJQ3dWV1Q5WGJWTUxOTlFnZHlJTFV0YnpWWDVDS3Z2bVBxaEh3cC9i?=
 =?utf-8?Q?3wyPQzDf/Q1dPjgg6qURFiXfr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff0cef81-8e5a-44f0-3b66-08dc27456070
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 18:56:50.5061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vGxn3xcQAn9AT5VXBRaaDY7MB5gMJ1ZJnuSSqGIkGVVKX1ukIEV0X+pz0os5jboI8UckD+OEqXqNBp8wyjeppA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6536

On 2/5/24 09:46, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> In the case when only TSME is enabled, it is useful to state that fact
> too, so that users are aware that memory encryption is still enabled
> even when the corresponding software variant of memory encryption is not
> enabled.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/crypto/ccp/psp-dev.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
> index 124a2e0c8999..56bf832c2947 100644
> --- a/drivers/crypto/ccp/psp-dev.c
> +++ b/drivers/crypto/ccp/psp-dev.c
> @@ -156,11 +156,14 @@ static unsigned int psp_get_capability(struct psp_device *psp)
>   	}
>   	psp->capability = val;
>   
> -	/* Detect if TSME and SME are both enabled */
> +	/* Detect TSME and/or SME status */
>   	if (PSP_CAPABILITY(psp, PSP_SECURITY_REPORTING) &&
> -	    psp->capability & (PSP_SECURITY_TSME_STATUS << PSP_CAPABILITY_PSP_SECURITY_OFFSET) &&
> -	    cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
> -		dev_notice(psp->dev, "psp: Both TSME and SME are active, SME is unnecessary when TSME is active.\n");
> +	    psp->capability & (PSP_SECURITY_TSME_STATUS << PSP_CAPABILITY_PSP_SECURITY_OFFSET)) {
> +		if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
> +			dev_notice(psp->dev, "psp: Both TSME and SME are active, SME is unnecessary when TSME is active.\n");
> +		else
> +			dev_notice(psp->dev, "psp: TSME enabled\n");
> +	}
>   
>   	return 0;
>   }