Received-SPF: pass (google.com: domain of linux-kernel+bounces-55536-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <10c0148d-696d-4601-8852-ee5bfea19602@web.de>
Date: Tue, 6 Feb 2024 20:02:44 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: [PATCH v2] drm/hisilicon: Use devm_platform_ioremap_resource() in
 dsi_parse_dt()
Content-Language: en-GB
To: Douglas Anderson <dianders@chromium.org>,
 dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
 Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
 John Stultz <jstultz@google.com>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>,
 Thomas Zimmermann <tzimmermann@suse.de>, Tian Tao <tiantao6@hisilicon.com>,
 =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 Xinliang Liu <xinliang.liu@linaro.org>,
 Xinwei Kong <kong.kongxinwei@hisilicon.com>,
 Yongqin Liu <yongqin.liu@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <b236236a-9953-4246-a697-19ed1b22d86a@web.de>
 <CAD=FV=Xsg3Fs8XQ0piBYKGSYOhuGXyKpoJ5dbtGPdP5HU+2RyQ@mail.gmail.com>
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <CAD=FV=Xsg3Fs8XQ0piBYKGSYOhuGXyKpoJ5dbtGPdP5HU+2RyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:xkHi6bv8veo=;zt+BIeoCQAK8OkXMxk0kXGXRY+r
 Rl8t1SaL8N0etUcfbX9GFRZy8E2nr1PX3ujh9LTGIK0cv38ewfHlw8lfcIoqw3LGi0f90ZjPh
 c6DNCURdreKjJw19DEYeS9o82zVUeyTGA+Bw1gsQlRNTpY8cFzNPIbF0VT2vyUR40IHQH5FIH
 lV6E46PmNXz9oIiWrc5fVZR2Mh3OEQEE55aQ6z3r6jrlJV1yBICrtnnjDigXV+Vfidz1MjlaW
 2WdU8IjpYR+HAQ+Cgs/U7u5BiHkClvJdSUBjWatzI6icJ8hmd/Oi3YKVPp9xDy7xBcVdWecj4
 9bOk/qAownBHf/u9ZuK3CjW6u2AZhvz+0x8i5ADLQbCR2wVjGKYU5pdTdhgpElVgMAtFYP3Qe
 Sgya4Wfy72SyyUcJHk11TFvHO1GrVLDah39vEWGi1xOKNFZyrBqvbnB2f0no8/nqmldzVNS/Q
 2I3Pf7EyuYB+D+UkhB01eEKpbkUU6uRfiauH/EHO1nsu4w1hMoa9e3LdeJiSpxlH3NS3rn81I
 Pqaxb2VRpTpVE6NW0741ZEnMSOig9lHsrPIVRsS3eqFqBFcp6yCSrXGvtC5ZmGvMgK5VFcMf8
 Cl/Ymv1F3VYlOaWwICKtWtoMsojpj8vjspij47KuRpE3sfB9Wec+PCobopea1DFqFS8Vq7IGy
 eFOfE6b2Tfnc6hNlh2KhWGqoQUyHr9ops39+tW0OmGYRoLkkSL9ObWW3YSNkEBTM5BwRLVkg1
 gfwn5lEbHgWeMvstj8jjDmcWS7ehyWxVml8Vhyft0UKXe4Tw8fUpT1i5lrWPPNrKBNREdcFYL
 BqLNDFina4Yyjn+FExNsJbbATCdsZ0XGoSSOd79j0clbo=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 6 Feb 2024 19:51:25 +0100

A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca=
07f87626858ff42
("drivers: provide devm_platform_ioremap_resource()").

* Thus reuse existing functionality instead of keeping duplicate source co=
de.

* Delete a local variable which became unnecessary with this refactoring.


This issue was transformed by using the Coccinelle software.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--

v2:
The transformation pattern was adjusted based on advices by known contribu=
tors.

Examples:
* Douglas Anderson
* Geert Uytterhoeven
* Robin Murphy


 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/dr=
m/hisilicon/kirin/dw_drm_dsi.c
index 566de4658719..6db6f355394c 100644
=2D-- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -826,7 +826,6 @@ static const struct component_ops dsi_ops =3D {
 static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
 {
 	struct dsi_hw_ctx *ctx =3D dsi->ctx;
-	struct resource *res;

 	ctx->pclk =3D devm_clk_get(&pdev->dev, "pclk");
 	if (IS_ERR(ctx->pclk)) {
@@ -834,8 +833,7 @@ static int dsi_parse_dt(struct platform_device *pdev, =
struct dw_dsi *dsi)
 		return PTR_ERR(ctx->pclk);
 	}

-	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ctx->base =3D devm_ioremap_resource(&pdev->dev, res);
+	ctx->base =3D devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ctx->base)) {
 		DRM_ERROR("failed to remap dsi io region\n");
 		return PTR_ERR(ctx->base);
=2D-
2.43.0