Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3246625rdb; Tue, 6 Feb 2024 11:20:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+UATIxF4kliPrPJwhR2fhKIPDDePth588UaE7PdzlJMg9ySUsCgFXy/5P544nClT/EvmZ X-Received: by 2002:a17:906:2c47:b0:a38:b94:48bf with SMTP id f7-20020a1709062c4700b00a380b9448bfmr2332837ejh.0.1707247215656; Tue, 06 Feb 2024 11:20:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707247215; cv=pass; d=google.com; s=arc-20160816; b=stGsJ2GYR5L/4pGCsxf6cRaPmVYYt9bcuIT+Fe7I+jOyAQuHaSUH4Tk7kRGUGAw7zc YXhTmOuaO3EVK1VAHXiRFYYALmSUgcRhPm7MQku3z/KKdvbD1aEd+6PuS42lHlKzueoj w/e6162I5CYefWdWcbWilWbrkAnkKXXV6CVM93LfZMFgeuFhL8loKYXwWaRYpMdmEUnk QuohFcYmSIMUQPRZSuiNvshyzdWzEB1To/8B45yeOZdqkqx+YpyFlMzzZF4mFzbQVwxg D1jZNkYb9t9FpsMh3HnV2OYTc75teUqB6iIyhJ62CkiWgFH7zptEZnJqz2Z5DRAY+RKD SIhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LgtwqaM0q60IIOQMHiC8DeTlCEjVoxSbX6OM+ulu9VA=; fh=f9K/Vvj438GEySr+VWmRtEJTtZ0XT1VpUC0I/SSAujM=; b=zlNPQ2diyTBd0/zBrib/Xf9k4BbeOe/QdAek+UilmVMA2kslUE7NEf01zGa3OWnWI5 vCax2iL29ld9YA+mxFzb21iRNZ15rwPpqqgyGl0cVB7p9spcD0r9at7n/A3XudZZohp4 7jnXOEKDAoy+ymUSmShFMfgwlbyZXHsPLZ8XrKIPHgjCnCh84tA+eNiOL13yDvmwTram LyLmvXxMkYm77+cl1kcpXYgT6HQ9vp+BmK7e2ukKerb6juV3qI72yYYRsj81r1Yh07GV BORWnhJ4tkbRAcVAWHnVLzh2d8kbRkUCIZO71+TJ7A+3wdsfRoBGvnGZVmGzW+EZHl3H cZIQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=522Rf+io; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-55549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55549-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=1; AJvYcCUFcLUGEO4HzXlQJhP/103vA17WvBH+Zjs2g85sQAw3PD9BnMa+eFmu8yoXq3V0I03njmr1vTqFCTExkNPKE8HmK6nJhABzsbq1Eb2zXA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id jx10-20020a170906ca4a00b00a37c9ce3c4esi1408371ejb.457.2024.02.06.11.20.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:20:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=522Rf+io; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-55549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55549-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 65F1E1F26237 for ; Tue, 6 Feb 2024 19:20:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 802D314A89; Tue, 6 Feb 2024 19:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="522Rf+io" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D211426E; Tue, 6 Feb 2024 19:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707247200; cv=none; b=Wkgrzh9lC7bkBqo7XE0Pg6pPTmhG7WlrRr/8TeoT8oiGRCUIChAjpcsm76bg4KHi+QgYrs9GaHBL7pdt1nP0oj5Epcwi9nMhh1X182stFHVPv8nFQKWb59UhDnsC8259Ez4MximPSwdbb8X40JNJbnppzlQUhB9Q1GVfpicufCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707247200; c=relaxed/simple; bh=dig3P5DqUNE0YcDq2EwPlQEKMHYJc1HfxIrOjf2+Npg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dDIMJkVuLbi70vl/QCtiHxvfHjqBAYAG4FJmkdhbTyzNqakvix0VXis/5nptch888U6H2s2b2mqNhYjIVAfzQG1wZhLemCC+soSUkCWsBt7qOfqcqDifxaDrPLFLtcYegFq5+NTDCo2oHDhWH2Isogdbpw34c6M2Y8V04guWKiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=522Rf+io; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=LgtwqaM0q60IIOQMHiC8DeTlCEjVoxSbX6OM+ulu9VA=; b=522Rf+iosw91PvNlnfG004MR7j wT6eUkjMB6RMdzdgkkH5HHpSBX0kvkCE0n6JkKO6eJahWmwNyiA69hbCs8IF48rfd3qDpc05TgoQ9 s0lAzpPiRWzyDs7V70bAnZMOtzdpnkrC8hiZ0TQ390OooJsDVkd/nn4DK8TrKt0N0UPI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rXQyw-007AQi-M0; Tue, 06 Feb 2024 20:19:46 +0100 Date: Tue, 6 Feb 2024 20:19:46 +0100 From: Andrew Lunn To: Francesco Dolcini Cc: Wolfram Sang , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, Francesco Dolcini , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] net: phy: micrel: reset KSZ9x31 when resuming Message-ID: <6cf761ad-91a8-4fcf-a9f9-0c18b7fb0b29@lunn.ch> References: <20240109205223.40219-1-wsa+renesas@sang-engineering.com> <20240109232838.GA3626@francesco-nb> <20240206172645.GA24848@francesco-nb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > What if the configuration was done using ethtool? The MAC driver when handling ethtool requests should call phy_ethtool_ksettings_set(). That manipulates phydev->advertising, phydev->autoneg etc. These are the values passed by phy_config_aneg() to the PHY driver. Andrew