Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3254114rdb; Tue, 6 Feb 2024 11:36:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IEM8VBEk/p86HnXA4ExKY1V2S+cynr0ijXDEvdjvGBFHQFFwbKlo6ALPee5u/0imlrIe0MR X-Received: by 2002:a17:903:2b0e:b0:1d8:ef8d:a7ec with SMTP id mc14-20020a1709032b0e00b001d8ef8da7ecmr3719331plb.2.1707248170704; Tue, 06 Feb 2024 11:36:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707248170; cv=pass; d=google.com; s=arc-20160816; b=QgQEG/Wm4O88CbG5xc6fs5Mk/0zvoRL7Hby+9IKWiLDVUaZXVrxgNvWjDzNj0aLcJ1 ayk2sewF9hunZI7vW3R8RV4mWGQan93qmXjNW6/yGO4fSt4KjkFe69oaORHAD4s3CdBr +U68amMwGZeMB3v/dJ2hq58KczXzX7pmQhhH0NfMeAIjxmgeZeSjRRQoB2/Dm0fLSXhU pMdTRfIfjV4gBDF/6P0Ees8z42e6cI/UxnqK8tRV+KPu033iwyt5ZTrj2EHcUTtZQ03Y cojjmyU1UdjIdOgdoEyoIy0rVu95cWQ17PossydtGMJPuOYr7orP86v6Gv5Y1a9Thm5C xKyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:feedback-id:dkim-signature:dkim-signature; bh=xWAHkj6oLXesB9J7U7zS+HoVDGaRAHiH8XlBjN5iCTQ=; fh=ZbG+Hiv3vczTa13pQorXGwkl1qbR+O1hmBqdat+RBPI=; b=xtOwzlpdihWHbVcTqye2lCJfCi7PvVq7xnkmskEYcFF39Uig8aPZVJZzQ8jRfofTcA 3qUt4QO5vd2GLSfJ7gDOyTogoh2J8zR137602RYVjKIdRabyfvgJWH/krIB/MTLD1gha DQ8Fa/U31U4aKtLgvFV+bcGQBIb3i7c5skcBmCnRQXMFY2R+G91keLmojGwf2EjS8SZT BKfbUHSqGE4F8y+pn2jfBGf2zdvWSQ6th82S5nMb2ApcO9vN04MCjp0BjD5iHiKUE3i1 WS7J4DRWxPTQyTQ2nFjNuO3P70Wu4m2TaNdRXirFhTLg9HgiBYUbmqsKDcaceCbQGNIL dHdg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tycho.pizza header.s=fm2 header.b=2ftn8JTt; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Cqvw0PAn; arc=pass (i=1 spf=pass spfdomain=tycho.pizza dkim=pass dkdomain=tycho.pizza dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-55562-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55562-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCWIq69E5JO69od19y0nlpWNSTKRAJmInPDhtAhDybUbBDWg8xYbpcI8czYLEqXONmaTaoZs8b9D61NqiTzMxe5uTIPteNpxCE7lzdwS6Q== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t10-20020a170902dcca00b001d9e1aaf21bsi1011805pll.138.2024.02.06.11.36.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:36:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55562-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tycho.pizza header.s=fm2 header.b=2ftn8JTt; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Cqvw0PAn; arc=pass (i=1 spf=pass spfdomain=tycho.pizza dkim=pass dkdomain=tycho.pizza dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-55562-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55562-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F3751B21EF6 for ; Tue, 6 Feb 2024 19:35:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 613C117727; Tue, 6 Feb 2024 19:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tycho.pizza header.i=@tycho.pizza header.b="2ftn8JTt"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Cqvw0PAn" Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72052175B4; Tue, 6 Feb 2024 19:35:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.27 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707248115; cv=none; b=rlxTId1w6oII4GySyIGLrl1BIWBKvhDMTHe0tAIdYEc7ldEuG7ncB5Uist8bTb+5FH4SjOsNhX1V1XECm/FlZ5psM1qSk0mlY+vxR1lKZr5CEE2Loq4U/sX7+sO9lhx7N0N2nxGzYULvkrJqON9QLwTMfBdoUGyxdi5D0Hu5OoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707248115; c=relaxed/simple; bh=xWAHkj6oLXesB9J7U7zS+HoVDGaRAHiH8XlBjN5iCTQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bA6AweEPrcNUnUdz2kwJK0TRyA5l6RJhPOvCpxmle9Xxll0kAsZmTmrlxYGX0P3v3nZTxT562shHq6RnXHQ6Sy9E6bCFnZnEMuDW4t1/oI/0UA/M0nOSMiosHdC5bRTLLHQqGkzcoNHTfayD23YksuO9FsI5U83LEqSAkC3Yuuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza; spf=pass smtp.mailfrom=tycho.pizza; dkim=pass (2048-bit key) header.d=tycho.pizza header.i=@tycho.pizza header.b=2ftn8JTt; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Cqvw0PAn; arc=none smtp.client-ip=66.111.4.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tycho.pizza Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 60D425C01D0; Tue, 6 Feb 2024 14:35:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Feb 2024 14:35:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707248112; x=1707334512; bh=xWAHkj6oLX esB9J7U7zS+HoVDGaRAHiH8XlBjN5iCTQ=; b=2ftn8JTtc0FEL/uRu0/zdm6hnh 9I3B2gi4ZVSlhq5PA1xD9Ri+CRHRSJR4Wom5s4m38gQI4ElNpmG3aLK+j+FJcN6+ G5h23N/omTigJxauz4MWQf9NcOwkTGwCsLwpGQLAQsm9Bq2ke2Lh7H6Q9Wgtps/L nEED3+NJ4gfFWa9VEsjFRE54CrHO/DD3MCJqttska0ABBc1vVCc/NVtp03lSPPWy DStHMq22wUGzktQu7jrSLS3NH/llobBKXklnEFN8LZWdG7zWuvWzpQR2RmDjZ9Xc +wj25QT6E5HE9yUUQ5oNabdxjzrNw1n9snRRiDKdbXUg5QOLIvwG73X5Y61w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707248112; x=1707334512; bh=xWAHkj6oLXesB9J7U7zS+HoVDGaR AHiH8XlBjN5iCTQ=; b=Cqvw0PAnhbfxvhzKaTvH6ohivQshuONbPDBaBjTZkH+8 gbjLXtKivBMtMSCg83sCjBWIrInwuCRPVDwYvNSPCL4YWA7udtSGPbNyc/8HXUyN hfSv3+ni2406B/nOfz8ALavd+yDAwPhTkWChcdDTiPgFKVx7/8MBzfQ4sLBPWZy4 EbffNFErh/mH5nZSe4o3Vs7o97aVexIAmzxYc1TYQxHW6PHbpjy34t70VfG6SCXb LF53do1fOmMMM5lPbpacekFioteSmolKFf5CIqY9KyP0xM9G1d6eJJDewWAGDaFW 2sAZg3fvdsY2vlbEfXKP9bMJ9ZIAFczFys3GhHVfCQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddtgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvhigthhho ucetnhguvghrshgvnhcuoehthigthhhosehthigthhhordhpihiiiigrqeenucggtffrrg htthgvrhhnpeeutedttefgjeefffehffffkeejueevieefudelgeejuddtfeffteeklefh leelteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthigthhhosehthigthhhordhpihiiiigr X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Feb 2024 14:35:10 -0500 (EST) Date: Tue, 6 Feb 2024 12:35:09 -0700 From: Tycho Andersen To: Oleg Nesterov Cc: Christian Brauner , "Eric W . Biederman" , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH] pidfd: getfd should always report ESRCH if a task is exiting Message-ID: References: <20240206164308.62620-1-tycho@tycho.pizza> <20240206173722.GA3593@redhat.com> <20240206180607.GB3593@redhat.com> <20240206192553.GC3593@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240206192553.GC3593@redhat.com> On Tue, Feb 06, 2024 at 08:25:54PM +0100, Oleg Nesterov wrote: > But Tycho, I won't insist. If you prefer to check PF_EXITING, I am fine. Looks like we raced, I sent a v2 with PF_EXITING, mostly because I didn't want to run into weird things I didn't understand. I'm happy to fix it up to check ->files if that's what you prefer Christian? Tycho