Received-SPF: pass (google.com: domain of linux-kernel+bounces-55572-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 6 Feb 2024 20:52:06 +0100
From: Wolfram Sang <wsa@kernel.org>
To: Rand Deeb <rand.sec96@gmail.com>
Cc: Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>, openbmc@lists.ozlabs.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	deeb.rand@confident.ru, lvc-project@linuxtesting.org,
	voskresenski.stanislav@confident.ru
Subject: Re: [PATCH] i2c: Remove redundant comparison in npcm_i2c_reg_slave
Message-ID: <ZcKN5isE0B6q88Fa@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
	Rand Deeb <rand.sec96@gmail.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>, openbmc@lists.ozlabs.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	deeb.rand@confident.ru, lvc-project@linuxtesting.org,
	voskresenski.stanislav@confident.ru
References: <20240206194201.10054-1-rand.sec96@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/c+/7Pm9wtwRPq0h"
Content-Disposition: inline
In-Reply-To: <20240206194201.10054-1-rand.sec96@gmail.com>


--/c+/7Pm9wtwRPq0h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 06, 2024 at 10:42:01PM +0300, Rand Deeb wrote:
> In the npcm_i2c_reg_slave() function, there was a redundant
> comparison that checked if 'bus->slave' was null immediately after
> assigning it the 'client' value. There were concerns about a
> potential null dereference because of `client->adapter`, but
> according to Wolfram Sang, "we trusted ourselves here" Therefore,
> this comparison is unnecessary.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Signed-off-by: Rand Deeb <rand.sec96@gmail.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


--/c+/7Pm9wtwRPq0h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXCjeIACgkQFA3kzBSg
Kba5Ow//TTSg9C/r5uHjS757qdLJr5CtKt2ZGXCoiBz/JxVUr5V6F2diEjjqizrC
p0ixL2q1MDpvF4ZUAgwnI+Ht+e71py3Sto8MlfPRWBchfP/ugE9ehK+RWyOho43x
xNlwQqtSOqQG7NtpfOtNSnYHNSYpeD4/giZToeL2mV5d2cXidxYLP1rinoYni4ec
ECqS1eLZV+8pxdkd5X3Im7ahFfPb1hkrWr3yajswDxLdIo8ImEuUiVUMoau5cYNp
4ukBDe76MAweDpwMg4EyIoax2AYRl2ULub227IH5usbOZ1gTIZvH3DeLd5CMrhFx
kvqElCljKdAWfIxytJvTmThl4rMmdxo0/Sa1k9Jv3Rzhu9V6tTdm+WrG7pst5Fjc
9wlwgfUsbMCMMGc3QAlP7WfG9g4w4MwUCZZ9DI2gdHQTz9//y41fvAz2TAXz2MBK
ka7UHwGziX1bhomFJO4jin5mKlPceC0TvEefn2zh0pMTSL7puN3S4yYp45x9cKkQ
cl7iRX2+Na582dlJJWq3YZRBFTzGgTup0vrKPZ+lOG0esgJjOQ73oJoq8YC9qlD9
8gCbxtYMqWvzM3vdyRpL/z0YqDjgfd/3IDgchMP3IhX2w5b3aAahj2Cnr8SdQrfV
vM64XBVkntSTZpWDWGAaYPbB4eeLtLhz7RTexwSAMPJxMn65uNw=
=Z6/z
-----END PGP SIGNATURE-----

--/c+/7Pm9wtwRPq0h--