Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3286354rdb; Tue, 6 Feb 2024 12:48:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGgPpk3SFFcDw7WuMVSvfqtuWk4bmEn8iFOrVan0IaaiBrl4FV7+3JSAIuPRjVuu+K4KNV X-Received: by 2002:ac8:5fcf:0:b0:42c:396b:695c with SMTP id k15-20020ac85fcf000000b0042c396b695cmr2952270qta.33.1707252489215; Tue, 06 Feb 2024 12:48:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707252489; cv=pass; d=google.com; s=arc-20160816; b=zP+b729zuvAYInzItMW3gaWVtnIbuSt6WxwfEOGKQH32pHTW6X1XzClFEm1tcQ0/6b wjGlD/ALxGATTx1tZkLA6lKiHzbSOl+JBL/tgq9GoJ6WpA0GTL6hFp2mdp1uraXup5op 3+jHTuhtkN/XswYpEVwMafeRVyT16+Hg3f2KB7UjjJo/dT0p6OD/snuRd/vyYo+1/jWH t/xSW9VK0VFZLcgGck6mU6gBHDSZmH6bfFQWgteNX11f9dnllTuRlf4pNzQNv8dBSjBM J5omDln12KLcYFqh3XqlYshHwG3jOeguMjwAgmIm1VZrtYDWd2DSMfOskAK5NoarZEh4 o2Rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2OForWuv3G5uLMIRRlj0MBKmdJdz32/6OokJ3qDwVD4=; fh=opGBtiWFu5o9lqGNKM3ap08oOb6CTCd3Z5T8oKCwRQ0=; b=Vv7deogneHQkRqwiKCpiJUpXso8gIMfXzDvA5kfPl2vqaEkvDbEkBy9iETWhzitQiK BQ/86p4VPJ5FTJFvIkA/lWoHV0trObO+N8fZYDDLWcETeaMC+qAQoIcF7f0o4nkueuka yX8UQ0hEuktfl5wjM4xj3Zmff7qVoMPVhLZoxET73J2gl7luGY0w6dJufCQQWDEffKbt wOhQKhBxFz1+dASi3ChKJe6p54TNNgv89hAgeOWUO6y6ocI1yzdjbNByVAvhcmC7Wzpq vo5MbDz2LIp7YmDsjf+uYu/hNKVYkuk/5/dh9Y7hgyQhexOhpuu7iIc14UPEvXMfjgHp rh8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TgxoSG1r; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55608-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXroM3GVm6/EKzmzVb4iVF+/xOdNRBcinl4JsbQ15+EMmXr2CIV8MuC5z4/qTBRKVdDjDQNgcmVGds9INVuwmNHdeVAuPhs+exyLkTROQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i3-20020ac85c03000000b0042c2db33946si3148430qti.482.2024.02.06.12.48.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 12:48:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TgxoSG1r; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55608-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8D8961C23AA7 for ; Tue, 6 Feb 2024 20:48:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B2061B947; Tue, 6 Feb 2024 20:47:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TgxoSG1r" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD6041B940; Tue, 6 Feb 2024 20:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707252477; cv=none; b=kb+z4UmDujdt5sn4L9VNBjowQq0cJWmb8FFbC9u2MZFlsg0kxb0+k6dErF8pkWULprHa5gE993hRLKz/Fu8xodpfcc7zzfvDOkC4A8PI4nTGq8V7+vDybJNqlgVtLVZImsPqtqw4jClEHyqWn46N7GB9abitsBtVAxiYRUP5R44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707252477; c=relaxed/simple; bh=Jg40ieHbXF/G6oXsaLbvVU0RA1nGUVs4Ekk/gOizNXo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pSnbXnZOYyws84JjFp+iw2WapqSUzZMOB8BcHVAHUwSvTq2hsF42/ffRtGxGkLwm6VJLH/9C1zytAyuv76qszVbpH3Y4bd8sRyMsfJ99Uy5hHdl+mr0Q9/ZTSklL3HjTZUrxcJ6qFQekdpee8PUelOabCW3aMG6rTfRMryiRmCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TgxoSG1r; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC641C433C7; Tue, 6 Feb 2024 20:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707252477; bh=Jg40ieHbXF/G6oXsaLbvVU0RA1nGUVs4Ekk/gOizNXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TgxoSG1rlBydXWxeJ1JjV9mDfKZnJN8y3+ZcCGIKOu4s/Wg9DNzHm+N+zFgJU/RTl ehW98GWAFGh5qbEAyzotzkaON11uQuCSCXmht4xT7i9IFHWgpFEmi+6mcMoMOkdP78 7nJW20/X1hV6Unzu/mTEi2Xcbyq00gv4k1a0hKBulSAm9VActq8orpvGh+Kdu7qfcZ fZsZShlKVgs35SnN3gdslTTqaNM1fsMkMRDFwMg19p6swMXdHQuErR9czEejdk7YT8 VreX++lZPWzTASAP0qSLh7aqBNwgjCdC/bZJHgGBL2aZLyiPcCbIb8dYbFXZ8QumgV J/LTcRmIxbvTQ== Date: Tue, 6 Feb 2024 20:46:22 +0000 From: Simon Horman To: Amit Cohen Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, daniel@iogearbox.net, mlxsw@nvidia.com, Ido Schimmel , Jiri Pirko Subject: Re: [PATCH net-next] net: Do not return value from init_dummy_netdev() Message-ID: <20240206204622.GJ1104779@kernel.org> References: <20240205103022.440946-1-amcohen@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205103022.440946-1-amcohen@nvidia.com> On Mon, Feb 05, 2024 at 12:30:22PM +0200, Amit Cohen wrote: > init_dummy_netdev() always returns zero and all the callers do not check > the returned value. Set the function to not return value, as it is not > really used today. > > Signed-off-by: Amit Cohen > Reviewed-by: Ido Schimmel > Reviewed-by: Jiri Pirko Reviewed-by: Simon Horman