Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3298455rdb; Tue, 6 Feb 2024 13:12:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV4hR9KTbFGHFiHbLV1d0cA5616xfjoUgheAVLTW+99MzDoDzvq/rMKEnSn+7kV4fsv7g2LxErsKQ1lqB+kmW0S81t/qpW5niDe8JkVaQ== X-Google-Smtp-Source: AGHT+IGXYgL92Zv7JgZT7G3L6Z1mGxFm9TfeXgspABYuwImwaQ+9h4pKBZoZBEGIOUOAIR2TrCBy X-Received: by 2002:a05:620a:4722:b0:785:5b07:d4b8 with SMTP id bs34-20020a05620a472200b007855b07d4b8mr4131668qkb.6.1707253971627; Tue, 06 Feb 2024 13:12:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707253971; cv=pass; d=google.com; s=arc-20160816; b=odMHrW7BihlXisKvnVtrntObxKoTKBqJQ4dPBTQ6U1POYcHoe93LZ7puuRZcgnNVyX mU0wzh6ueBvTpMqQjCR71epIAdYQs81o9OxKoov6WP6iMkiUJjyBEsEV6l27Ov+rUQ++ UrWMu0KWSHaPzWnXVpLabN7DH5RsP3o9c4k/SjeAPpBiWH0H7LpaXp9xIt3UkfhhCbhb DRCxkopWOy/BCnY4eeSMdaApao1yp541kmNDMa1vQdQAhBeiJQlhxqQKob7PK/xOO35b CU12xEgvA+18aiKlo1Va6WSBzSzuH2J8OhP1469lEtCDW+YYhnI7MCShZeFXw06Y+HlJ h90g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pH4z4UKwceDQ2f9zFX4FLpXxDjaZqCXvUUyn1++Jaag=; fh=qkLBu4ExcmKy2LydDI9wXG+z3eYGkTYt9Eo3j3LrYSg=; b=CPrgSZuNG/H+BU0BiteCTkuwv5cizuywXZg40LF/QntHH1JaQCDFdgqit5M+OK65JG JmWqMpqDH8NIi/mpkC7aedCdQpUEIqInbb8AGJ/x+DU3kCwOZuKND4H9jrWfQOm5AptC nGP+WoVgHMdZMqxV7PsoEw7F/MwlzukvGUdDdS7X7Vch7rt+4MSFlfkh9tnOfSTdChhg k7hok3Gfq2M2bnO+V8U2wK1K9WxTNLUHJBZXTzhUrUOxYgKMR8SaXFfHoZEWARzJjuQn oijQiPaFVGuGlowrcRwXaGKT+LNXuggMUkjaPxggCC6gzcuFWvl6G9ePPO1kR1XS4TfR /fwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=WcOizr7B; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-55620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com X-Forwarded-Encrypted: i=1; AJvYcCVlKl3AlkOlBHMEfFMNEYBXUgrzf3bdKPW4HQEamhKwIFrcl8a1otNl4xeQ6FeJRIbsAsgev3Vevhl1sa29cRJWF6ktRn5iEHafJubaOA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d4-20020a05620a240400b0078326e1ecb1si3549328qkn.161.2024.02.06.13.12.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 13:12:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=WcOizr7B; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-55620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6384B1C23FC6 for ; Tue, 6 Feb 2024 21:12:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48F421B957; Tue, 6 Feb 2024 21:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="WcOizr7B" Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E93F1B947; Tue, 6 Feb 2024 21:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707253964; cv=none; b=S8rmdeynlsJSXEiVSBfn9Jp2RXSHzQO1Z+yttshpuNYmP1LUzpfXh7RuiB1ajmrV0jCGSaeYMnMmk45ClDVrozb2ElBJo9zbjB9U4oskT26u01hnm4sNhIlwXHPwLOBw7SllqzcoNX7fooqDzpXXAf9FM18uD7WJmVXlUzXcjQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707253964; c=relaxed/simple; bh=FPuvvimZTpaY25Gs4EyvjPMeN6Ad+s68r//oKWLrE98=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WZHSCptCEOevTYFedKr985Ysm3RnIVpJy6eBE93DEUk+Zi9FWijwhAx6DiWy2772PD4qEXd/jk99vkSISlz4f25iSu1iNXGdeSVTcF+C5pie8DxmgQeUUHjGKT5hWnx2QByPYJ/Hh5v4p7xL6GKovN87UV8vsa+8TIGwlIyw8ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=WcOizr7B; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 5541A1C0002; Tue, 6 Feb 2024 21:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707253959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pH4z4UKwceDQ2f9zFX4FLpXxDjaZqCXvUUyn1++Jaag=; b=WcOizr7B6r3RSJEO2d4RUKr8qOpQnPtM3BbM8ZhVPH0bboCmQaVP35Ve06Vet6+OG7hOpz DEM9gWKljSJ65UWpjFy/CRK6Y0ZoRrfnjopM2Bam2GMga0j+WF2hEvXcKbBjNkU493sCjY yGV8L8LEzdKab7yy4M9K4B+YvjOGew3l1c3s+VOOtHBW3THZOOeNxpn3a+ZvOGqYPBLMcU f+qK8tkvXYqC9w2L5czXDVbt3vyiHM4mbQYfT044Z1+cEz+SxZ32GG7zpIaspd0qIpL0+s Yef6Zw59Rozepg5kjU989wQmbdR4W0267nMMDFVUyG3IF8XjxISSP1FAVizJzg== Date: Tue, 6 Feb 2024 22:12:37 +0100 From: Alexandre Belloni To: Chris Packham Cc: Krzysztof Kozlowski , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "jdelvare@suse.com" , "linux@roeck-us.net" , "antoniu.miclaus@analog.com" , "noname.nuno@gmail.com" , "linux-rtc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , Ibrahim Tilki , Zeynep Arslanbenzer Subject: Re: [PATCH v6 2/2] dt-bindings: rtc: add max313xx RTCs Message-ID: <20240206211237d9192660@mail.local> References: <20240202025241.834283-1-chris.packham@alliedtelesis.co.nz> <20240202025241.834283-3-chris.packham@alliedtelesis.co.nz> <5d4b7fa1-5cc2-4a4a-8fa4-d2c7a8d070b7@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d4b7fa1-5cc2-4a4a-8fa4-d2c7a8d070b7@alliedtelesis.co.nz> X-GND-Sasl: alexandre.belloni@bootlin.com On 06/02/2024 20:19:20+0000, Chris Packham wrote: > That is an incredibly good point. The max31335 binding covers one specific chip. This binding covers more and with that there are a few more properties that the max31335 on it's own doesn't have (e.g. the clock consumer, the ability to have different i2c addresses). Binding wise I could probably roll all of the max31335 into this max313xx binding. > > Driver wise things are a bit trickier. I've only got access to one of > the variants so I am hoping to leverage the work Ibrahim had already > done. I could attempt to incorporate max31335 support into the > max313xx driver but I wouldn't really be able to test it properly and > there is a reasonably high chance of regressing something. But I won't take a separate driver. Everything would be better if Analog was sharing the datasheets... -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com