Received-SPF: pass (google.com: domain of linux-kernel+bounces-55647-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <47d130f2-7d86-4d08-98f9-186d38ecbdbd@intel.com>
Date: Tue, 6 Feb 2024 13:44:44 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 06/17] vfio/pci: Remove interrupt index interpretation
 from wrappers
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
CC: <jgg@nvidia.com>, <yishaih@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
	<kvm@vger.kernel.org>, <dave.jiang@intel.com>, <ashok.raj@intel.com>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <cover.1706849424.git.reinette.chatre@intel.com>
 <ca249ad459c07a36cd64137ee1cc107dcd8b6f4c.1706849424.git.reinette.chatre@intel.com>
 <20240205153502.051ff2bf.alex.williamson@redhat.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240205153502.051ff2bf.alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlZLT2ZNZUkxbDFXcmVqRCtmNXM3S0dmdWNUeHhFZ21zUHhnSWtBTTdLaEtB?=
 =?utf-8?B?d3I1VXJRU0tneFEzTXBTeXFDdk9hTVRMZTVoSVQwaXZHUkVaVWx1VXZIVzVJ?=
 =?utf-8?B?alRBL2Y5RU4yN0F3ZXdjSHU2dEUvaVJQaE8xV2xIcTFFd0hOVlQ5MnhqR09r?=
 =?utf-8?B?UFhvNEtVQnRLcHY3c1Vna1d2aG5KYlJ1T0g5NHlseEEwb0I3eTZkUmJ2SmZv?=
 =?utf-8?B?dmZUOUxYS2k3Wjc1eEJsQTcxcDJVWXR3SStjcGRkNHhRaExpQXlERTVXWWtC?=
 =?utf-8?B?Q3pFRC9IdmpURFRpSG9EZXpBRTJ1KzlSMHhBaW4vcXV1RjFlcVd5QlkyaGVM?=
 =?utf-8?B?S2pRSzVFbHhIMzUwN2Y1R1M3Z3VQSTk1Vk9XNDlZazRSeUtxRFFHaE83TkIx?=
 =?utf-8?B?LzF1WFRXd21IaWl4MG1kRW10MTlhTkFvVGFCWVF3MHRqZ2o1Zy9qZ2hNKzMx?=
 =?utf-8?B?c3NuSk0weFBsK2VQcEZnSnNrUnE0QlpBekVpS01kUTN0LzJ2bmRjMGVjVWky?=
 =?utf-8?B?dC9uWnk1bW4vS3NGQzRiU0h0eEcyeUZKVTBvSGZTMTMxSkM0TGVtakkxR2JC?=
 =?utf-8?B?ZEZnWVFnR0FZRzBZV2hTOXJKSHpHZklGUmIrQTc5TDhMVzVkQmQxZW1BZE9B?=
 =?utf-8?B?WFV6YlZjUFNwRFpscTI4c2pxZzl6RkNIcnRVTnZQTXBUdElKeVFhbnRKdFl6?=
 =?utf-8?B?VjFyMGp1SkQ3cS83alRrdDhpVXA0bjYveVFyMVg2dVB3WFM5YXpJTXh0OThx?=
 =?utf-8?B?QjVQZy8xbFdDR2Z4bWczVkQ4Q0NtcVlDcjdNUlRoeEV4cTE1U0VXdmxzTzVy?=
 =?utf-8?B?MGFlaFZxTmtaZ2s0enJ3NGd2YXBHQWxLWVNVQ1hhVTVNUlZEc3d1ZkZzTU5x?=
 =?utf-8?B?WWNod2dFTXNFc3Q2S3YvdkV2SDZDbnpDY25HWU5UTTZGVXBldStLSjlvRVVP?=
 =?utf-8?B?cU90RERwYW5Jc0tzYVFick1PVU1WQ2hoRUZ0bFRIVkFNVXpXdXRNN0NOU1Bw?=
 =?utf-8?B?NGVxMFFGT29UZ3Y3TEJBSUZpcXFsTmNnT1JrYkhEMjRoSDZnLyswSTg3c2tZ?=
 =?utf-8?B?TGtQSkl4V2MzOTBPbENGM2VNYmprVEhUdkZ6ZUJqakFscmhmOUlrMFlpcHhp?=
 =?utf-8?B?MkpGVWJHck1JMkFSb0Fieis5VHNsRGVsWW01dFphWi85RWNkV2FySEZmWG1i?=
 =?utf-8?B?ZE1LSi9IVm1FdE1RQjZKZEIvZS9FRFB0U0VWYWVaZTU2eGtyOTFNSjdjZ3Jw?=
 =?utf-8?B?L2JoMFUyMVBHdzdVTEVDeE4xRDEvY0Q5aklqdGlpK1lsTE1laEMwTXhOL2V1?=
 =?utf-8?B?SDZ1YUlaYkxSMnVaNWhUVTRqRUVKRTA0MnFIR3V4T3pFQk05dkdKYndRbmor?=
 =?utf-8?B?OHNqdzlHaURnV3F2azVqblc2RXdMQzFLWlR2eUg4Y1RwVHVFUmc2dGl2Q0dG?=
 =?utf-8?B?STBpajZCVS9lam9ORlhnWXpWZXVNanB6TGk2QjVpOVVNRTV1Yy8vRndJbUlL?=
 =?utf-8?B?WVIzQjd3UGJaQWxxeVdsNS96QnRFbXlkRThVNDlWUURmS1JTRUtZRkhLeTVZ?=
 =?utf-8?B?bzAvbFg1UElDVU42TXFSMWkvcU92bWo1M1dpUzRTOW9GclorcHllNFR2TUly?=
 =?utf-8?B?MUJGdk4xWDlXQmFiQUgvWTJyR3dkQUJMUU00UVhvTFJPaW9taGpCTGFMaWtl?=
 =?utf-8?B?SXBzNDJYSGJ6SE84UXdKQWtKQzJENHVTV2tDcFJhU1R3SktEcHpiM0Fuc2VR?=
 =?utf-8?B?ckY5OGRaNitEN0s0Q1QvOGkrbEJQMHVDYS9tUWhzdjU1ZU9lRlZLVjVqOWRQ?=
 =?utf-8?B?RWNoYWxVTE05UCtPOWdudzRVWWhva1NtZGFxZ1VUUXlGUWd0THpNL0M5Y011?=
 =?utf-8?B?dzdncGpkU0JUbkplZEw1akhkQVpDSG9uaUZhN1RrYmlkc3oyRlhOVlA0a0VM?=
 =?utf-8?B?aGNWRTljOVBEYjVSUFBRa3dscmVSeEJ0aVVCeG5oM2NpZTduU1RBcE8yek5r?=
 =?utf-8?B?SlFhR3pLZGpXaXlZQWhUME9QeE81bnlJbFp5c2hlbndEVlZuTWVySmQ1VjNU?=
 =?utf-8?B?dkxlN1pCODNyMVlTZm5PSUJBVTcxaDlZTWhEanZmM2gzSlA0Umtmdm9INDRa?=
 =?utf-8?B?QWRGMmViVmVCaVBUWjlSZU8vRHpYdE5sUmp2MVFuN1RvbWp4VTVHWmxOSUQ5?=
 =?utf-8?B?N2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 87c81db4-5dc5-48a5-d6c9-08dc275cd563
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 21:44:45.1346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sCfvLwv9DZle/jdvaahCBo3cGYHcQZRfnnvJ4loFcnYRRkhwDxyEb0H56XBmbna73utWQ0Rb/EFl3SBvHIm4Ll6TSfcaP6RmxGbWcmq9m0g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7367
X-OriginatorOrg: intel.com

Hi Alex,

On 2/5/2024 2:35 PM, Alex Williamson wrote:
> On Thu,  1 Feb 2024 20:57:00 -0800
> Reinette Chatre <reinette.chatre@intel.com> wrote:

>> @@ -413,8 +415,10 @@ static int vfio_msi_alloc_irq(struct vfio_pci_core_device *vdev,
>>  }
>>  
>>  static int vfio_msi_set_vector_signal(struct vfio_pci_core_device *vdev,
>> -				      unsigned int vector, int fd, bool msix)
>> +				      unsigned int vector, int fd,
>> +				      unsigned int index)
>>  {
>> +	bool msix = (index == VFIO_PCI_MSIX_IRQ_INDEX) ? true : false;
> 
> Cleanup the unnecessary ternary while here, this can just be:
> 
> 	bool msix = (index == VFIO_PCI_MSIX_IRQ_INDEX);
> 

Will do. Thank you.

Reinette