Received-SPF: pass (google.com: domain of linux-kernel+bounces-55650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6319e446-0d9a-486a-a614-aae2b16b93e6@intel.com>
Date: Tue, 6 Feb 2024 13:45:35 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 12/17] vfio/pci: Remove msi term from generic code
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
CC: <jgg@nvidia.com>, <yishaih@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
	<kvm@vger.kernel.org>, <dave.jiang@intel.com>, <ashok.raj@intel.com>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <cover.1706849424.git.reinette.chatre@intel.com>
 <0550572e64505df6ecff0b08f1eca869a79f6acf.1706849424.git.reinette.chatre@intel.com>
 <20240205153526.462e32b0.alex.williamson@redhat.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240205153526.462e32b0.alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wit6VU5LSy9DVm5zd3JxZUJzWTNZYktGNU54VGt2THRNT3FUbGxUVE1JdXJM?=
 =?utf-8?B?aHQ5V0Rqbk9Edm1wSjN1UXAzYlFPaDNQWVZ3N0FYb3V5dHhnQkpnMU1iQXZM?=
 =?utf-8?B?akJZcnFzK09xYmhPRVpRRHlDcUllUjJIRVFjQjNNZ0dhdFkxNjFIeEkwc2VN?=
 =?utf-8?B?VE5ldUlOK0JiVE9WbjJtb3loVkJFZTUzZFFPZzFrQmQxQmtkcXNJLzZmanF0?=
 =?utf-8?B?U0VCdnBCaEQ0RUVybWdtbTU4TkNndGV2ZEFBUmFYTE5nZktNaGZCOXI2S294?=
 =?utf-8?B?NjMwdWxJQzlHR054OVpPcDU3WmxPcVNEMFhmRTYreFVnNytZZEc3SVJVYVNk?=
 =?utf-8?B?THRIOTZaYTVkSGE5c2c4UU5CejR4bzc3WlRYNW4xTTRhQjdOeGlBZ0ZPS1Qv?=
 =?utf-8?B?bGE5TEloZ0NDODhpLzBERU1LaDg3ZGlGTmhzc3dUNkZVNjNEY3ZVSUljTG1z?=
 =?utf-8?B?aThITU5WREFuWk1CU3VOK01ydVZiNktNRW1xQ2RKVEJhcEdFQmFsTjdGcFlr?=
 =?utf-8?B?WHJvUXRlSXZaeXlGQlNSKzNqQzV1clhDVWV1TjJOYi84OHJCeFV0V3FDeEZ2?=
 =?utf-8?B?WkxYUjNKMlljNVJWQXR6Rkc2UjUrZTNYZDdiWEVEQTNyZXZqUzhsY3NzVG0r?=
 =?utf-8?B?ejdOSFd1NHk4NFRhclJTVjc5Nm0xSkYyMUIyRjhicEg2aE5IYWRreUpRdkIw?=
 =?utf-8?B?MDhPait0K0R0c2VKWExqVzlDckpvZ0NQUTdiVWNuQXVBcnBHRVVXL3pkbk1J?=
 =?utf-8?B?ekdURTFJOThDK1hLM2FZcDVPeFhIbnY3VTAvWEs2L3VKVUdDb0xab1BQRk52?=
 =?utf-8?B?MGJIL0thWm43OEp4TDNVeUF4bU11TnhrTm1WSHY5R3ljazZoMmVtTEs1TU1s?=
 =?utf-8?B?bDN3L3E0NXFDcWpZbFV3WndxaUMvT3lSQ1pGVlNDeFZaZ3lpRStMVzRvZnJn?=
 =?utf-8?B?R2dNZnkwYVBaZ0FOTzg3eDZPTFhPTmIvN2I4OG9CaWF0Z3htelBpRWljSnJm?=
 =?utf-8?B?ekZWaGgyQTZEWEVrYzJKbnVxK3V3RklGa2V5VXJCVlJFQ1Z0dVRlbnFlK2lP?=
 =?utf-8?B?eWtuWnBWdUV1NTFrTkR1RnNqNVZBQStNY2NZNFMzeEFpbzJ1c2MxWit6bklp?=
 =?utf-8?B?MFhIWkpQVXhmdk41RGxPdnJSMGpYS2NVODBrVkI2RXBEajFZTzQvMHpER3VZ?=
 =?utf-8?B?b0hpQjY5aW1rNmlQdVlHdklydEphUm9jNmJzMHROeWQ1SjJXY05CVGJVOHJX?=
 =?utf-8?B?MmlWajMvV3EybWovOWRCcEVaQTZPRXJHRksvLzMwRDVVOFJhUmhiS2lvTk9W?=
 =?utf-8?B?UUJORFlLRkt3Wk5tb0h1eHlmQy9sMmhkTThYVnd1Q1VJWlVUNTFGVXEwTXE4?=
 =?utf-8?B?UmgycUkyQ0pIY2NmRHl2UkRBZ052Z1hCL1ZLU3JrY2pwSzNycTJHYURpUmxj?=
 =?utf-8?B?NUVPSHpjZVduT05UaEw1NStxdkpWa1ZqSzM1REcxTHVqd3NmdjUxR1JnWS81?=
 =?utf-8?B?SWttRXQ3bCtBLzQ4NXMxaE1BVVpNa0trLzZybnlLUTZZenZCT051WWh1NzlF?=
 =?utf-8?B?SStDNXE1empldEJQZ29xanlFOTJCQS9yT01BeGoxSjBRUWd4d1VYT1RsQzY5?=
 =?utf-8?B?RWZtY0dpYTMxTThjRzliOEt2ZC9aQW5YY2hKZnhaWGQvV2lveWMwUy9CSEJE?=
 =?utf-8?B?bTFNblhNK3RVNms1NVlFZmR1UWR4UlM0OXBiN3g2aHc2ZFlobk1UT1R5U1pP?=
 =?utf-8?B?NGVMeFZHZHl4emZ2bWk3QUplM2M1WDl6WFc1UFU2WEk5SnRVMFM5Q054NDBa?=
 =?utf-8?B?UjE1WkNHYUNqMk8ydktaRG15YXVlRUZtQTI2eHFpSTRwNi9DTmZocE93ZVNC?=
 =?utf-8?B?U0VNYUlrRkMyQzRnaDYxMFBYbmxYdEYrVjV5ejhaVVY3eWNuM0lPRG42aG9Q?=
 =?utf-8?B?R1pOKzV0amVjWEtEbWovQ2NpRGpMb3hTLzh4MmEyMk51T2U4ZEtRbkpaVSt1?=
 =?utf-8?B?VVdxZkZWYlVCdFBUYmthMVFyclFta0oxU1RtQlROVUVJUnJvTlFlaGQ5NGNK?=
 =?utf-8?B?ZXpGOVRhU1B5VnNIbTEzcExOam1RSnEweHBaRFFHaWdWRWdVd3BtKzg3akkz?=
 =?utf-8?B?eTlLZlFDeno1MkM1dVNuZ215VDhtcVltNWxaSkl1dU5XRWVKeVNaYmVqbVhZ?=
 =?utf-8?B?SHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 158056dc-c122-49a7-0baf-08dc275cf408
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 21:45:36.5682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SDVSYx1DijuzjACNQDNNCYtn1xh/k91Oi9w+98auyjS4w8qptASHX0v0g/XYQffZM7txJmqXmg46xc/oOabDmWazvrn8ZZOxzWCHr6RpZOw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7367
X-OriginatorOrg: intel.com

Hi Alex,

On 2/5/2024 2:35 PM, Alex Williamson wrote:
> On Thu,  1 Feb 2024 20:57:06 -0800
> Reinette Chatre <reinette.chatre@intel.com> wrote:
> 

>> @@ -786,14 +786,14 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev,
>>  		int ret;
>>  
>>  		if (vdev->irq_type == index)
> 
> It's unfortunate that the one place in the code that doesn't use
> irq_is() is the one that turns into the central callout function, maybe
> we can fix it along the way.  Thanks,
> 

Will do. Thank you.

Reinette