Received-SPF: pass (google.com: domain of linux-kernel+bounces-55653-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <541fcb26-8f37-491f-bec2-49efb0693c2a@intel.com>
Date: Tue, 6 Feb 2024 13:46:46 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 17/17] vfio/pci: Remove duplicate interrupt management
 flow
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
CC: <jgg@nvidia.com>, <yishaih@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
	<kvm@vger.kernel.org>, <dave.jiang@intel.com>, <ashok.raj@intel.com>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <cover.1706849424.git.reinette.chatre@intel.com>
 <6ec901daffab4170d9740c7d066becd079925d53.1706849424.git.reinette.chatre@intel.com>
 <20240205153551.429d9d76.alex.williamson@redhat.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240205153551.429d9d76.alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVg5WmtkSHN5QmloaHhFaVRuQWhpYmlNY0JZNXp5UEloU296eW1HUUFVREov?=
 =?utf-8?B?UUZGYVE1OXExUlQ3bFU3NjNQWnBFY2xOdHM1N0xkRWhsUXBFV3FYaDRDUnUr?=
 =?utf-8?B?RERoTXN1ZFNQbUJCdFB3RlRLVG5qVkVYcEgxbVI4WGdHQkZCOGdqSEgwbC9K?=
 =?utf-8?B?UUxnRHZ5dWVFVk1GVi9LOVI3aXFlR1NZcHE0b1hTTXd4VkMxZEJTUHlJRTR1?=
 =?utf-8?B?T2VtS0RrS1BDaGVvK3F0K1crYUVYVmdLQlZPYTNmeDhtMjIydmtQYnJHbGI3?=
 =?utf-8?B?UjJ5ZklVTkxmbkxhTmFOS3UyYWh2M2hpOHJISXhzSWJlWTlITmV5akc5UllD?=
 =?utf-8?B?K0VSNk5TZ3YyUytoRTA5L2d4TUhaaUpUNUJGSkE3cXA4ZG82Z0kxRmQzc3dx?=
 =?utf-8?B?M0ZpNERUK1RPYU5Idmgrc1h4SkpVMnN5VElWRm05QmhFVDBiYklSMnJ4RXR5?=
 =?utf-8?B?VUl1OG5VK08yS3NoNFZub3BpWjRMa2lEaFRySkpsNmgwaDhJblg1RE8wUmsy?=
 =?utf-8?B?L1dwYXF4N0UyQ0lUcFNZMWhzbi9Fdzlrb2ZjQjNveGh4dForb0Via1d4bHMy?=
 =?utf-8?B?MVhNWXhJYk94cU0rSGo1eHo3c1RHVGtOaWJtdmNnRXFMSGJoUzBsV2NiSEtM?=
 =?utf-8?B?RDF3RXhnZ1ZvOVRRNnZOQVVvT2JqVERhOUdnM3dEU2YzYmVONUhBcU5icDd3?=
 =?utf-8?B?ZkVwd21ubTVMQ0dnUkhkQjBMWmhuUm8xakpNR084R21SSTJrM2Z2NWpoYUI1?=
 =?utf-8?B?c1pyNGdZSjd4ZTdjeGV3TjNnTXg1ZHFQNm00cmRCZHVFMkRuMlFhUWY1QUJM?=
 =?utf-8?B?cXN4YWcyYkY2c3RidHlXL0hyTWdwQVUxVlhFYjhUNjFJVW9ranh1YXNYSENi?=
 =?utf-8?B?RW95dTF6WUp2eU1JZ2FZT2E3SmIycGQ2UDVEZmVKcUVVYUFNRC9QRHcxNXg5?=
 =?utf-8?B?NEdLSWhKSGsxekRwN0o0bFNWZTMyd1pWMzRSdnZBUWtWVWVNOC9VZ2EwWGtK?=
 =?utf-8?B?UFVTOW1UQXQwdHdoeGlKbFFyM3BIcjZPVTJjOUNQcndiMnJjMm9NZTVjK0Jh?=
 =?utf-8?B?WGcxM2FsYXMxNEJFQ3lDMEhjdTlCd1JtMWJLRTE0dzdIUHRrSTVCYy9IU3h2?=
 =?utf-8?B?TTQ1a243cHpaMWZNODEvdVdmbm5Md2JDVVBlLzJRYnBQRUM4QnllUTZpK0J6?=
 =?utf-8?B?eWZTRGE1N2RKbEtQcE5USVpMYStpdXJqQVEra1Fkd0lKZndhREhUeWJiRXlj?=
 =?utf-8?B?cC94enRKU201S2ZuS2ZsK3F3YmI0VDg2YWsxcFhyeElJTjN1VVZETWM1OEht?=
 =?utf-8?B?OU8vclh2REVocVRldXRpZzR3bEJaVVMvdVc5bW80SDhPT0VXNDMveUZaVmlU?=
 =?utf-8?B?bmFxaEtwWXMxN2w2OGdRcXlINnJIQXNpcDBsR1lUdWgzc0lOOU1memZkUVhV?=
 =?utf-8?B?a3lvNEVqWGt5c2I2RTlxWXg4cTdvRWpVcUwvQllnSkVONzAzWUVxK1NyMEJV?=
 =?utf-8?B?WGx5S0J4TzFRSWJyNTllaW1HYWxXMFhLbDFjL0xDcFJnYWIxVEtDTTBWTnQw?=
 =?utf-8?B?Rnpwa1psUTV5Yzd4amFoYUt3TkRWUFRVU0FXRW0yVUJjZnFLYnY3Rm51VStv?=
 =?utf-8?B?UUNUb0tEK3pKUXFLOEpmOWZqQ2lKN3RrZkxBQ2I4TWFnOFQ2SlZvd1hPdWVS?=
 =?utf-8?B?dkhrUmhEbkJCYVFzWkxkYWVsTStXQzZneDZtdkUxWDBjYnZ6NEtSbldZM1Zn?=
 =?utf-8?B?a0hOQld5bGJEbjVUSWt5dUd5SWtYVmVkL0Z3QTVjSlFBZml6SC9ySVZKNm4v?=
 =?utf-8?B?VldVby9UQ0xQMlQ5K0V6NzBFUThPT2lubjUxMHBzQlgyYlpidzBRL3hVS3Rv?=
 =?utf-8?B?V2xlUndLQWtsMWdsUVBDL0Nma1N3TmdxT0ZPMUJIOFVnMW96UzJEOTlkeXJn?=
 =?utf-8?B?ektLRHl1Vnl0MG45TE4xZng1YkJEZUdMQWNyZExiM1Z2VnR5MjRUYzJrbU9i?=
 =?utf-8?B?UXhkTnFEa1R3aWp2ZlYxZ004Q2FFcUdPTW5qSnVIQkl1alBaR0ZKakN2bmpQ?=
 =?utf-8?B?MnRrVDEvQlRmYWZzeDBhNFladW1LZzNOSFpMaUdNa0F2NGlhRzJrU3d4eEJP?=
 =?utf-8?B?YnNCbk80eUVaeG5SUm92RjV3eHhleHRET055OUpvbW56bTFzOEV0UStNMEJ3?=
 =?utf-8?B?Unc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90c27cc1-52e3-4046-ca03-08dc275d1e28
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 21:46:47.2085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D7htq9/3wM/pxwwhWw5/VPHZBbTl/dJLTwN/SRxi7AecFHBM4BowjJY8WQxJea+d1cDnG+fLEv/zepzKfGlXhM65xqn2jzix5Be2jQQDRiE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7073
X-OriginatorOrg: intel.com

Hi Alex,

On 2/5/2024 2:35 PM, Alex Williamson wrote:
> On Thu,  1 Feb 2024 20:57:11 -0800
> Reinette Chatre <reinette.chatre@intel.com> wrote:

..

>> @@ -799,11 +765,11 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev,
>>  		if (!ctx || !ctx->trigger)
>>  			continue;
>>  		if (flags & VFIO_IRQ_SET_DATA_NONE) {
>> -			eventfd_signal(ctx->trigger);
>> +			intr_ops[index].send_eventfd(vdev, ctx);
>>  		} else if (flags & VFIO_IRQ_SET_DATA_BOOL) {
>>  			uint8_t *bools = data;
> 
> Nit, an opportunity to add the missing new line between variable
> declaration and code here.  Thanks,

Will do. Thank you.

Reinette