Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3325762rdb; Tue, 6 Feb 2024 14:17:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFsxwLbF6kA230ZL0ZsUxArBA/CDpHZN83f+Bq1t2wcQIZJa7I5oEq90RzHphoXCu17UtS X-Received: by 2002:a05:6808:2f13:b0:3be:b8cd:576f with SMTP id gu19-20020a0568082f1300b003beb8cd576fmr5445600oib.7.1707257836098; Tue, 06 Feb 2024 14:17:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707257836; cv=pass; d=google.com; s=arc-20160816; b=OEN/CwRgoOYsx8Xzj/RCXaRSjS/D0wtiKdrcUeRjKbUclWwCLfNPiULXbIrSCC2mXT sCjWT/tQrj+xaNbN+B3w28qaFC0ukR/gJUYQi/Uqw5Ak1LpfwVG9onDcIMhFeiICYnx2 feHiAlW1UdX7S7KEtDzJQaSneIT9bikJiNdHgDnwKQWZtlP4Bt+CMD9/tz5dvRkQ0YcF CRg6OuWlp0IOVpSR4zFJ0QvUA34nRW+YLNSAm7AdFGh9meT0O9wxj8uaEJlOStFLR2EP GukSmf+5mWHXNtYOF65W6GKf0sfOtabIkY/kqGP4YlUjnUerZZeIY6mdTBnY9/F1IaLp 2ytQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CyGTWHQrBLjLWWo2xOLwLlHdJNVmydb/RrvwG6gICsE=; fh=3yVN3okmYtwao5Xy46AnQEBQYow6+sl5pHZgQg0tqDE=; b=s41Bn2SxY6UYVuKBR/E3tzQeGdJs42jrW2UTB43d0kVexug83uWrouoeGFAvDFklnb 8EwPUS/KnSGeXnP+QAXYb2BmMMOxlYDXycU7e7Mm0gc6jdXX0sGjp2ZT2s0lEQuU6M6L fimpS175NnuKSpc947FmrpcZoZMXco4UTacohbqIA0g5gU6rxJA7LkW744PtJBEhqs7L qLhQ/DuRE7dTJ48sdAu7w3sK5IFh3qE1sC+0rLPYMFMHxWL7GPqErt/ollmx8Sn2oN8i Wm+izD+bd2VTAKIlUKrN4kituDJSdypx9kgjbs0dzK8wts4ahU/ab8vBwKOw0geaowWd z0Yw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=eDPGFkMh; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-55684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com X-Forwarded-Encrypted: i=1; AJvYcCWKKxWmid6lPO1wghFz9VZ8aNO7i73Th2UGHj2NDNq7gOBHwVEdoMwIKxt4IgOZa53yVdwSMumQm1QNv0xF2XY4vW3cN4XeFKYfUk6rig== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p2-20020a05620a112200b0078565a992e9si3183983qkk.364.2024.02.06.14.17.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 14:17:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=eDPGFkMh; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-55684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CC9D21C20E2B for ; Tue, 6 Feb 2024 22:17:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1ECB81BF3B; Tue, 6 Feb 2024 22:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="eDPGFkMh" Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9851C69D; Tue, 6 Feb 2024 22:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257817; cv=none; b=cK3Wftq3L+1OXWRCn17UDFiQj1cJkOIinTrQTbtiwGu8GvDA5LU7A//+MKvLx6X6OCMTeHFce/uJpxMBukDC4HmN47DT4c2owjvbturK+oB9UrxLNjrgsNsVxOn4Q4Ptb7e8AW5sWjhbUIgbA9mYBSmvL4dxqG1GlpFlkQGS75M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257817; c=relaxed/simple; bh=6e1eWi0XVmAapbmVvkOieE4PlZ6Y5JmX2oQHiJNDA4I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TNXRpOloivLAlbUFPIhQy1K7s7E4bgvIXuUuOovTKd6UO1BL9zMx/3xUGNw/eBo/r3bHTKHDRWmQSueJQuyL97kRh0P7h0s60+KBUia12rnl906LazZieGowZxjE+uxNt68j5alUl8O5mBqc3VrO+sjXGRzAVRNe6skWnlAY0sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=eDPGFkMh; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 7922DC0003; Tue, 6 Feb 2024 22:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707257806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CyGTWHQrBLjLWWo2xOLwLlHdJNVmydb/RrvwG6gICsE=; b=eDPGFkMhJtW98eEXH+8tczLIX6hPffiNAVnEoGkDgYDk9vHlaQyi0soDNIiGwJkMgpQLYs rnvxBi8rIQkDR6gv16wy5yqCJsGuGhBoDBah0an0S43gtuGE9aRjhNZK+tCUQVfaUBSgMu 94h21on8yVIjkA3CXJUbNEYKRofl/+UwCJr8RXFh271DlCYIRPFv+4urO1WpP0zibi2L1g p5Hg6r3UEk/XtT1TGCSRNMddTgXZoqxoj/bL3Ag13Vp4AzcVCz5ldAcTKmx8Tc0lk92vze QvkXJrSFLzn7/+kNCa2h1IVfGtQ47rOtF3X5UA+GfHgPENq6tHT/Ps8gJe3jgQ== Date: Tue, 6 Feb 2024 23:16:44 +0100 From: Alexandre Belloni To: Chris Packham Cc: Krzysztof Kozlowski , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "jdelvare@suse.com" , "linux@roeck-us.net" , "antoniu.miclaus@analog.com" , "noname.nuno@gmail.com" , "linux-rtc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , Ibrahim Tilki , Zeynep Arslanbenzer Subject: Re: [PATCH v6 2/2] dt-bindings: rtc: add max313xx RTCs Message-ID: <20240206221644f524816e@mail.local> References: <20240202025241.834283-1-chris.packham@alliedtelesis.co.nz> <20240202025241.834283-3-chris.packham@alliedtelesis.co.nz> <5d4b7fa1-5cc2-4a4a-8fa4-d2c7a8d070b7@alliedtelesis.co.nz> <20240206211237d9192660@mail.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GND-Sasl: alexandre.belloni@bootlin.com On 06/02/2024 21:41:10+0000, Chris Packham wrote: > > On 7/02/24 10:12, Alexandre Belloni wrote: > > On 06/02/2024 20:19:20+0000, Chris Packham wrote: > >> That is an incredibly good point. The max31335 binding covers one specific chip. This binding covers more and with that there are a few more properties that the max31335 on it's own doesn't have (e.g. the clock consumer, the ability to have different i2c addresses). Binding wise I could probably roll all of the max31335 into this max313xx binding. > >> > >> Driver wise things are a bit trickier. I've only got access to one of > >> the variants so I am hoping to leverage the work Ibrahim had already > >> done. I could attempt to incorporate max31335 support into the > >> max313xx driver but I wouldn't really be able to test it properly and > >> there is a reasonably high chance of regressing something. > > But I won't take a separate driver. Everything would be better if Analog > > was sharing the datasheets... > > The datasheets are pretty accessible so I'd give Analog a pass on that > (they're certainly better than some vendors). I'll include some links on > the next update. > The max31335 is not available > I'll attempt to roll the max31335 into the max313xx driver. I guess this would be the opposite. Renaming a driver breaks existing kernel configurations. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com