Received-SPF: pass (google.com: domain of linux-kernel+bounces-55685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <73afcdcf-8836-41b9-a3c4-ed4abbf877fd@intel.com>
Date: Tue, 6 Feb 2024 14:21:19 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 07/17] vfio/pci: Preserve per-interrupt contexts
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
CC: <jgg@nvidia.com>, <yishaih@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
	<kvm@vger.kernel.org>, <dave.jiang@intel.com>, <ashok.raj@intel.com>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <cover.1706849424.git.reinette.chatre@intel.com>
 <d6e32e0e7adaf61da39fb6cd2863298b15a2663e.1706849424.git.reinette.chatre@intel.com>
 <20240205153509.333c2c95.alex.williamson@redhat.com>
 <6cef4f69-e19d-4741-9cff-a9485dd58d89@intel.com>
 <20240206150316.66e24a8d.alex.williamson@redhat.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240206150316.66e24a8d.alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXNMMUxnNy9JeXpTTHBFTStLMitBKzlFRzNzakJiVU4rR0NKTlh6VWF4MDZR?=
 =?utf-8?B?N1cxN3ZHRml2aiszWHc4SFJVU2dRd1FSSGFBallaZitzUlNLKzhGNkpOQk1l?=
 =?utf-8?B?a0lucnBoVzZvMEtrOStqSk9yZzBlMFg0QU8ra1FtY2xXRHk3SGRwc2RWWHRC?=
 =?utf-8?B?Smc3ODlXbVJqajRkZ0xIcVVob0dJUjhIM2psZkIvL1BUckUwZEtUL25lZlc0?=
 =?utf-8?B?R0FEYXlVTjJyL2FBYlg4a0JvcXpvL0lPVHFnc0UzUUhHY0Jpc0VQYWJ2THNy?=
 =?utf-8?B?TzFEM3pLdFRjZlZrQVByakE5cS9mdEtZeXdEZ3pGT01FclZPNTN4ZnBPVXp6?=
 =?utf-8?B?bjB2UExIc3JmV29DQ2EzVi9CVDJTSnUxakJzVGpJdUZncnFvVXZ0SFZWTkxQ?=
 =?utf-8?B?RW5RZDljMHM1NlZDaUxqUDgwVlBOYWthVDIrNENrbER3Qmo2bmFQelJMT2Jx?=
 =?utf-8?B?UDVXdFEzaHI1ZFF1OEsxVkNVckhWTEpBSVcvY3FlT1RZaG84aDhzZGd6TU4y?=
 =?utf-8?B?NDB4WnRueE9pM0J5UEVDUWZDU08xVjZBZUdGcVo1VzZUSmxlQnhETlE1Szcz?=
 =?utf-8?B?VWxrbDZDNFFxbkVaRTV1d09PSi8ybC9UbTdwYTNFNXcwdUwzZW5YdlFBa1pF?=
 =?utf-8?B?SHdrV0xTM2R6QlBNeUtJaW92WFltTkpyYXVqVnBDVndLTU4wRHFpMDBrTkJm?=
 =?utf-8?B?QWJWdEMvaXlUTmFETjRtblpGU2UyeWFmb2x2NTZLMVR5WEpJZjFReERiZmd0?=
 =?utf-8?B?d3dxOTIwcVhuM0pxaUpVaUtFMGpBc3NSenJoTVZtbUNILzZqdjNiSEhCYk5O?=
 =?utf-8?B?anZOMVdGejV1NzBjVWVHVEhoQ0lyVEI3MS9SdDBGQ3VLTXlRZjhMbjlBUHZv?=
 =?utf-8?B?Q1JWV3B2azVtYW5aSmJFcGNJRlZhR2o4bHdVcWhmUGtXK2pLaW53ei9Eck00?=
 =?utf-8?B?TWE4Qnk4bStvUUtxTjE1NUtlVVlMeXk2aU9ETmhBUk41NGN6bHlVSTFqWWFC?=
 =?utf-8?B?NzRIVVpmLzh5bGtJTW11dkk0c3E3V2RnVUFYYU52cTZXNVhxMDNXcDhYaDln?=
 =?utf-8?B?Zm45c2dUcjg2RVBiNER0STJ2TnpKdm85YWROSGpIZHFWRGRiQ2NoaitwWTFT?=
 =?utf-8?B?R3VvaU1WWHdrSVhOQndadVZITUdFYmlDK1J4bWlFY1ZHMWVYTWk5WVVIZVlX?=
 =?utf-8?B?UDU3UGwzdnBqL3Q4Q2NHMjdqc01GWVovRzV3amN4THFWNXNkVlJzT1FWejBV?=
 =?utf-8?B?Ti9CUlJrVXN3cmZ5VitzTzJsSGgwTUU5Q3V1U1FOdFBMZFNiNmYzcHRabWc2?=
 =?utf-8?B?Z3F3cUk4TWxyMkhVd2l5MzViYlVLMnhZNW9SVDh3ZzBkY0E2VElJaGVKSk8v?=
 =?utf-8?B?SUZ5ZXhBNUFkUFVpaXQ5VTdxS3pHdGVOZU5oY0o4Z1I1UUxUTDdkQ013RjZG?=
 =?utf-8?B?UTdOMTFhVStDcnRqZzdXL2ZTNkVJaWlRaGtUS0lpSUM0blU1RmNQa29hNnVO?=
 =?utf-8?B?UFRvUUhhYkNiNTlHcFdYRlMyN1JmN3dDNGxBMWxxOG8rYzRnSVhBSm1qM01R?=
 =?utf-8?B?djU1REpzbVRGRXhFR2VlY3lCc3ZnU1FxSVdhN203bEdYQllmZGlDYjhBY0Vn?=
 =?utf-8?B?c3ZOc1FiTGxHTHFLb3B0ZDdUMEI0eWlNSjIwVnB3c25mV1JOZGFXdk43djhr?=
 =?utf-8?B?cXRIanQyT1F3eWF5ZmFIU256SGM2ZGhNbEJLT1pVSTc5Z1RxeW8xS05KWHJn?=
 =?utf-8?B?TXhzK2RzNERHOHU2Kzh2MHZqQkNNMUQzYXpnc2VVV3FZTmdUaEZOZ29JcThL?=
 =?utf-8?B?RmFjQmFramJLVjVIaFZpUWV1dmcxR2RMVFliNzFJT0dqMVYvTHprUTlpVUdM?=
 =?utf-8?B?V0paaUl1L3ZWekZ6TlEyOVF3ZlN0eUF2K1ZWT1hscFJ4SmppMW0wSGJGeVAw?=
 =?utf-8?B?eUJnbTVDTTc5WGNtRThmWHNMUXB2bk0wRy9RODFOSGEwQXdBcU9xK09ud1Qx?=
 =?utf-8?B?RHlGYld6OWtqS1BlSXdxY1B0dTBiZXhhZlJmalVCemRhVlZ3S1R0VTFMMHRu?=
 =?utf-8?B?WFVvTnNjaDVoTU1JZnlMVSswaEpnSjNaR3FyZ2FoazcxNG05OHZCRHlFRzBT?=
 =?utf-8?B?eWVnckVVT1lBYy9MZythZ2ZTS1VHdXNzS1NYaTE2RlZIcTB6L3daTURBUHJZ?=
 =?utf-8?B?OGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4db264a8-99f4-425c-3ba5-08dc2761f2d2
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 22:21:22.0156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V4THCvqBmj97GnmEtQCabtD3kIOoHcL90pSaI3z0fAvUsiztBfrBlMRDPGBHYwyERp5Hi9zGXKMU5RE/rI6/7VMHva9AP8SKP/Y3dnG+mKk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7925
X-OriginatorOrg: intel.com

Hi Alex,

On 2/6/2024 2:03 PM, Alex Williamson wrote:
> On Tue, 6 Feb 2024 13:45:22 -0800
> Reinette Chatre <reinette.chatre@intel.com> wrote:
>> On 2/5/2024 2:35 PM, Alex Williamson wrote:
>>> On Thu,  1 Feb 2024 20:57:01 -0800
>>> Reinette Chatre <reinette.chatre@intel.com> wrote:  
>>
>> ..
>>
>>>> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
>>>> index 31f73c70fcd2..7ca2b983b66e 100644
>>>> --- a/drivers/vfio/pci/vfio_pci_intrs.c
>>>> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
>>>> @@ -427,7 +427,7 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_core_device *vdev,
>>>>  
>>>>  	ctx = vfio_irq_ctx_get(vdev, vector);
>>>>  
>>>> -	if (ctx) {
>>>> +	if (ctx && ctx->trigger) {
>>>>  		irq_bypass_unregister_producer(&ctx->producer);
>>>>  		irq = pci_irq_vector(pdev, vector);
>>>>  		cmd = vfio_pci_memory_lock_and_enable(vdev);
>>>> @@ -435,8 +435,9 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_core_device *vdev,
>>>>  		vfio_pci_memory_unlock_and_restore(vdev, cmd);
>>>>  		/* Interrupt stays allocated, will be freed at MSI-X disable. */
>>>>  		kfree(ctx->name);
>>>> +		ctx->name = NULL;  
>>>
>>> Setting ctx->name = NULL is not strictly necessary and does not match
>>> the INTx code that we're claiming to try to emulate.  ctx->name is only
>>> tested immediately after allocation below, otherwise it can be inferred
>>> from ctx->trigger.  Thanks,  
>>
>> This all matches my understanding. I added ctx->name = NULL after every kfree(ctx->name)
>> (see below for confirmation of other instance). You are correct that the flow
>> infers validity of ctx->name from ctx->trigger. My motivation for
>> adding ctx->name = NULL is that, since the interrupt context persists, this
>> change ensures that there will be no pointer that points to freed memory. I
>> am not comfortable leaving pointers to freed memory around.
> 
> Fair enough.  Maybe note the change in the commit log.  Thanks,
> 

Will do. Thank you.

Reinette