Received-SPF: pass (google.com: domain of linux-kernel+bounces-55709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <65bedd1f-2dd4-49e3-8865-0e6082129e78@samsung.com>
Date: Wed, 7 Feb 2024 00:05:03 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: next: /dev/root: Can't open blockdev
Content-Language: en-US
To: Christian Brauner <brauner@kernel.org>, Naresh Kamboju
	<naresh.kamboju@linaro.org>
Cc: Jan Kara <jack@suse.cz>, linux-block <linux-block@vger.kernel.org>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>, open list
	<linux-kernel@vger.kernel.org>, Linux Regressions
	<regressions@lists.linux.dev>, linux-fsdevel@vger.kernel.org,
	lkft-triage@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>, Dan Carpenter
	<dan.carpenter@linaro.org>, Al Viro <viro@zeniv.linux.org.uk>, Anders Roxell
	<anders.roxell@linaro.org>
From: Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <20240206-haarpracht-teehaus-8c3d56b411ea@brauner>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CA+G9fYttTwsbFuVq10igbSvP5xC6bf_XijM=mpUqrJV=uvUirQ@mail.gmail.com>
	<20240206101529.orwe3ofwwcaghqvz@quack3>
	<CA+G9fYup=QzTAhV2Bh_p8tujUGYNzGYKBHXkcW7jhhG6QFUo_g@mail.gmail.com>
	<20240206122857.svm2ptz2hsvk4sco@quack3>
	<CA+G9fYvKfeRHfY3d_Df+9V+4tE_ZcvMGVJ-acewmgfjxb1qtpg@mail.gmail.com>
	<20240206-ahnen-abnahmen-73999e173927@brauner>
	<20240206-haarpracht-teehaus-8c3d56b411ea@brauner>
	<CGME20240206230505eucas1p1b952da8c57de5dea32339b22e3c98b94@eucas1p1.samsung.com>

Hi Christian,

On 06.02.2024 16:53, Christian Brauner wrote:
>> On it.
> Ok, can you try:
> git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.super.debug
> please?


I've also encountered this issue during my linux-next daily tests and I 
confirm that the above branch works fine.


I've applied the diff between e3bfad989976^2 and the above branch 
(bc7cb6c829e2), which looks following:

diff --git a/init/do_mounts.c b/init/do_mounts.c
index 279ad28bf4fb..d8ea839463a5 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -19,6 +19,7 @@
  #include <linux/ramfs.h>
  #include <linux/shmem_fs.h>
  #include <linux/ktime.h>
+#include <linux/task_work.h>

  #include <linux/nfs_fs.h>
  #include <linux/nfs_fs_sb.h>
@@ -208,6 +209,10 @@ void __init mount_root_generic(char *name, char 
*pretty_name, int flags)
                                 goto out;
                         case -EACCES:
                         case -EINVAL:
+#ifdef CONFIG_BLOCK
+                               flush_delayed_fput();
+                               task_work_run();
+#endif
                                 continue;
                 }
                 /*


onto next-20240206 and it fixed all boot problems I've observed on my 
test farm. :)

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland