Received-SPF: pass (google.com: domain of linux-kernel+bounces-55746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240206235902.2917395-1-irogers@google.com>
In-Reply-To: <20240206235902.2917395-1-irogers@google.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 6 Feb 2024 16:01:26 -0800
Message-ID: <CAM9d7cjD4KQaC2LyDhRMfPP8ccbxba_pRHEmVn90S6Nok+U3ug@mail.gmail.com>
Subject: Re: [PATCH v1] perf kvm powerpc: Fix build
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>, 
	Leo Yan <leo.yan@linaro.org>, James Clark <james.clark@arm.com>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	sfr@canb.auug.org.au
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 6, 2024 at 3:59=E2=80=AFPM Ian Rogers <irogers@google.com> wrot=
e:
>
> Updates to struct parse_events_error needed to be carried through to
> PowerPC specific event parsing.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: fd7b8e8fb20f ("perf parse-events: Print all errors")
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Namhyung <namhyung@kernel.org>

Thanks for the quick fix!
Namhyung


> ---
>  tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/po=
werpc/util/kvm-stat.c
> index d9a0ac1cdf30..c8357b571ccf 100644
> --- a/tools/perf/arch/powerpc/util/kvm-stat.c
> +++ b/tools/perf/arch/powerpc/util/kvm-stat.c
> @@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, s=
truct evlist *evlist)
>
>         parse_events_error__init(&err);
>         ret =3D parse_events(evlist, str, &err);
> -       if (err.str)
> +       if (ret)
>                 parse_events_error__print(&err, "tracepoint");
>         parse_events_error__exit(&err);
>         return ret;
> --
> 2.43.0.594.gd9cf4e227d-goog
>