Received-SPF: pass (google.com: domain of linux-kernel+bounces-55832-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 6 Feb 2024 18:02:18 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>, "Xing, Cedric"
	<cedric.xing@intel.com>, Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>, Dan Middleton
	<dan.middleton@linux.intel.com>, Samuel Ortiz <sameo@rivosinc.com>, "Dan
 Williams" <dan.j.williams@intel.com>
CC: Qinkun Bao <qinkun@google.com>, "Yao, Jiewen" <jiewen.yao@intel.com>,
	Dionna Amalie Glaze <dionnaglaze@google.com>, <biao.lu@intel.com>,
	<linux-coco@lists.linux.dev>, <linux-integrity@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 0/4] tsm: Runtime measurement registers ABI
Message-ID: <65c2e4aa54a0_d4122947f@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240128212532.2754325-1-sameo@rivosinc.com>
 <c17a31e4fb30f5f9d4a337e5bd8d54cc6f99eef7.camel@HansenPartnership.com>
 <a255bc36-2438-41b7-b304-bcf7a6628bef@linux.intel.com>
 <42e14f74d3819c95fdb97cd2e9b2829dcb1b1563.camel@HansenPartnership.com>
 <1557f98a-3d52-4a02-992b-4401c7c85dd7@linux.intel.com>
 <85b7a4a679eada1d17b311bf004c2d9e18ab5cd3.camel@HansenPartnership.com>
 <b8140cc8-a56b-40f6-a593-7be49db14c77@intel.com>
 <fe1722c3618a8216cb53b8fd3f1b7cbb6fdff5a0.camel@HansenPartnership.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <fe1722c3618a8216cb53b8fd3f1b7cbb6fdff5a0.camel@HansenPartnership.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o5mPQavRjapFuBk5hBb8IbOA9k6FmTWXbOD5O8X0VgZhhgcWT22CnbfMtbhN?=
 =?us-ascii?Q?zzxW+pPP/VL/KS1APZfzmkhehgUfo+iyqzAJpLbyXNsU8w/HCFSA83QNP4cb?=
 =?us-ascii?Q?p5XSPasjtKo9AwaYy1m4ap+AuDScu8/y5XJqol2KrVKD/EwK0f4rzB5MNA2P?=
 =?us-ascii?Q?fVekoaHOExw4rXQttujsl7hzLdH0dZoRWE1OPqtLw9GkWM+xk+yNkCcqlIqc?=
 =?us-ascii?Q?wuE+Yf0UtiA5KFfNeBYTxvK2peF15YPh+UjtNxZoZ3CmuTMd28zSTMUy1otR?=
 =?us-ascii?Q?+Ah3sb/9T4euk6hogMiSkjnWHk3fiJkF9IR2PklkNC12g2shHNqkzj0BYlB4?=
 =?us-ascii?Q?ML8z2V2vMVIi02kwnXeHX4YtyFgFwbncQfvasrgHGjkTov3VWH5vuxf5ksbw?=
 =?us-ascii?Q?GBuMKlGsZ01qm90hvc4Ofs1zd3kRRtfO5feGS2ITMQSZCQ883Q0wCxu8SLY/?=
 =?us-ascii?Q?nlnnR4TOvrv0EvJN8uhFq20Yq8ugnp7Ndz/slm+KBb/EdvQGv2JI9NxIvBRY?=
 =?us-ascii?Q?pD2etrRsChxy6va4/XxSGvUtkxt73WT4Ijc3qWQTKwX8ETec1OJwWr82B4iN?=
 =?us-ascii?Q?ZUIJ1MwCTmvVJCS3yKakLLpnGR8OodCC1UIAMqQy4RdJccZI/kHa6dQCGLRi?=
 =?us-ascii?Q?HKNVhGt5mdH2pW9agMB25uX8QQJprpKTASL0bfs8AJ69nVLeYfr37pPRctGt?=
 =?us-ascii?Q?SoygUhFumlfHuY/kgBNy487/6Dy82TxM6l+xWkymWF2jwKwO2VFF0xSNZo1j?=
 =?us-ascii?Q?8aWw8fzpsVL8gDwxRco52Ty8RAYoJcu1kd/e5OAKwuqJam+SEJ8r7Ki43DZs?=
 =?us-ascii?Q?9/uIqDBfVFm7zcsBk2/DdGtWHkHskk0Q6qvb/hx0qmJvOILh0zcTN0FPCtDr?=
 =?us-ascii?Q?OfAXO6AB48zLDyO5D/5OAIiX/88dCgdRvNDawjVpn9fJACnU8tKZ3CyILAk6?=
 =?us-ascii?Q?/EjvrqUcq43jeW3s8I4N732Zpf5qDJ6cn7GbamcwQvMUZD46tNM+sljHP/oM?=
 =?us-ascii?Q?sl7OICLPHMBjwPVADRDxwn0WP9Q2CYTcWHN2jOC11CiICnQmcBIRtEbyYaV1?=
 =?us-ascii?Q?3cjnlK/KFg+IdigkBUqN/sZmxwZhdtz+o0k1nXCT8RYZlqiwhjEjNaxpig0p?=
 =?us-ascii?Q?kmYWR+cDHOc5dtoQ3lKTGxr+IccZ/Bm3kEBv/m5Gu6hmAlncVfrh71i/K4Sd?=
 =?us-ascii?Q?eNAuLeUmEzo0J1XaJQl870m4/KFYpfNA1lFvHwcaFf7Yf79VUpaYQIVwbG3R?=
 =?us-ascii?Q?SjzYqGSP74hayUF30G6o4Q1mzPAugRp84iIdgOiTUCRVpaHilyKGDD5zM84G?=
 =?us-ascii?Q?Wx21p8b2KM9ET+XgpYHEycqj56BWCY6anf5cAm+/1lP8bf0hSxWUq+JLa5PG?=
 =?us-ascii?Q?zRgC1F1JniSdgMo51zxkQ7eL3Hegk6XEEK/VzV5L5YR/j8yHMC/OozheDufI?=
 =?us-ascii?Q?nmLkDEaFozwXZRI2ti5JPG3x3BwV0iR5Xx0Lacl0Js0Z/y/7znAPYtKhJGWE?=
 =?us-ascii?Q?TEon0isNcFkYiU7qG+p3FFidJ8kssWZl5SwpZix7KIOlPTI0/7y3S5yhuzn7?=
 =?us-ascii?Q?r3r5lixA38OKikqkXlKCafLqDJL3UB+UkVp4YvunzImXGxBahpAYy4GOvs1x?=
 =?us-ascii?Q?+A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a789fb7-430e-433c-6dbe-08dc2780d1b7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 02:02:20.9845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AbIQK4ng1Uv6eTLK9tb9Vx4PsmtAgR6QhfjLxUE7h1EWxd646ZdPbeXxIXpP17xkrj5kc/3VGJxAhYoYBto4S3b4Op6nm9IozmoCNiDnOVI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6463
X-OriginatorOrg: intel.com

James Bottomley wrote:
> There isn't really anything more complex about an interface that takes
> a log entry, and does the record an extend, than an interface which
> takes a PCR extension value.  So best practice would say that you
> should create the ABI that you can't get wrong (log and record) rather
> than creating one that causes additional problems for userspace.

Agree, there's no need for the kernel to leave deliberately pointy edges
for userspace to trip over.

Cedric, almost every time we, kernel community, build an interface where
userspace says "trust us, we know what we are doing" it inevitably
results later in "whoops, turns out it would have helped if the kernel
enforced structure here". So the log ABI adds that structure for the
primary use cases.