Received-SPF: pass (google.com: domain of linux-kernel+bounces-55883-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 7 Feb 2024 11:09:36 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: "Pillai, Aurabindo" <Aurabindo.Pillai@amd.com>
CC: "Zhuo, Lillian" <Qingqing.Zhuo@amd.com>, Alexander Lobakin
	<aleksander.lobakin@intel.com>, kernel test robot <lkp@intel.com>,
	"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Deucher,
 Alexander" <Alexander.Deucher@amd.com>, "Siqueira, Rodrigo"
	<Rodrigo.Siqueira@amd.com>, "Li, Roman" <Roman.Li@amd.com>
Subject: Re:
 drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6193:12:
 warning: stack frame size (3368) exceeds limit (2048) in
 'dml_core_mode_support'
Message-ID: <ZcL0cH1LZteapnTG@yujie-X299>
References: <202311200955.pmjdQEM1-lkp@intel.com>
 <a856cbeb-dd2e-436b-a7f2-74d3493df18e@intel.com>
 <PH7PR12MB583196EB28781C92A00970C1FB462@PH7PR12MB5831.namprd12.prod.outlook.com>
 <CH0PR12MB52845186C7D747A4547DA99A8B462@CH0PR12MB5284.namprd12.prod.outlook.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CH0PR12MB52845186C7D747A4547DA99A8B462@CH0PR12MB5284.namprd12.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CEFYB6oCYlOy/QXi1EzMBchhHttW8r7lMHkyRznqBvwj8xDaMs41r0ie20DB?=
 =?us-ascii?Q?X7JA9Hqy2nTv/dPyOTH+o0MegUhPelBwbdZ41TOny+ungpXxa7Pi7RiVoH3s?=
 =?us-ascii?Q?XFEfW6SQnmCMSZt7u0a1FH23dCJUfHSsw83MU8zAWG/2SPck0o44E+WILlqA?=
 =?us-ascii?Q?+NbQEYjUiGKSLSTX3H+WowF3yEgFU0Lxot0Z3SAyAKDhp9mKuyqci5QQ9n73?=
 =?us-ascii?Q?6BX0+UJy2vU+xvLPZsP6EBDu5MXFmzfKulJ3eqjMSKHRnQ2s9aN7q4ObWqe4?=
 =?us-ascii?Q?g17MXc99qGIfbhmF6kGx0F8uDBkE+X3g1Zc7uDfOXkNQjEiwN+GQDraFvaBX?=
 =?us-ascii?Q?NvM2UqsDNdpcVyqnl1FT5o1eZu49ofhpcjLJ19jir1Jmlx6lkw3bot1LGpDa?=
 =?us-ascii?Q?DGlENlUBkKob6MCh8dYmAL3s614GUisJGIkisRbBAt6QPnh4dmrmIzauYzzC?=
 =?us-ascii?Q?3du1yrfi5BWlDeFLJmy0lhEr5ZdPFT0cdbkjDt2Rjm1naazPd7MZAKsUND/a?=
 =?us-ascii?Q?6V/RkC7tiMCuIlcQbtRTp+pn0Xvnd+xfkD5joK/v1bEATGBcUleOVeIEtuuV?=
 =?us-ascii?Q?XMrD11tiog+hUWcTy6NPEQvHLEHENT1ZDbKaB2g3mn4bmFqZAl/9sfJ27W6M?=
 =?us-ascii?Q?I4qOmTDlaV/8Cw1U7EPr/t1YDy3fj1ST4zZqyhaQo1pWKDsVupUqK0z6qedf?=
 =?us-ascii?Q?7+w771dAcLus6xijVwIT6YDmm7LnMjlzH/PWLww2YKGZhtUjQdhJyRrQRsRy?=
 =?us-ascii?Q?cCFu/F5QSIIbTlWq0Npmh1zI71BMqobdBJjS3xpy86IAoIg4dQtwRaNMpJgd?=
 =?us-ascii?Q?KEp+m8E1lkW+GEshB30oLIrKsvXI4YvSrXl4RHyhouuwuwqVlOPPSSEbfW94?=
 =?us-ascii?Q?H4iBFlH20OegyUMcjv2UDTZ805MHuerlN1nmOdO6wUAzpZ5gZa4mzRwpGrao?=
 =?us-ascii?Q?d5gbZEc0c+4cM6qyFZqGmBjCIIr/Bjy6WuRXJMb50TUWoJQJm+O50iyP7H1S?=
 =?us-ascii?Q?6MGTbKREX/bB3/G0UYbHATzH4vQkrIZWwVaMVme1s6BU0FeZZDu8JDO4qugt?=
 =?us-ascii?Q?q2bWQZKbF1gEYmAkh/wfhmrbFWG/6m4RM8mLMszSXMTu8+3sxxxP/ZeCkFRl?=
 =?us-ascii?Q?+UyzIWBya650rPdPGNtWeebMTTAHtCtGkEQEE9kUlOR6av6sG7B1qe3QUlEw?=
 =?us-ascii?Q?KK9L+jXsziYXDGY6crfrMhKv3v7gR9Ql1c7lFIfWGh80Sh1kyvqebpfP2Lvv?=
 =?us-ascii?Q?XuoYukASQ7tByWnudCntTP5MTOha+QQfO3NZ3USfANFKBnftFZKh1d7q/ktY?=
 =?us-ascii?Q?ccZQtZdiKA5prtIkz3Bb27qZJmiCx3z2zh9UQHcnfdT13StkgPXnFzzstyOC?=
 =?us-ascii?Q?yGVyEzxE1jLvqJtn+7tqXjiAtlbYSFrbKeD2JdbDaf+KEEHHyNyPa3b0K1oa?=
 =?us-ascii?Q?b3D5rvZyaphURsp74EvTKMuKxCVPJWkC1Khxtg0C8iC2aaib6Ciz6Jfw9Hqk?=
 =?us-ascii?Q?J59CqWGRVfA3rXkfvpJTELV14TTpFEmboYuY7FsI6Gwg3m5m+WT92NLmaSos?=
 =?us-ascii?Q?3hrkzkqtWsXR5WD7hZmIEecR6kQjvvrNM3RXZicT?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ebe6f4-394e-4b61-84dc-08dc278b3201
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 03:16:37.5933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TGUgTFP51pLLgxGgrS/873CX5ynfLf2vDsAAOLHbiuBasTowfOcFOhOpmLg4d0eulfnc4cAGkYj+gJFJ6hTkOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5604
X-OriginatorOrg: intel.com

On Tue, Feb 06, 2024 at 04:18:55PM +0000, Pillai, Aurabindo wrote:
> [AMD Official Use Only - General]
> 
> Hi,
> 
> I tried with LLVM16 (from Manjaro) and couldnt repro the issue on both mainline and amd-staging-drm-next. Could someone share the config used for this build ?

Hi,

There is a "reproduce" link in the original report. Hope it would be
helpful:

reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM1-lkp@intel.com/reproduce)

For a quick check, please kindly try the following steps to reproduce
the issue:

$ git checkout v6.8-rc3
$ wget https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM1-lkp@intel.com/config -O .config
$ make W=1 LLVM=1 ARCH=x86_64 olddefconfig
$ make -j$(nproc) W=1 LLVM=1 ARCH=x86_64 drivers/gpu/drm/amd/amdgpu/
..
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6710:12: warning: stack frame size (3368) exceeds limit (3072) in 'dml_core_mode_support' [-Wframe-larger-than]
dml_bool_t dml_core_mode_support(struct display_mode_lib_st *mode_lib)
           ^

Best Regards,
Yujie

> 
> --
> 
> Regards,
> Jay
> ________________________________
> From: Zhuo, Lillian <Qingqing.Zhuo@amd.com>
> Sent: Tuesday, February 6, 2024 11:06 AM
> To: Alexander Lobakin <aleksander.lobakin@intel.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> Cc: kernel test robot <lkp@intel.com>; oe-kbuild-all@lists.linux.dev <oe-kbuild-all@lists.linux.dev>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Li, Roman <Roman.Li@amd.com>
> Subject: RE: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6193:12: warning: stack frame size (3368) exceeds limit (2048) in 'dml_core_mode_support'
> 
> [AMD Official Use Only - General]
> 
> + Jay, who is looking into the issue
> 
> -----Original Message-----
> From: Alexander Lobakin <aleksander.lobakin@intel.com>
> Sent: Tuesday, February 6, 2024 8:20 AM
> To: Zhuo, Lillian <Qingqing.Zhuo@amd.com>
> Cc: kernel test robot <lkp@intel.com>; oe-kbuild-all@lists.linux.dev; linux-kernel@vger.kernel.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Li, Roman <Roman.Li@amd.com>
> Subject: Re: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6193:12: warning: stack frame size (3368) exceeds limit (2048) in 'dml_core_mode_support'
> 
> From: Kernel Test Robot <lkp@intel.com>
> Date: Mon, 20 Nov 2023 10:01:21 +0800
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   037266a5f7239ead1530266f7d7af153d2a867fa
> > commit: 7966f319c66d9468623c6a6a017ecbc0dd79be75 drm/amd/display: Introduce DML2
> > date:   6 weeks ago
> > config: x86_64-randconfig-121-20231119
> > (https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM
> > 1-lkp@intel.com/config)
> > compiler: clang version 16.0.4
> > (https://github.com/llvm/llvm-project.git
> > ae42196bc493ffe877a7e3dff8be32035dea4d07)
> > reproduce (this is a W=1 build):
> > (https://download.01.org/0day-ci/archive/20231120/202311200955.pmjdQEM
> > 1-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new
> > version of the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes:
> > | https://lore.kernel.org/oe-kbuild-all/202311200955.pmjdQEM1-lkp@inte
> > | l.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> >    warning: unknown warning option '-Wstringop-truncation'; did you mean '-Wstring-concatenation'? [-Wunknown-warning-option]
> >    warning: unknown warning option '-Wpacked-not-aligned'; did you
> > mean '-Wpacked-non-pod'? [-Wunknown-warning-option]
> >>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:61
> >>> 93:12: warning: stack frame size (3368) exceeds limit (2048) in
> >>> 'dml_core_mode_support' [-Wframe-larger-than]
> >    dml_bool_t dml_core_mode_support(struct display_mode_lib_st
> > *mode_lib)
> 
> Ping? This still happens on the latest RC and linux-next on LLVM 19 at least (-O2) and breaks CONFIG_WERROR builds.
> 
> >               ^
> >    2183/3368 (64.82%) spills, 1185/3368 (35.18%) variables
> >    drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8241:6: warning: stack frame size (2232) exceeds limit (2048) in 'dml_core_mode_programming' [-Wframe-larger-than]
> >    void dml_core_mode_programming(struct display_mode_lib_st *mode_lib, const struct dml_clk_cfg_st *clk_cfg)
> >         ^
> >    1441/2232 (64.56%) spills, 791/2232 (35.44%) variables
> >    4 warnings generated.
> Thanks,
> Olek