Received-SPF: pass (google.com: domain of linux-kernel+bounces-55922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240112231340.779469-1-namhyung@kernel.org>
In-Reply-To: <20240112231340.779469-1-namhyung@kernel.org>
From: Ian Rogers <irogers@google.com>
Date: Tue, 6 Feb 2024 20:13:32 -0800
Message-ID: <CAP-5=fWCQqzPMV=3+o5W6fWx2vy2h0gMicU+ysnTqCy6iiLbaA@mail.gmail.com>
Subject: Re: [PATCH] perf record: Display data size on pipe mode
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>, 
	linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 3:13=E2=80=AFPM Namhyung Kim <namhyung@kernel.org> =
wrote:
>
> Currently pipe mode doesn't set the file size and it results in a
> misleading message of 0 data size at the end.  Although it might miss
> some accounting for pipe header or more, just displaying the data size
> would reduce the possible confusion.
>
> Before:
>   $ perf record -o- perf test -w noploop | perf report -i- -q --percent-l=
imit=3D1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.000 MB - ]    <=3D=3D=3D=3D=3D=3D  =
(here)
>       99.58%  perf     perf                  [.] noploop
>
> After:
>   $ perf record -o- perf test -w noploop | perf report -i- -q --percent-l=
imit=3D1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.229 MB - ]
>       99.46%  perf     perf                  [.] noploop
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-record.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 91e6828c38cc..21ebcb04f1d8 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -1773,8 +1773,11 @@ record__finish_output(struct record *rec)
>         struct perf_data *data =3D &rec->data;
>         int fd =3D perf_data__fd(data);
>
> -       if (data->is_pipe)
> +       if (data->is_pipe) {
> +               /* Just to display approx. size */
> +               data->file.size =3D rec->bytes_written;
>                 return;
> +       }
>
>         rec->session->header.data_size +=3D rec->bytes_written;
>         data->file.size =3D lseek(perf_data__fd(data), 0, SEEK_CUR);
> --
> 2.43.0.275.g3460e3d667-goog
>