Received-SPF: pass (google.com: domain of linux-kernel+bounces-55924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ef44e0d9-a4a5-4fbd-9db9-7644ede2e30d@amd.com>
Date: Wed, 7 Feb 2024 09:46:24 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: next: /dev/root: Can't open blockdev
To: Marek Szyprowski <m.szyprowski@samsung.com>,
 Christian Brauner <brauner@kernel.org>,
 Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Jan Kara <jack@suse.cz>, linux-block <linux-block@vger.kernel.org>,
 Linux-Next Mailing List <linux-next@vger.kernel.org>,
 open list <linux-kernel@vger.kernel.org>,
 Linux Regressions <regressions@lists.linux.dev>,
 linux-fsdevel@vger.kernel.org, lkft-triage@lists.linaro.org,
 Arnd Bergmann <arnd@arndb.de>, Dan Carpenter <dan.carpenter@linaro.org>,
 Al Viro <viro@zeniv.linux.org.uk>, Anders Roxell <anders.roxell@linaro.org>
References: <CA+G9fYttTwsbFuVq10igbSvP5xC6bf_XijM=mpUqrJV=uvUirQ@mail.gmail.com>
 <20240206101529.orwe3ofwwcaghqvz@quack3>
 <CA+G9fYup=QzTAhV2Bh_p8tujUGYNzGYKBHXkcW7jhhG6QFUo_g@mail.gmail.com>
 <20240206122857.svm2ptz2hsvk4sco@quack3>
 <CA+G9fYvKfeRHfY3d_Df+9V+4tE_ZcvMGVJ-acewmgfjxb1qtpg@mail.gmail.com>
 <20240206-ahnen-abnahmen-73999e173927@brauner>
 <20240206-haarpracht-teehaus-8c3d56b411ea@brauner>
 <CGME20240206230505eucas1p1b952da8c57de5dea32339b22e3c98b94@eucas1p1.samsung.com>
 <65bedd1f-2dd4-49e3-8865-0e6082129e78@samsung.com>
Content-Language: en-US
From: "Aithal, Srikanth" <sraithal@amd.com>
In-Reply-To: <65bedd1f-2dd4-49e3-8865-0e6082129e78@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?enZ1OUdBb25CcGM5VnlaeDdGckR3UFk2OXUyc1pHQ0RqdkZ4dUVVcFNNeEUr?=
 =?utf-8?B?UmhoeFJuUFBnL0NCeWhLNlZRRExHRllYYVlvKzNVUktPNGxxK3pVMUZveHlt?=
 =?utf-8?B?aFkwYzRzQXVlRGUzQVN3WGFiM1ZmVjFPajR5TEJWYWFOVml4cGs3MXJPaDV2?=
 =?utf-8?B?dDhWcU9lNHZKQy8yOGtFTTFiS3dJMGVhd2VGY1kzZElaN3pnWWNXT09zNDZE?=
 =?utf-8?B?Mnptdlp5aEd0R0NhRFdWcVk1VGZSN09aV0RJWk92ZGNxV3pUQ09UM3VrbTVs?=
 =?utf-8?B?VHRUSFNmVG5kL01lejNKNlZuN3Y3TW45WWN3S2ZQY3ZIT3hMbUt6NzBvYnBZ?=
 =?utf-8?B?RzgvQ1RPM0hQcURvUmFzTHhpQ2t2cWh2akV3QVRlNkRjRkI0Yzh4aVk3LzZx?=
 =?utf-8?B?a1VuK3ZKbEhxN0tTczY5OXZLcDJjNFZmZW5XeXNJTTU3Sm5pRUMyK1VDR29W?=
 =?utf-8?B?NlJCeVVyOEhuWlJOcmNlbjlnWTB5a0Fad3VaV3JrVFEzTFBzTlBzVTEzWkZz?=
 =?utf-8?B?RmYyT1RXdFhtUHEvYVU1RlpuZ3VMdW9RWXJBSFpOd1VoTlJHMGRRMEpZZmxl?=
 =?utf-8?B?VVFGOUJpTTA1bisrQlJNU1NKdFU5cXVya24rS2VlRnd2a3I5N2gxbE1ob3NZ?=
 =?utf-8?B?TVVtVmR4TWd3UWVUcnp6VEwxUitxeWtOM0FoT1ZvYVU2c0RGTjlTT2NGUGxT?=
 =?utf-8?B?L3NKVWxDZXZPaTVlRFRNbGRmMlhSeG9HdERVMWN2MVR2WUNxTW05eUd6Vytq?=
 =?utf-8?B?MXZpWlI0UDkxSDhqVFF4aEZXS1Z6TkJoTnE2ZUJZbTJ5aXVXTm5tdFJ5Uk1P?=
 =?utf-8?B?eENxamlVeUpsRGVscEU1QjNwWjhzWmJvcUVBVk5NN0ZQWExBaXB4QmpBTGY3?=
 =?utf-8?B?YmtEb1NtREkxN1ljb1JSYmlhQUZWelh0RGZGQU1IalQyaThwcFcyYjAvZWRJ?=
 =?utf-8?B?RkFjUnVxQU1GWjV2MzNxQlhuWXZTdWJJR0RUU0xzSk0zL0tzajhaZlVjbG8v?=
 =?utf-8?B?UWlablhHNzBGamNRd1NDMU5jblRUZnpMZTF1Rk16NE05MmdxYm5DSlh6VGVn?=
 =?utf-8?B?MHNKaGlPN3h0bTltTWFJaGcyV3lYY004RUJUQVNBekswclkwRTNkbGMvT056?=
 =?utf-8?B?NkhpOWhKT29vL1gxV1ZQeUlQQmNURDhlVWlCNEo5NW9MamtIMzNNLytYbkNj?=
 =?utf-8?B?MUdya1V0MUtRR1hEc2dWTi9JSmlWcHJSaWxZa3pNWlZHTTVCSExydWRsU1lC?=
 =?utf-8?B?aDlrbkxKSGlVS2Q0bUNhbGU1QWFHYXJQRzVPL2RlSUtnVG9ocCs2NDN4M2NZ?=
 =?utf-8?B?bHRZNERJOHFsQ2VvUTV2U1lHK3RGdEtYUUdjYWFOMVJzZGVyMWlRakFXTm8w?=
 =?utf-8?B?Zzd4Q3VYbDJQM3FUUmNNRkVrNC91MVhwbjVUb3hYR2pjWVh3NzFpb2cxWkt3?=
 =?utf-8?B?OGpEMWtYU2I0c2dUeUlKZ3RvVjN0LzlvdTBnU1RhYytCNWV1bERTaU5SWHIx?=
 =?utf-8?B?ODZueWRjWWo5cGR6M0gwaE90ZW1LNHVPendYejJCVlY1RWNaaElmVklic2kv?=
 =?utf-8?B?UnJzZjFwNVlBRTg5NjFjUTVLbnJzRXVaQ3ovU1Z1TTlneHA4aGNibENCa3Rk?=
 =?utf-8?B?dnVuYmlpYVdCTXZoajh4blprTVQyL3NESUFpbFhHU256ejF3ZVdNVmppK3BC?=
 =?utf-8?B?cjZMaFphdmpJYWg0NlZib2xjeHRISm14NFd5d1d5dTloVnNsSzhuZitYL2hY?=
 =?utf-8?B?SXplOEw2OXJGV1gwendnVjJKQ0FGcVllUHBXbENOY3YvNUxmNFJ0cUlJMzl2?=
 =?utf-8?B?djkwK25DTXNscWJJWHVKREJUL3cwQndlWllKUmJoTk9ZQnhUelcrNStmcHZB?=
 =?utf-8?B?czRiVmZwUHpUb2xQcmRUV3NmdzdKWkQvcUdKMjIzcm1OeVc5QkRKVHFLeXBP?=
 =?utf-8?B?R3c0SkxFY2puQ3dWQ0RUbG0zdDNkZFR0K2dNMDBJb2M0eFZrY2Y2aTR3Q1Q5?=
 =?utf-8?B?RkJ3VmtCcE5GU1g3NnJvbmxMcTFIc3M0RW96ZFhJbDArNUpRUkRkOU1GdEtv?=
 =?utf-8?B?bkFqOW1ORjBOTXlnSWxPRjBmbW5tTEFBM0ZteG5PRUdxVEJudXRJWVI2SEJv?=
 =?utf-8?Q?Po/ZSm6MLckP1pSZjahYcZoiV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87652176-ebeb-4084-f148-08dc27939148
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6460.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 04:16:33.4581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hQPn8XkW3c1q4Imipgeg4P/5QzCtv8NmqD+g5Zu91IqumwQdOCaow+P0R6DSMGCcT2A0QNShrsq0DUnThKCf+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7862

On 2/7/2024 4:35 AM, Marek Szyprowski wrote:
> Hi Christian,
> 
> On 06.02.2024 16:53, Christian Brauner wrote:
>>> On it.
>> Ok, can you try:
>> git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.super.debug
>> please?
> 
> 
> I've also encountered this issue during my linux-next daily tests and I
> confirm that the above branch works fine.
> 
> 
> I've applied the diff between e3bfad989976^2 and the above branch
> (bc7cb6c829e2), which looks following:
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index 279ad28bf4fb..d8ea839463a5 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -19,6 +19,7 @@
>    #include <linux/ramfs.h>
>    #include <linux/shmem_fs.h>
>    #include <linux/ktime.h>
> +#include <linux/task_work.h>
> 
>    #include <linux/nfs_fs.h>
>    #include <linux/nfs_fs_sb.h>
> @@ -208,6 +209,10 @@ void __init mount_root_generic(char *name, char
> *pretty_name, int flags)
>                                   goto out;
>                           case -EACCES:
>                           case -EINVAL:
> +#ifdef CONFIG_BLOCK
> +                               flush_delayed_fput();
> +                               task_work_run();
> +#endif
>                                   continue;
>                   }
>                   /*
> 
> 
> onto next-20240206 and it fixed all boot problems I've observed on my
> test farm. :)
> 
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> Best regards

We as well encountered this issue during our CI run. The given branch 
fixes the issues seen in our run.

Tested-by: Srikanth Aithal <sraithal@amd.com>