Received-SPF: pass (google.com: domain of linux-kernel+bounces-56051-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <cfa789a0-5433-4e17-957f-a3e021a97eed@nvidia.com>
Date: Wed, 7 Feb 2024 12:29:29 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V4] PCI/MSI: Fix MSI hwirq truncation
From: Vidya Sagar <vidyas@nvidia.com>
To: bhelgaas@google.com, rdunlap@infradead.org,
 ilpo.jarvinen@linux.intel.com, tglx@linutronix.de
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 treding@nvidia.com, jonathanh@nvidia.com, sdonthineni@nvidia.com,
 kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20240111052814.713016-1-vidyas@nvidia.com>
 <20240115135649.708536-1-vidyas@nvidia.com>
 <23c5fac1-ebf1-4e5d-9691-7b87060b0df3@nvidia.com>
 <0c9d7bab-1da7-4ac5-891a-62e28db8d60a@nvidia.com>
Content-Language: en-US
In-Reply-To: <0c9d7bab-1da7-4ac5-891a-62e28db8d60a@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZzFiUldJS05uN2NWWDU1K2d0M2NvNWtlOGxNeEl5Yy9ZNHpCTkM4aWRPbjhu?=
 =?utf-8?B?Zk1rckY5NkhoUi9vaW5MYUFneW1MWDFiS3pCdVNUbUZZcStNYmx4cTBlaVhn?=
 =?utf-8?B?VFVSYTJMWG5aZW5jR2JtUjhqVWFGRjc4eW40ZjFQV3V3d0ZVWEt0YlVNVVdC?=
 =?utf-8?B?Z1hxOG1QVTJzVk8yZi9ycTV1clRjbWtaOGUxYmFtZGJhT3hmRi85OUl3WDkx?=
 =?utf-8?B?RnZSWnBLVzF5SGdkci9nUXd2ZzV4UWh4UW0zcnV0QWdsajFkdmVzdE5odW9n?=
 =?utf-8?B?N2NjbUVyenVocC9Sd1pzRUI2RWpDM1c2QnRkSnZlNkRscFhIMVRMZ1JvdWo2?=
 =?utf-8?B?MURYOUxMNGdtTHBZc00wNFY0d1pHcmptU3pLWHZyczhOdlRJVGcyYlk5ZTd1?=
 =?utf-8?B?OUlGdktrZ1FJRk1lZXpRQmJCMEhHWEE4QnZGLytyeW9JVkhKQi9saHRIREJn?=
 =?utf-8?B?Y2pMVU9XTjMydTZhbys2RkUzbVF0SmtVZG5ZbnkzMVNZYzU3by9BTXdybWFl?=
 =?utf-8?B?c0tnM2cxSzdsaWZpT00yaVRWZ2hZWTJ6V2tjV29KVzZsbzgySEdjZTZaZ1lY?=
 =?utf-8?B?bklwazVBOHVEZWFBRVpTM0VPeklhODdrU0FkMGxiZERPWDNCUVdyYzVkeDNM?=
 =?utf-8?B?WXhRTkVkQkhsblo1YU1nMTNsQUdBTi9vR3Z4bjBvcWpsWEdqSG1xS1VseGRK?=
 =?utf-8?B?bXdxdHdDbkFjc0hpN3FWR3d2aU9KRFBTK2hlL1dYb2hNWmlOTVhoclY1Vkxx?=
 =?utf-8?B?eDc3MnkxWnpIZU54bXNLaXlISEpmK1hYQzJ2SWpJbStEejZ1bU1iKzFKWUt6?=
 =?utf-8?B?Y2N4MERjUkJZRFZ1Qm1FWWNuTHU1TkxKMlFXc1Y2RmFzMWs1bzZPTDdjQnUz?=
 =?utf-8?B?bG5HYjhycnBwUHR1azZDdWJqYjdzaTNaQ2hwZ3VscFF2VDNXbDBOU295YTNX?=
 =?utf-8?B?anl0Nk5DQ1dpbHdGcUlaekE1V3lDT2Ntc0JaMUZMbks4bW5HWUU3SFFDa3FR?=
 =?utf-8?B?eTgxeU9ZMmhIdUZZMFpVL1MzRkZERXdRQjArTWY0V3R3ek1CODc1aklRb0Jr?=
 =?utf-8?B?d0ljblpoSFBhWEJoRGNLbVVhM01IVFlLTFAxRmNaU2RnekdNVnV5RkdTUXor?=
 =?utf-8?B?eEhxTGZwMFFmZTJzdVl4QldTTkk2bnZZKytOZWJHalQzM2Vpd3l5dnhuQ29q?=
 =?utf-8?B?TjNnbDl2UStYNnBVSWtuMldFczNCREpnM3hzanlVLzFxaHRZZWFxblQ5L0xp?=
 =?utf-8?B?QmtMNHo0MHVnekRuU3ZFOXZzY0RLSWx0SHFmT0NCdHhhSWlBSk4rUlJVd1k1?=
 =?utf-8?B?Nm9kMG1nVmp0N1p6UmZ2MVlNRGMrVm9Ddzhici9TYldkOWU2WUZrTHpzSHZD?=
 =?utf-8?B?SGdwNEpMY3VPeForQUpNeFhnak9SSlcyY0ZnS1RhUEZ1Mnd5UzFzTGhOZXM0?=
 =?utf-8?B?THdaU21LU0F0WUNDMnc3bGRCUnc5UWRtYU84cWJ4emNSRDBFeU9hVVljaHll?=
 =?utf-8?B?eTJHMW1FRm5mSHlkL3NRQ01jYnJVdGdXdC95VzJ5SHJsTWFSVFlRMTRMdEMw?=
 =?utf-8?B?OXBnOE5GdGhoQ3hhZlBlaHErcDZQbVNHTGdZQ3NseDhuOWI5NUJRVHQ1c1o0?=
 =?utf-8?B?Wm5IVld6c09TTGVIRVJnb1FvUlFZc0xVcGRKZEMyNi9vN2RoZ0FWUFlIN3Z0?=
 =?utf-8?B?eXhvN3FPN1g5VzYyVmN6TEZjOHJrRm02ZnJxckxWSlI1dXA2ZTJVWk9acVB3?=
 =?utf-8?B?VGVXTzFaSXBhclZNdUVkM1MxZFFPbFAyb09KSXc2eVUrdzduSEVrWHl1WUNw?=
 =?utf-8?B?WEZNSkRRc0EyZnBLNGFrVDd1eHpZUTV0Y2lUaTUyTDJYdHBTeTVDM0YzRmN1?=
 =?utf-8?B?NDR6a3VaVkdiV3Bob2M3b0RoMDF1VDNtQVM4TjFBc253ZitQdUFmOGFxK3dP?=
 =?utf-8?B?Qll5TXBNVDBhK2JEektYZ2Z5VHBwejlvdTU3WU8zNXRDVWZUVjlwTlYxeElv?=
 =?utf-8?B?OWZqZ0JLenR1WWI2S1B6YWowWWcrdDVKdTRMTThPWVAyV1ZNYlExQTVsa3hw?=
 =?utf-8?B?STBOVXdmbjNYdUpJY095SXVJSW1tUnB0MzlxNDJnSlFEajBWRmxMVVYxRERa?=
 =?utf-8?Q?V4UklFCX3dH54r4AGIlRtohMk?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d73f55c6-efa1-4f85-20d4-08dc27aa5990
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 06:59:38.3694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VcVVbHv/bNTfjR/VvYbV7g8G7ohYW//0iYF2o9k7o5Ti0hdzo6Y5Q3Xf8O4DHo3/d4YfG55a9wQRjWIosR+qYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6278

Hi Thomas / Bjorn,
Can you please guide me on getting this patch merged?

Thanks,
Vidya Sagar

On 1/31/2024 8:45 AM, Vidya Sagar wrote:
> Hi Thomas,
> Sorry to bother you.
> Would you mind giving an Ack to this patch?
> 
> Thanks,
> Vidya Sagar
> 
> On 1/23/2024 9:31 PM, Vidya Sagar wrote:
>> Hi Thomas,
>> Does this patch look fine to you?
>> If yes, would you mind giving an Ack?
>>
>> Thanks,
>> Vidya Sagar
>>
>> On 1/15/2024 7:26 PM, Vidya Sagar wrote:
>>> While calculating the hwirq number for an MSI interrupt, the higher
>>> bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
>>> number gets truncated because of the shifted value casting to return
>>> type of pci_domain_nr() which is 'int'. This for example is resulting
>>> in same hwirq number for devices 0019:00:00.0 and 0039:00:00.0.
>>>
>>> So, cast the PCI domain number to 'irq_hw_number_t' before left shifting
>>> it to calculate hwirq number. Please note that this fixes the issue only
>>> on 64-bit systems and doesn't change the behavior in 32-bit systems i.e.
>>> the 32-bit systems continue to have the issue. Since the issue surfaces
>>> only if there are too many PCIe controllers in the system which usually
>>> is the case in modern server systems and they don't tend to run 32-bit
>>> kernels.
>>>
>>> Fixes: 3878eaefb89a ("PCI/MSI: Enhance core to support hierarchy 
>>> irqdomain")
>>> Tested-by: Shanker Donthineni <sdonthineni@nvidia.com>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>> V4:
>>> * Added extra information in the change log about the impact of this 
>>> patch
>>>    in a 32-bit system as suggested by Thomas
>>>
>>> V3:
>>> * Addressed review comments from Thomas Gleixner
>>> * Added Tested-By: Shanker Donthineni <sdonthineni@nvidia.com>
>>>
>>> V2:
>>> * Added Fixes tag
>>>
>>>   drivers/pci/msi/irqdomain.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
>>> index c8be056c248d..cfd84a899c82 100644
>>> --- a/drivers/pci/msi/irqdomain.c
>>> +++ b/drivers/pci/msi/irqdomain.c
>>> @@ -61,7 +61,7 @@ static irq_hw_number_t 
>>> pci_msi_domain_calc_hwirq(struct msi_desc *desc)
>>>       return (irq_hw_number_t)desc->msi_index |
>>>           pci_dev_id(dev) << 11 |
>>> -        (pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
>>> +        ((irq_hw_number_t)(pci_domain_nr(dev->bus) & 0xFFFFFFFF)) << 
>>> 27;
>>>   }
>>>   static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,