Received-SPF: pass (google.com: domain of linux-kernel+bounces-56053-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3675d5ba-2fd8-4513-b48d-ea9a0ac955b9@quicinc.com>
Date: Wed, 7 Feb 2024 12:30:32 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/5] clk: qcom: camcc-sm8650: Add camera clock controller
 driver for SM8650
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        Taniya Das <quic_tdas@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Imran Shaik <quic_imrashai@quicinc.com>,
        "Ajit Pandey" <quic_ajipan@quicinc.com>
References: <20240206113145.31096-1-quic_jkona@quicinc.com>
 <20240206113145.31096-5-quic_jkona@quicinc.com>
 <CAA8EJpp7p35UECE7QfE-At+=xpa253=De+ZZNnaPSO9GqXCnrg@mail.gmail.com>
Content-Language: en-US
From: Jagadeesh Kona <quic_jkona@quicinc.com>
In-Reply-To: <CAA8EJpp7p35UECE7QfE-At+=xpa253=De+ZZNnaPSO9GqXCnrg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/6/2024 5:38 PM, Dmitry Baryshkov wrote:
> On Tue, 6 Feb 2024 at 13:41, Jagadeesh Kona <quic_jkona@quicinc.com> wrote:
>>
>> Add support for the camera clock controller for camera clients to be
>> able to request for camcc clocks on SM8650 platform.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> ---
>>   drivers/clk/qcom/Kconfig        |    8 +
>>   drivers/clk/qcom/Makefile       |    1 +
>>   drivers/clk/qcom/camcc-sm8650.c | 3601 +++++++++++++++++++++++++++++++
>>   3 files changed, 3610 insertions(+)
>>   create mode 100644 drivers/clk/qcom/camcc-sm8650.c
> [
> [skipped]
> 
>> +static int __init cam_cc_sm8650_init(void)
>> +{
>> +       return platform_driver_register(&cam_cc_sm8650_driver);
>> +}
>> +subsys_initcall(cam_cc_sm8650_init);
> 
> We have been here for the patch series for camcc-sm8550. Upstream
> reviewers expect that you don't repeat the same mistakes over and over
> again.
> 
> Please use module_platform_driver().
> 

Sorry I missed this change, will update this in next series.

Thanks,
Jagadeesh

>> +
>> +static void __exit cam_cc_sm8650_exit(void)
>> +{
>> +       platform_driver_unregister(&cam_cc_sm8650_driver);
>> +}
>> +module_exit(cam_cc_sm8650_exit);
>> +
>> +MODULE_DESCRIPTION("QTI CAMCC SM8650 Driver");
>> +MODULE_LICENSE("GPL");
>> --
>> 2.43.0
>>
>>
> 
>