Received-SPF: pass (google.com: domain of linux-kernel+bounces-56064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
CC: <yangyicong@hisilicon.com>, <gregkh@linuxfoundation.org>,
	<jirislaby@kernel.org>, <tony@atomide.com>, <linux-kernel@vger.kernel.org>,
	<linux-serial@vger.kernel.org>, <john.ogness@linutronix.de>,
	<tglx@linutronix.de>, <linuxarm@huawei.com>, <prime.zeng@hisilicon.com>,
	<jonathan.cameron@huawei.com>, <fanghao11@huawei.com>
Subject: Re: [PATCH v2] serial: port: Don't suspend if the port is still busy
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
References: <20240206073322.5560-1-yangyicong@huawei.com>
 <ZcIvjC1qzD4atwlT@smile.fi.intel.com>
From: Yicong Yang <yangyicong@huawei.com>
Message-ID: <9e3d8daf-6715-bb37-125a-4141a9460417@huawei.com>
Date: Wed, 7 Feb 2024 15:22:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <ZcIvjC1qzD4atwlT@smile.fi.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi Andy,

On 2024/2/6 21:09, Andy Shevchenko wrote:
> On Tue, Feb 06, 2024 at 03:33:22PM +0800, Yicong Yang wrote:
>> From: Yicong Yang <yangyicong@hisilicon.com>
>>
>> We accidently met the issue that the bash prompt is not shown after the
>> previous command done and until the next input if there's only one CPU
>> (In our issue other CPUs are isolated by isolcpus=). Further analysis
>> shows it's because the port entering runtime suspend even if there's
>> still pending chars in the buffer and the pending chars will only be
>> processed in next device resuming. We are using amba-pl011 and the
>> problematic flow is like below:
>>
>> Bash                                         kworker
>> tty_write()
>>   file_tty_write()
>>     n_tty_write()
>>       uart_write()
>>         __uart_start()
>>           pm_runtime_get() // wakeup waker
>>             queue_work()
>>                                              pm_runtime_work()
>>                                                rpm_resume()
>>                                                 status = RPM_RESUMING
>>                                                 serial_port_runtime_resume()
>>                                                   port->ops->start_tx()
>>                                                     pl011_tx_chars()
>>                                                       uart_write_wakeup()
>>         […]
>>         __uart_start()
>>           pm_runtime_get() < 0 // because runtime status = RPM_RESUMING
>>                                // later data are not commit to the port driver
>>                                                 status = RPM_ACTIVE
>>                                                 rpm_idle() -> rpm_suspend()
>>
>> This patch tries to fix this by checking the port busy before entering
>> runtime suspending. A runtime_suspend callback is added for the port
>> driver. When entering runtime suspend the callback is invoked, if there's
>> still pending chars in the buffer then flush the buffer.
> 
> ...
> 
>> +static int serial_port_runtime_suspend(struct device *dev)
>> +{
>> +	struct serial_port_device *port_dev = to_serial_base_port_device(dev);
>> +	struct uart_port *port;
>> +	unsigned long flags;
>> +	int ret = 0;
>> +
>> +	port = port_dev->port;
>> +
>> +	if (port->flags & UPF_DEAD)
>> +		return ret;
>> +
>> +	uart_port_lock_irqsave(port, &flags);
>> +	if (__serial_port_busy(port)) {
>> +		port->ops->start_tx(port);
> 
>> +		pm_runtime_mark_last_busy(dev);
> 
> Do you think we need to call this under a lock?
> 

I just put this close to the ops->start_tx() where I used the device. Yes I have no
strong reason to put it in/with the lock region, but pm_runtime_mark_last_busy()
should be no costy and safe enough to put it in the spinlock region.

Any thoughts?

>> +		ret = -EBUSY;
>> +	}
>> +	uart_port_unlock_irqrestore(port, flags);
>> +
>> +	return ret;
>> +}
> 
> With the above I would rather write it as
> 
> static int __serial_port_busy(struct uart_port *port)
> {
> 	if (uart_tx_stopped(port))
> 		return 0;
> 
> 	if (uart_circ_chars_pending(&port->state->xmit)
> 		return -EBUSY;

I'm not sure but EBUSY seems not quite match here. EBUSY for
"Device or resource busy" so the device probably cannot be used
but we're testing whether the port is busy here. Hope I understand it
correctly.

> 
> 	return 0;
> }
> 
> static int serial_port_runtime_suspend(struct device *dev)
> {
> 	int ret;
> 	...
> 	uart_port_lock_irqsave(port, &flags);
> 	ret = __serial_port_busy(port);
> 	if (ret)
> 		port->ops->start_tx(port);
> 	uart_port_unlock_irqrestore(port, flags);
> 
> 	if (ret)
> 		pm_runtime_mark_last_busy(dev);
> 
> 	return ret;
> }
> 
> It also seems aligned with the resume implementation above.
> 
> ...
> 
> For the consistency's sake the resume can be refactored as
> 
> static int serial_port_runtime_resume(struct device *dev)
> {
> 	...
> 	int ret;
> 	...
> 	ret = __serial_port_busy(port);
> 	if (ret)
> 	...
> }
> 
> but this can be done later.
> 

I agree the refactoring should go to a separate patch. But it doesn't seem
to be more simpler or readable comparing to the current implementation? Just
want to narrowing the spinlock region?

Thanks.