Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp156093rdh; Wed, 7 Feb 2024 00:09:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWefkHHsuWLGrnPDQNm7W1HUB+esxVsAZTbd+6clX47QKU4ibL/cR95fxqVHJvhSrg9AH41uo/Nbw7gq7y3F8f64+yLIfdz6zVds1EkPw== X-Google-Smtp-Source: AGHT+IFkr2grlG1uHbetPLLolsWtjDTM46DDEsfSHU119gHIgGpyXwYzZ0uZ0EjerhkoRlscqELD X-Received: by 2002:a25:2d19:0:b0:dbd:7383:d155 with SMTP id t25-20020a252d19000000b00dbd7383d155mr4741932ybt.0.1707293397489; Wed, 07 Feb 2024 00:09:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707293397; cv=pass; d=google.com; s=arc-20160816; b=ByBALbyyBv73l+oiHjaz7n/XYhr8FUYsMjzckpLVpXYOeSoxM3O7GEVjYW+VgHRHID 0Nq6OgENBrQfdCsZHQR8LdvkIZeVjeTyV0G9rbhCHt+Fm8tPfE7KenVrlsePuo8nbDKG 1FmhBorp/5Z8DdwWivMW0hUML3Z5PluWM1rDaW2qA7dm/O13wyVD7JUESSJcTFHfn7aY TD9t231oHtONPY60a5UMXffLArZqJ1MfAXykafuTnNdAvzEvytKuIRcRYOB2kOB0jrPG 1LjY/VbMdfDxuPAUHA/f6+PG8wp2YoA/ygdadS95HRlk3nvtHgP8xZwltLyOoOJtGW8M mmkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=gvgIiqnySVbEXyp2uMeLh+MoLzV556pIVAJ6JZ+6aow=; fh=UDTaSt2ZMhXXrH4JrkI53RAT/qDn9db0AFfjeUEaX3s=; b=FFJA72rszm+DGBuYnO01J9jh1gu64cLdATsmJow9L9lEE45jYau7fk0CK9LHHFJJ2O ITLxPQKtXV6WJtti53W4DCf1PA0vLhdR8KO1BMpCkdBoXrvMev00UCliv7fdzPILAyEr xUB+7Ogwjw82rufRLBCtxDDXyRI/8v2+O5mlN5Sx+/nkYs0rKJgVsNnpFDM1KjM2pXZa OHn8QHZgXaGDN+NU63J8y03rwlaJUstaKZqPll1CkVwOmbtKY5/C9TtG1hoSAiZc5Bl8 /wq9OdoKZD2g75PIZW5i2BVh7oImbf9yvnDzX5IPZmGXATtXnCvP+Zfoyc+HC/FJX5Zh cCqA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d68xilUo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56103-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56103-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCU4VMEWYYL8wYsO69RYR4/UAtgwyH2vR0LxjNbVuCr73zc90IqEM43V7q/vp8eb2H1ANEQblVRfFStjs0Q/VenwsyzlMTI9m5poQasiVQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id cl13-20020a056a02098d00b005d8c55c9ca1si986598pgb.358.2024.02.07.00.09.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 00:09:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56103-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d68xilUo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56103-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56103-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C059728819C for ; Wed, 7 Feb 2024 08:09:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A66EE200C7; Wed, 7 Feb 2024 08:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d68xilUo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C417B200AC; Wed, 7 Feb 2024 08:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707293338; cv=none; b=jnCUoMPWKGCo47m1nWHefNMNOyFF4cYlBrogaNOvyyz4f2F6dxsuAtiqvsUB3i2SQu/NiYEUxpNsR2gqbyKsjrRWkoPuuyl7LJyBwMnUfuVeqmFZIY08Eodfpwa3+eUabD38VtJFbLm33+CaAOFxiXU27bNQyQ+Ivpsb5VWY09Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707293338; c=relaxed/simple; bh=57iKMo8gsXVdW40iwK8MU76XeVzaqjNop9+cUYX2IeY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kivPctPjE2GcgfJGNoytlOr7u3D4tDkAysX6RUCGXj2dRrj3V9OLbBk4m0cUTkkEX+6cB37bs+FjPL4DX4TjU7UT+C0t5hypOZ/DsdLvgYoxX1whsoqAR8uvzGvNjiTFntSlZ0oB8tTF/ynqyWMT96Tt+c4Y8ADWJHEnF0pf294= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d68xilUo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0CA8C433F1; Wed, 7 Feb 2024 08:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707293338; bh=57iKMo8gsXVdW40iwK8MU76XeVzaqjNop9+cUYX2IeY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d68xilUo0Wlh4oO13lvXX4kmOUdH3P16an7Q5qHJUxV9UDx3QrMcCiDyJb60cONUl LmjYRO1j91Bcs6SjmD13LuMKGg0kK7KLgEJlvorVFwhgtISAsrNzxMT8BbZvlC4bBu LrFipdm/pDfeaDtmFNuxxPjxW0+nzaGAlHMD4Z7VCGmGuYuNCf5G05bSn2ibkCov23 Y/JTwjCvWXzqlto4DuX78s18vbw4FScLXHVU2TBYoS/RE9UI/c7PvAqseb2YZRMjYM qOkSDtXnxVkx/+4jRmDqmdt0Cq7pe32mY5SDABZ98AnhbUsC5BZUUr3DO4DPIEM3oK XLxoL4JQn+ypQ== Message-ID: <14d1464b-7d60-4021-bc33-b0e809f3cde0@kernel.org> Date: Wed, 7 Feb 2024 09:08:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC Content-Language: en-US To: Jingbao Qiu , u.kleine-koenig@pengutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dlan@gentoo.org, inochiama@outlook.com References: <20240207055856.672184-1-qiujingbao.dlmu@gmail.com> <20240207060913.672554-1-qiujingbao.dlmu@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240207060913.672554-1-qiujingbao.dlmu@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/02/2024 07:09, Jingbao Qiu wrote: > Implement the PWM driver for CV1800. > > Signed-off-by: Jingbao Qiu > --- > + > +static struct platform_driver cv1800_pwm_driver = { > + .driver = { > + .name = "cv1800-pwm", > + .of_match_table = cv1800_pwm_dt_ids, > + }, > + .probe = cv1800_pwm_probe, > +}; > +module_platform_driver(cv1800_pwm_driver); > + > +MODULE_ALIAS("platform:cv1800-pwm"); You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong (e.g. misses either entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete ID table. Best regards, Krzysztof