Received-SPF: pass (google.com: domain of linux-kernel+bounces-56108-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@ziepe.ca>, Joerg
 Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>, "Jacob
 Pan" <jacob.jun.pan@linux.intel.com>, Joel Granados <j.granados@samsung.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 1/8] iommu: Add iopf domain attach/detach/replace
 interface
Thread-Topic: [PATCH v3 1/8] iommu: Add iopf domain attach/detach/replace
 interface
Thread-Index: AQHaTQbdnqiGZVOmpEOcHKLJUGm2irD+nkbw
Date: Wed, 7 Feb 2024 08:11:05 +0000
Message-ID: <BN9PR11MB527629BF9A0E27E36D3925B18C452@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240122073903.24406-1-baolu.lu@linux.intel.com>
 <20240122073903.24406-2-baolu.lu@linux.intel.com>
In-Reply-To: <20240122073903.24406-2-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NPE7zgStCTIbkzeBK6PvhTDqClTpJYyml0HhvgbV50cPSO36g9hhjCzgjVQ2?=
 =?us-ascii?Q?3r/WZUBi7IiAb9yWild6ijGjV6WDORMA9sVIsH7wdNorniS4YZGOLO1oKbIV?=
 =?us-ascii?Q?NFPJaxkYyOG/uZNngFjZ+joQ4pCrnpbxr4mY+Ynfyj3/8100bYn19VA6f0Ve?=
 =?us-ascii?Q?7zpDTgnsgPkJL0i1s+u3mmLaRQ2egKPNXlSm7GcXtNKuBY3fxo7ZcSFUPeu7?=
 =?us-ascii?Q?4ZZyFU8jwE/NTo+VVsr5vOJoJaZXQ4FMAGiC6dvjl+xXiZ6vz8EkKdfEW+WE?=
 =?us-ascii?Q?y8UWPVG/9ElmrWKXTcs5FbxGERXcSN0Ao3eaeTGYuiU2ShVPBKinbMvGARZg?=
 =?us-ascii?Q?bArcrRaGRo0GWwbZd6SNcGqEOqig53lgMVARu4mvW8aukBQTRwNRVjkvRCk+?=
 =?us-ascii?Q?SATMbEW9J9TKlNadL7PZWRLJohqQE65vX1/5wpqVYpiV28txXSbIdv9NPkdu?=
 =?us-ascii?Q?ZyNz2B5QRyvkXjMrjPfef5LDHCYPgm/EbFITTQASLPxBc3NNcB1IQmGaJHna?=
 =?us-ascii?Q?GwCnZqN5ccBQUqGbLCsjOWdO9qQ1AprK0HRYtWwGIgaRMFk78ZWIqmAqHQWT?=
 =?us-ascii?Q?2ON9Y754rvFQZmAel9mIhBf4e1A9nyQ3Z8jRWwI7bc+kZgeBCBDfU9ufzQ7Q?=
 =?us-ascii?Q?wzlWCJ12vQpzs5xJrGMS2sfA4LF1ZMDKdKFQfzzj1qF8zHrMP07uxac/26U+?=
 =?us-ascii?Q?XoxYyoHx1AR60vcU8T/GjQ83jai7wczuawbcXjyRVtRnbzqdLO6UPC0yaJhN?=
 =?us-ascii?Q?/o0zFeew3uVC/gB3EfFdKsnwKVHR//xUnxJK9FkzKFMISXIRtU26+Bm15zT4?=
 =?us-ascii?Q?LGTJkYdxfz+4cSgvH5hWNn1mY1wZ3SYMCPonUg50QNstnTnR4kFzuIr10lzj?=
 =?us-ascii?Q?kMPrJMpRNVXF9B6Dvk8swAbELonxf9Pu/g9uLgY+D1juP3RLqkJq43RBCHP9?=
 =?us-ascii?Q?AzVl0Q+TV6J91EnPDgLG9RhoKOzmZjuePJhcIweuDue9OVomG09iCe6uztDn?=
 =?us-ascii?Q?rDDKj2RFqrUfC7I6yTAL4stm0iDGXKrCew5AmauM7xDwmWW//rDH1nXVfFzI?=
 =?us-ascii?Q?2bJTlec/xkMCktk+OYncXTXVQEXXZA8ar3COfUwddHnLHQSHE5NpNlwG9hfD?=
 =?us-ascii?Q?HWjTLn0B80+EVL88zap/BFVxNdBL/8sizpN54zXIs9FQYz8se1OgQK6iOb+9?=
 =?us-ascii?Q?ywNeKGOW7rurLeVzynMxhI9JxWPd7wQYJC7fmYLOawKlspLx9brzZ6Igs/bp?=
 =?us-ascii?Q?DgOKCALX5/eIy0TG2vip4vtT6iyBz/oL0xOLlPQhvc3UofothMTuErB9xWI4?=
 =?us-ascii?Q?9LBW3R4GpMCIXBLTH9tHzIo5giwmuZkR6mS0G/UUAyW4akQ7DGNInf7EcPOz?=
 =?us-ascii?Q?FzQCbXR3qaHuiOS2Sc7CkDUFJwpAhV2fbUAUAjLk1fys8k3Fklx/x1P4aPSc?=
 =?us-ascii?Q?OupOg0OYeKT/I5TbesPkWJyzzE23M6hOv6X12hfuisUSJH+ThX1HjGv1HKm6?=
 =?us-ascii?Q?lUoCD8/IWA5AwEv+E66GqvefN4XlMYCh6F87nEsgjK8J2k+17BFOoROARSfN?=
 =?us-ascii?Q?lO/X3dcgLnuGRNmaAuEolwtQT8Y3Zpa+HGgKwRUR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0d8d6c-fbb2-474f-5109-08dc27b45566
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2024 08:11:05.9627
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6kFhTRgBkETJnqluWkoxKiMOkCw//eBpkJrg8T3Q+rPY+y4L9FIsg1EHwlSxQtA04Gmq89h2lPz2IMic1xb0Hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7443
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Monday, January 22, 2024 3:39 PM
>=20
> There is a slight difference between iopf domains and non-iopf domains.
> In the latter, references to domains occur between attach and detach;
> While in the former, due to the existence of asynchronous iopf handling
> paths, references to the domain may occur after detach, which leads to
> potential UAF issues.

Does UAF still exist if iommu driver follows the guidance you just added
to iopf_queue_remove_device()?

it clearly says that the driver needs to disable IOMMU PRI reception,
remove device from iopf queue and disable PRI on the device.

presumably those are all about what needs to be done in the detach
operation. Then once detach completes there should be no more
reference to the domain from the iopf path?

>=20
> +struct iopf_attach_cookie {
> +	struct iommu_domain *domain;
> +	struct device *dev;
> +	unsigned int pasid;
> +	refcount_t users;
> +
> +	void *private;
> +	void (*release)(struct iopf_attach_cookie *cookie);
> +};

this cookie has nothing specific to iopf.

it may makes more sense to build a generic iommu_attach_device_cookie()
helper so the same object can be reused in future other usages too.

within iommu core it can check domain iopf handler and this generic cookie
to update iopf specific data e.g. the pasid_cookie xarray.