Received-SPF: pass (google.com: domain of linux-kernel+bounces-56140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 7 Feb 2024 09:45:15 +0100
From: Christian Brauner <brauner@kernel.org>
To: Tycho Andersen <tycho@tycho.pizza>
Cc: Oleg Nesterov <oleg@redhat.com>, Andy Lutomirski <luto@amacapital.net>, 
	"Eric W. Biederman" <ebiederm@xmission.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidfd: exit: kill the no longer used
 thread_group_exited()
Message-ID: <20240207-fenster-strotzen-b31de9bee30b@brauner>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZcJmiBxpaElivX2J@tycho.pizza>
 <ZcJmbUzox6Rd3587@tycho.pizza>

On Tue, Feb 06, 2024 at 10:04:08AM -0700, Tycho Andersen wrote:
> On Mon, Feb 05, 2024 at 06:43:47PM +0100, Oleg Nesterov wrote:
> > It was used by pidfd_poll() but now it has no callers.
> > 
> > If it finally finds a modular user we can revert this change, but note
> > that the comment above this helper and the changelog in 38fd525a4c61
> > ("exit: Factor thread_group_exited out of pidfd_poll") are not accurate,
> > thread_group_exited() won't return true if all other threads have passed
> > exit_notify() and are zombies, it returns true only when all other threads
> > are completely gone. Not to mention that it can only work if the task
> > identified by @pid is a thread-group leader.
> > 
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> 
> Reviewed-by: Tycho Andersen <tandersen@netflix.com>

On Tue, Feb 06, 2024 at 10:03:41AM -0700, Tycho Andersen wrote:
> On Mon, Feb 05, 2024 at 03:13:48PM +0100, Oleg Nesterov wrote:
> > rather than wake_up_all(). This way do_notify_pidfd() won't wakeup the
> > POLLHUP-only waiters which wait for pid_task() == NULL.
> > 
> > TODO:
> >     - as Christian pointed out, this asks for the new wake_up_all_poll()
> >       helper, it can already have other users.
> > 
> >     - we can probably discriminate the PIDFD_THREAD and non-PIDFD_THREAD
> >       waiters, but this needs more work. See
> >       https://lore.kernel.org/all/20240205140848.GA15853@redhat.com/
> > 
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> 
> Reviewed-by: Tycho Andersen <tandersen@netflix.com>

I updated the trailers with your RVBs.