Received-SPF: pass (google.com: domain of linux-kernel+bounces-56160-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <70a4854e94cfd04b1a0ec9d3defe50ec56fc874f.camel@gmail.com>
Subject: Re: [PATCH 2/2] iio: accel: adxl367: fix I2C FIFO data register
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Cosmin Tanislav
 <cosmin.tanislav@analog.com>,  Jonathan Cameron <jic23@kernel.org>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 07 Feb 2024 10:08:38 +0100
In-Reply-To: <20240207033657.206171-2-demonsingur@gmail.com>
References: <20240207033657.206171-1-demonsingur@gmail.com>
	 <20240207033657.206171-2-demonsingur@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-02-07 at 05:36 +0200, Cosmin Tanislav wrote:
> As specified in the datasheet, the I2C FIFO data register is
> 0x18, not 0x42. 0x42 was used by mistake when adapting the
> ADXL372 driver.
>=20
> Fix this mistake.
>=20
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> ---

This needs a Fixes: tag. With that:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/accel/adxl367_i2c.c | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/accel/adxl367_i2c.c b/drivers/iio/accel/adxl367_=
i2c.c
> index b595fe94f3a3..62c74bdc0d77 100644
> --- a/drivers/iio/accel/adxl367_i2c.c
> +++ b/drivers/iio/accel/adxl367_i2c.c
> @@ -11,7 +11,7 @@
> =C2=A0
> =C2=A0#include "adxl367.h"
> =C2=A0
> -#define ADXL367_I2C_FIFO_DATA	0x42
> +#define ADXL367_I2C_FIFO_DATA	0x18
> =C2=A0
> =C2=A0struct adxl367_i2c_state {
> =C2=A0	struct regmap *regmap;