Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp177642rdh; Wed, 7 Feb 2024 01:07:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXozBNaBoMXLUusHpcyxeR76smkVlwlUw64Scf0FdnOj9fPKMnBew8WM4fEp702esUpeS/tVR3Qi/0WBKn86BwEEcwBba6HY57krtaWiQ== X-Google-Smtp-Source: AGHT+IE48hhhxPbENkaVhUFK3qpFeqhTLVIrifAjEY6kyl1TpHFhXnSZcjoExRweJ2ynsqgi6S/v X-Received: by 2002:a05:6402:8d6:b0:55f:30dc:a72f with SMTP id d22-20020a05640208d600b0055f30dca72fmr3455574edz.7.1707296849128; Wed, 07 Feb 2024 01:07:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707296849; cv=pass; d=google.com; s=arc-20160816; b=LtSNlqb1czXEqVjpzec2NHa4miXSn8P3Ah0G9GtwygYupslSTzQNLdjcXo+D2z2HXD 6nY5oX3jLlygqMQFNeNfgvvHJVBgdPFHz2sXIKz268JVL7jsiWoHwh/91C/0eL7YmlPD wb100zPqweNlGGmlydyCagKlLrxpujSlaGz3EfQ7JysEe+40UnmZlQLdxnO+36mFMLBc s9tORwuPN5AONPXDX7WueraJ8aXWrrfeS9ARgxhe72neGYHstzipUWJUyouWF/+8zVYp j6B4MpRGr42DSfX9rF+1T5m9LCh099aN12fWK2VdrPUSZO0PkfBb3GKdb+AE9lBcRNa5 t3WQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ADqUcObLVQ6bWjRx4Kv+O6wB0gOJh13hFxcfWX7qoYQ=; fh=S8OVLfepU4vLgZgFimiZuB4G3M6TsPvU3IsaKuUO6tM=; b=Bik7v4u4gmJaD8lo/usK+sIdOPSG4nZneddIuD6DFe59UbGSGWb4hOw8sOVyJTsZNg EV/VX6vfqNwPAx2qf1+yd4jVj7oCDduMSEcr0hslmW0zOd6eVg9anj7UsgMpzdlIuAhC w4hWuzV9DnedkCWJehY6NwddQTrn73NBtKEbFUlbhfNp9dfqVoSpiP+DQz++u4rRSXGT uf2as1mPs2YYt///D7jY8ROyL2q024Jiw57q6zLxiW+J7f7a7ks/2gPAwDR5CfBuchX9 IgwYkLaffQdt7YMmQn3M2f+DJKvoER3PVYI0e8QtFH496qzwvEubM2XpqgRNChN3+zaP GrMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AA9tlt0e; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56164-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56164-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCW9noTQsX5xhC1Hc0+55aSOHc1tWdEB2bQex3EmkPXhUpvKrAEACL7zF/e76Fr2exwRKKrz/VAb/gvVGoSp72J/s9mw4t0t6GuI0flAZA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id p13-20020a056402074d00b00560afe177ddsi620825edy.545.2024.02.07.01.07.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 01:07:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56164-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AA9tlt0e; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56164-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56164-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D37301F24C94 for ; Wed, 7 Feb 2024 09:07:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DF5E20B0F; Wed, 7 Feb 2024 09:07:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AA9tlt0e" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9205320B03; Wed, 7 Feb 2024 09:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707296839; cv=none; b=J3nIfZmSTh4K5PDZRfBEBs7QteARQcwXnwm/nH5Qd8i5hQVcy1H6DkcCO4/Kh/acgCoD3p9qAQeQfV6pbPhbheLoe/8jrME0PtVSXOX7J9SreX6csEpkIOMchbGuqVsQK6pycvPUuKZpJwUEUN55gfEKy7M/6ycmbXTcp5YMI60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707296839; c=relaxed/simple; bh=vzywu5IswpNrXIxbT6TvtMwzem9EQ7EDDDB9P61uUzk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C8ZBVeHpI/7jYjRBZTAHRPslIvO4uS7q5rSKwTXe06pn9vB0vwKXSrjoy93p/OYVLw5KWYJz3seP++k29LxxWcWNrnyjYn9KEPw+nE1piVvL1w7Sl4zmgR1v5L5VQUvnxsmkr9BlDw35anRhIpmwS7TJZql4PfYKY4bsgIzy3mE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AA9tlt0e; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07B0CC433F1; Wed, 7 Feb 2024 09:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707296839; bh=vzywu5IswpNrXIxbT6TvtMwzem9EQ7EDDDB9P61uUzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AA9tlt0eHXoJfI6RgIJl94FdEkz+Wnf2bgd2NhBMNyFdXngnzwLK9sNYTyuGxaCTg 8+IDtMP4CNdjOTntGO7v/2OwFimJJJlkBQemOLepM5coJtMCfsHQtM5EtDZdVzZteU o+DQonhhCrTXkJJr292vmL0M/NMzFa4kD35H9RkLNmyWxLF4q6NdJXcWf4VVeGIXLp +TE1r7QBzGpyTFPdqLNTMtnwkhaPLenic35Z9eFanyEc6IgjyEu5Pqxu8lQEpe6UAM OKdzImvSfG5+k6nb+aqbXy7Fxs6AZdKC9hXup+wOrdStRbEWnWT4ttpaKKeFTDZ9Vr jLEd2am4c5cvQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rXdtv-000000005zh-09RT; Wed, 07 Feb 2024 10:07:27 +0100 Date: Wed, 7 Feb 2024 10:07:27 +0100 From: Johan Hovold To: Konrad Dybcio Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam Subject: Re: [PATCH v2 03/18] clk: qcom: reset: Ensure write completion on reset de/assertion Message-ID: References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> <20240105-topic-venus_reset-v2-3-c37eba13b5ce@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240105-topic-venus_reset-v2-3-c37eba13b5ce@linaro.org> On Tue, Feb 06, 2024 at 07:43:36PM +0100, Konrad Dybcio wrote: > Trying to toggle the resets in a rapid fashion can lead to the changes > not actually arriving at the clock controller block when we expect them > to. This was observed at least on SM8250. > > Read back the value after regmap_update_bits to ensure write completion. > > Fixes: db1029814f1f ("clk: qcom: reset: Ensure write completion on reset de/assertion") This commit does not exist in mainline or linux-next it seems. Johan