Received-SPF: pass (google.com: domain of linux-kernel+bounces-56177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5a38043f-6de3-4038-b1d9-314090e7b44e@arm.com>
Date: Wed, 7 Feb 2024 09:15:08 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 00/23] Introduce runtime modifiable Energy Model
Content-Language: en-US
To: rafael@kernel.org
Cc: dietmar.eggemann@arm.com, linux-pm@vger.kernel.org, rui.zhang@intel.com,
 amit.kucheria@verdurent.com, amit.kachhap@gmail.com,
 daniel.lezcano@linaro.org, viresh.kumar@linaro.org, len.brown@intel.com,
 pavel@ucw.cz, mhiramat@kernel.org, qyousef@layalina.io,
 linux-kernel@vger.kernel.org, wvw@google.com, xuewen.yan94@gmail.com
References: <20240117095714.1524808-1-lukasz.luba@arm.com>
From: Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <20240117095714.1524808-1-lukasz.luba@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rafael,

On 1/17/24 09:56, Lukasz Luba wrote:
> Hi all,
> 
> This patch set adds a new feature which allows to modify Energy Model (EM)
> power values at runtime. It will allow to better reflect power model of
> a recent SoCs and silicon. Different characteristics of the power usage
> can be leveraged and thus better decisions made during task placement in EAS.
> 

[snip]

> 
> 
> Lukasz Luba (23):
>    PM: EM: Add missing newline for the message log
>    PM: EM: Extend em_cpufreq_update_efficiencies() argument list
>    PM: EM: Find first CPU active while updating OPP efficiency
>    PM: EM: Refactor em_pd_get_efficient_state() to be more flexible
>    PM: EM: Introduce em_compute_costs()
>    PM: EM: Check if the get_cost() callback is present in
>      em_compute_costs()
>    PM: EM: Split the allocation and initialization of the EM table
>    PM: EM: Introduce runtime modifiable table
>    PM: EM: Use runtime modified EM for CPUs energy estimation in EAS
>    PM: EM: Add functions for memory allocations for new EM tables
>    PM: EM: Introduce em_dev_update_perf_domain() for EM updates
>    PM: EM: Add em_perf_state_from_pd() to get performance states table
>    PM: EM: Add performance field to struct em_perf_state and optimize
>    PM: EM: Support late CPUs booting and capacity adjustment
>    PM: EM: Optimize em_cpu_energy() and remove division
>    powercap/dtpm_cpu: Use new Energy Model interface to get table
>    powercap/dtpm_devfreq: Use new Energy Model interface to get table
>    drivers/thermal/cpufreq_cooling: Use new Energy Model interface
>    drivers/thermal/devfreq_cooling: Use new Energy Model interface
>    PM: EM: Change debugfs configuration to use runtime EM table data
>    PM: EM: Remove old table
>    PM: EM: Add em_dev_compute_costs()
>    Documentation: EM: Update with runtime modification design
> 
>   Documentation/power/energy-model.rst | 183 ++++++++++-
>   drivers/powercap/dtpm_cpu.c          |  39 ++-
>   drivers/powercap/dtpm_devfreq.c      |  34 +-
>   drivers/thermal/cpufreq_cooling.c    |  45 ++-
>   drivers/thermal/devfreq_cooling.c    |  49 ++-
>   include/linux/energy_model.h         | 165 ++++++----
>   kernel/power/energy_model.c          | 472 +++++++++++++++++++++++----
>   7 files changed, 819 insertions(+), 168 deletions(-)
> 

The patch set went through decent review. If you don't have any issues,
I will collect the tags and send the v8 which will be re-based on some
recent linux next (or please tell me your preferred branch).

Regards,
Lukasz