Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp197673rdh; Wed, 7 Feb 2024 01:55:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0ED60nF/KQYiio/ybkIS/4VNaehB2Q9c4U6msbDqVempD6AAcu1V3/CWWaW3G5dWiwjYi X-Received: by 2002:a05:622a:44c:b0:42a:3195:e8be with SMTP id o12-20020a05622a044c00b0042a3195e8bemr5354864qtx.51.1707299736456; Wed, 07 Feb 2024 01:55:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707299736; cv=pass; d=google.com; s=arc-20160816; b=WwWM4ME/UMmRy/9V+2IXl+B7iGUU+RBlX2sy0LobokV3RjfMDHqlba1EOv6OQ9LOKy fEsP+haJGDTj8R8eiykqOqh20bqOliT+WDzwYdj8AD120V/bjxsc8ALd9Q2P1cFDsZvD RM01Bxhfz/6xh13XODe7LIDRIDiTQmCK9bJBpnj9zqE5ZIPUcQ+8LTVY9aw/NhiBAPTw vhh2yC4awjeYby8bSmeV5sfbIq7YA1/D0gZyXkMlSUDXmL9OcQZA2TVdAQjHOgLky+aI dEBriGJJ1Zq0hoXxZxKTvmaF9aZhexExoTJMXnSAhfxJDUW00VOeHwYkDMEFkACYcf2S tNLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=fsRZs51W2huLngb3aSHYllyqQl8VP5fXmWHfrrQr+1k=; fh=dEAgW7FaRbdj1vi1UYVV+xmfkVo/HCSuMENqJLWcEr0=; b=vjNiBvxP0EmOOGkVmYrLz3/JRwaxzU9dgr3R904L8efYenXjCXeXiq/TMsyP25BqVH tNXD8UXVHK8xIb6GWrSWFb9IbQlbKqhpG711wTMVaIr5IpBU6zXHGb8zl6XyqK7p9cqn REC41vGJ3Q0r2ZBYlprCCqwmlS0Bfy5nwMxQhmQ9WcWW2yvJMZkMpQCpeMB2N+G5c3u6 8nOKNXNkDb03LSRf7I6+4l4ewEuU+eHp+ksfbbsDTiHpg9Eb0OPNB22q4lTDj1hku5cJ FMWdYoxHUb9moltX/YspWTTwKwe28oejiq9pHS2HCVgkKZIYV95vVsgDH4D0p6pWLZqy 1w8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=ozeq4FC7; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-56264-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56264-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCUbaddn9jFKnWmZqTn0t5wVEh/1erJDPVGfWszDox7OUTZAIbmPSsO9868eosJtAkH3LgHFEpstx11ar+wIh1+f7VdPXCnvjMPn83M9PA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w16-20020ac87e90000000b0042c4204b4f6si498615qtj.95.2024.02.07.01.55.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 01:55:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56264-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=ozeq4FC7; arc=pass (i=1 spf=pass spfdomain=baylibre.com dkim=pass dkdomain=baylibre-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-56264-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56264-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F235A1C24B8B for ; Wed, 7 Feb 2024 09:55:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9829825573; Wed, 7 Feb 2024 09:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ozeq4FC7" Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC5724B57 for ; Wed, 7 Feb 2024 09:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707299714; cv=none; b=Dcn1eSZJ1b+myhMLOQuds5Fp4jTkYRqXeRTARdmVMu7HijQ8sOyYUuBqArc+pXsiX4iQcukFIjxecjvJOVVPG7KUdJm3sJ2Pu5Uw1wF4W4Ib8fYDBGs4VgZxOoIejCm+rWcZvnvcORgASl8ZxENA24EQR1pmzdJT/OVXoErfGYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707299714; c=relaxed/simple; bh=kaJT+HlW06iCWLlw7hsvOu6LhCgGH4HmAFtBgRxZjAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J7cIUFKCUXfrcf4CzmOrNHgwMeJLNJHBkhgeMVYNEKmRV5pOUug6S3xf8DPHJ3mzdW12/hzn062U7PQiQ3b/wj3WkNZQILZeT8cjdJwwVHGnHvdBa65ogj0mcqGxXAhprL7lp84Tqh8cwNMSjYTgE1QMXRK8KDlBhw9OP43yIKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ozeq4FC7; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-33b18099411so317330f8f.0 for ; Wed, 07 Feb 2024 01:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1707299710; x=1707904510; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fsRZs51W2huLngb3aSHYllyqQl8VP5fXmWHfrrQr+1k=; b=ozeq4FC7PhWKHu+MScTibvQfeT2WT4NOSph2XBT9WO0yBvj7Woa0qOX4J+l0Bigqan pr2p0ZexUNj41DznwmnMANqUX98uGRI0aiRH+c9u4MpcfvmK0tO+RHNmBzy0b52JAkad gBMe0IvIrybTgy3tL+P6BT3Bth+jWBbq0+JphtpEtMUqpkGGmhjEAxIuTMVHYJs8zm0e xLxvsp++IgmpzGbewf9WNQH6bEucptiV6icikXrTHTj4UHZNBUGPgULBng2x5enqhey9 4pZCO94M2tJ21obvYa+5rMdZrwAvVYt+Qh74RkeORVZfDiFuUzT6HZNdMg3PbcdHcloc sF9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707299710; x=1707904510; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fsRZs51W2huLngb3aSHYllyqQl8VP5fXmWHfrrQr+1k=; b=qM910PyOfKxALVx+PqMgTd1WSHaWUqTUvipYSd71BlcofPQl+7tFpESwi9g8pvQaSr +7ORTY9rNzI+h6efIdSjl9LE0AvLYuX+D2J84SMeCvRsukoLwKYKNyLuPF+tFLA3rPRX 0TvlVoheGEdFgklbBkag7Cuwn6tvoiFoAkowf7V3ec6gXD5cQXVeTb8qffu4aQrOSXGV dV3TRBgyIB+LeXYoI0ogOLMgAStK6maIJM2ZGFFE91bIes1w6n7/3x6+3KJQJj/CF7MD 0657geDG0d/T/EDojzB17TvslozGDZMwZb7ZfwfdX0QvmWMBdHD0KKZwWWHLhq8wJDY0 uITg== X-Gm-Message-State: AOJu0YwRTUqD4+8kv5m4k2P7IEtY9gZLXmpWNKLLObr2qZLrgJvxIAdI 0rckkdIBNTwXlwJDabjLdCZxaFamKWib7ih739beYk4OgswoQwIrGwh3/5HKpEw= X-Received: by 2002:adf:ce8c:0:b0:33b:136a:95a3 with SMTP id r12-20020adfce8c000000b0033b136a95a3mr2875503wrn.28.1707299709759; Wed, 07 Feb 2024 01:55:09 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWomvasDY2y1JGYC41yi3XjKUcCAy+WjDD4t4v3x0Py0iVpS7KfDv1ihzcoSIGyJDs9LYYnSaZ9fVzQIbMxYSQddfp8BcaLQPOmNuHTxP0Iq3nKxKzxCYdg5Amf2xeEnKy64aN9m8kBu/Y+G8fqpLaCgUrbByqQO5y14+C2vcwkn906lbapgjN3P9YUIbT0CwDgRn4OxG9kOMqi2wJLn5digJZ2gLiWgHsG+LSTfjqwUg32N2xvJHUSKhjyYbeycS6tsV13hPkwZlniyYYpr+1XW9zDtc2Jk6XvtZUPvYjgT1Ovve5EMo9BDAjQT2jSLISuzRUJ/qWitiGBJqvLZXczHzEPtiShAn8QqCcU56rFp3agu6i3oSNL9XqzAS1I2ntzuQAt078dz8WPVcmbJz8L2srFCMgE2eVFDg== Received: from [10.101.1.8] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id f7-20020a5d4dc7000000b0033b51e2b9b8sm23808wru.23.2024.02.07.01.55.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Feb 2024 01:55:09 -0800 (PST) Message-ID: <843e34a5-f175-4bda-a2f1-2ea3b56b68f5@baylibre.com> Date: Wed, 7 Feb 2024 10:55:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] drm/mediatek: dsi: Use GENMASK() for register mask definitions Content-Language: en-US To: AngeloGioacchino Del Regno , chunkuang.hu@kernel.org Cc: fshao@chromium.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20240206120748.136610-1-angelogioacchino.delregno@collabora.com> <20240206120748.136610-2-angelogioacchino.delregno@collabora.com> From: Alexandre Mergnat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 06/02/2024 16:53, AngeloGioacchino Del Regno wrote: >>>   #define DSI_PSCTRL        0x1c >>> -#define DSI_PS_WC            0x3fff >>> -#define DSI_PS_SEL            (3 << 16) >>> +#define DSI_PS_WC            GENMASK(14, 0) >>> +#define DSI_PS_SEL            GENMASK(19, 16) >> >> 0011 0000 0000 0000 0000 => GENMASK(17, 16) > > Alexandre, the reason for that is in the commit description :-P > > "While at it, also fix the DSI_PS_SEL mask to include all bits instead > of just a subset of them." Oh sorry... Reviewed-by: Alexandre Mergnat -- Regards, Alexandre