Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp200645rdh; Wed, 7 Feb 2024 02:02:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCNw2eJjODnDSAWhtyPn+d6gqyGSFka8mtoIwMX6DQ4QRrSj16BBcTKawCECWJbSZ7Ed3Q X-Received: by 2002:a17:90b:4d85:b0:296:1fc8:5e66 with SMTP id oj5-20020a17090b4d8500b002961fc85e66mr3283935pjb.6.1707300155666; Wed, 07 Feb 2024 02:02:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707300155; cv=pass; d=google.com; s=arc-20160816; b=OxMJi6988t/xyRMTp7drIC08JgT1Z5VSkkfLFQKoh+7JG6RBh0/2YBACGcPRKTCCiX QBAvWOrllWmqy0p9pLo7mlqX3MtNangghgyFZVs6wPMWMS/UlSR9F1BJ5rBnNC6NhLQy gsZRwAJ7yeWWYe0ATjMnB+8AwcDaw1JeF6T6H9jJc6hxOW9vWGIgEGBnZXC67oDo/xTr LxSQXEOJyglB+DDD4TXYn6dh/dgzclU8X15q+Nx2i6lwy/YUT02y1iz4iV5b3P8Bsq2O MGhOK0J8Jsm0FSbn3bpRa81mCDbZs6CY+G/J8eSyZkxf0UriQgHyhsXLwZq/YWiOGIdv gB8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ZDqyIgs04lCdjoyaOMYhgZb2JCxP3YznXPK7lHIHk7c=; fh=ry9w6bxiOw2BSzWF6oouL+drYBbu8LBlsLQZm4XSzG4=; b=gea/tGYmQRMbOyAemN410IaYaiKPnjtgHWX1vMEzgxXlVO2jKVyaFtTnFZbM+vy2Vd 9qYRQLmakKeeIan9b1hrVE6XsIscvR/sMTcevv1NaufFsZQeyNZoBxSyhlda9Si2nLVe hc98t3F8fJCcu9f6SAyQcu3sc/lrrLriPgFYClK1xenJBlmqvqSlnTUPmqflQxp2sIch nn3QJZ5L2K5TbNhC0uPSL6RUcRfe1D78Qq5YeHzcCRiIUpHdhbHOB+L6lVDwYBshAg3i HjcMh6DiY48ixB1enFkYvv2D2uukH1POBrlFCffAGOd0lVUGJnYpAhHw1C9b1W3I3ur1 X8hA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NWndsM7s; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56269-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56269-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXULpzWSwgdNDaPwlp18QugnhF8sMUKhdnKBb8SkmZbkn3ZLMSKWHMYPucQI5WqU5KMCek59WEsB5Aosq978Yap24fGcrM/UuhZeLqG2w== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id j14-20020a17090a7e8e00b00296a1d0ce70si1192458pjl.18.2024.02.07.02.02.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 02:02:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56269-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NWndsM7s; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56269-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56269-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E7589B2741F for ; Wed, 7 Feb 2024 09:58:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D356725613; Wed, 7 Feb 2024 09:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NWndsM7s" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA5D25573; Wed, 7 Feb 2024 09:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707299894; cv=none; b=OilVH2PsXDaZnEm2c79krrE2K5g4yO+gpqeNIpF7FB4LHzIa3kKCMZXl4oemQHw6zHSX092PX4IjIctHk/HcSa3MT9nbskiumDPI48kS6tk8esrth8hqGRDPQsx3fqvrIoaLrzZxCQwG5wrBR67EV1BbB3HWmertNdmb2AjVopE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707299894; c=relaxed/simple; bh=95FAzMi8iyTuuxbAnG6slusfROgAfn26nwMc3fQaGPU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gjp3CJ+UvD+7lE6jxtG1Jl2ylTq4MGASz2WSeBtBVM5F78K1x2tuWcCd/1Ma1MsFuH1aSkcl6TT17HKGpcP5mmuIaiD2lNxeCSOEpnl1Tc6CVQfruQWmwlf8MSdEbqXELX137SoPcgzmNujBCtzRX1Ww8qlLQjTGlr1qU9QCzpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NWndsM7s; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAB6AC433C7; Wed, 7 Feb 2024 09:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707299893; bh=95FAzMi8iyTuuxbAnG6slusfROgAfn26nwMc3fQaGPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NWndsM7s9F9qWc47sgR3Kmvntf7OiDjMQNcNUjS65XLXcz7zwW7PSIAr9AntNp8DN Ad+Yu/1QHhK0by/HD3XVWwL9pMR3RPGc6JCeivJl6jF8yc0yi28A5w440HfGq4xRed KaO4CRCqKJCdLT/+rxdTiUoHIkohJb3Wpwcyro4Wh9d40m7Ibyg6bm4/NOkJTqshXS EER28gBAlpd593QrsExKbHtjm2mSp2rsV2n65dHcs5WGtRPRML/yaVBmBX7PkyAVBF h8oIpINHUs1Qb9G/RH65TmTNce7kNJ1No2KllIRfPmqoXCVatCYD6d7laUlcxswxLG F9m1muFGXGtJg== From: Christian Brauner To: Jens Axboe , wenyang.linux@foxmail.com Cc: Christian Brauner , Jan Kara , David Woodhouse , Matthew Wilcox , Eric Biggers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH] eventfd: strictly check the count parameter of eventfd_write to avoid inputting illegal strings Date: Wed, 7 Feb 2024 10:56:33 +0100 Message-ID: <20240207-formgebend-ratsam-e3372573781f@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1215; i=brauner@kernel.org; h=from:subject:message-id; bh=95FAzMi8iyTuuxbAnG6slusfROgAfn26nwMc3fQaGPU=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaQeDtGNfLj0wJHmUwr6np+s8hc4/JYOeLjFX0Fz6pa6U L/JM3aFdpSyMIhxMciKKbI4tJuEyy3nqdhslKkBM4eVCWQIAxenAExkhzsjw/edNvPN/3xkZ9yx 4d1fyZmXswMOXVmz3U+adUK+/3qnA/yMDAu3mZ/9e7PI9lzxyUwZ7qsXHM8v0ynYKxCRWPb75V+ /qYwA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Wed, 07 Feb 2024 00:35:18 +0800, wenyang.linux@foxmail.com wrote: > Since eventfd's document has clearly stated: A write(2) call adds > the 8-byte integer value supplied in its buffer to the counter. > > However, in the current implementation, the following code snippet > did not cause an error: > > char str[16] = "hello world"; > uint64_t value; > ssize_t size; > int fd; > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] eventfd: strictly check the count parameter of eventfd_write to avoid inputting illegal strings https://git.kernel.org/vfs/vfs/c/325e56e9236e