Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp213687rdh; Wed, 7 Feb 2024 02:33:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IElIq4WW8ug6oWrEXbQ3KQF3661wlQN3CG+X2+GTT6U3cwCtknE+Qt07g6Q3DDXJyDnZ6ca X-Received: by 2002:ad4:5dc9:0:b0:686:2fb3:6bda with SMTP id m9-20020ad45dc9000000b006862fb36bdamr5861408qvh.23.1707302014414; Wed, 07 Feb 2024 02:33:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707302014; cv=pass; d=google.com; s=arc-20160816; b=Qv8jIFaiJr41SvtTQMFHTV11VNIii3yy/V7yYOzKgWf5UB1ezEW5m3SYnuX9FsIM4c XPYCRcY3GMmqqpDLGUbLhhKXqa+yIodhwsgFxntu4OXf9aJuQDQw200jVsXs6sqzjTr8 8MkFcJZ0a2blsv014nbGp/QiInpw2kdLPxKKJCY7vXGmiuZm8bWuWe4c6xFUBP65+7Nb UtN13mRnVPI3YP8E55uRyQZuKsDwxI7nPHw5z4ov6VOFI+aT6L7YPDoZ5FZ8AJLcuV1c drZL5ZJ6OH+zVRqf4YaYIevm6YPnTow3n9z5p/3wzZ0T7qqn5/+eQNcxI8j/ytcWt+BM 41kw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=vLXGv1EUKmS8dtKvb8mpu+/jx8nLcaWSFNexa86Ni+A=; fh=15zFWypceEy3ml12ZFoas9gD0ieQ2eTY+O0KLptnp0M=; b=Pcw6IWfcoVGF63npHsVyFFjH+DybF57QYTSIFszKb/cmdRBx7cQwt5BTcOWTdqRNIz UcX/9xOdGEMRJ2+T8H0mTt28I11DJVrFf45dzTrdx3NofbyGwj3cCpVCsoTiGiF4jWGq zqQMDCSKvi40lxLXToSy/tXr+w17Y1viQshp1A9K4RB91NIrrzRBhEYq5RtQDXC7pANU PIre27P0OlCq/rzFE56kLXCvLveOJXlq1Lu8znLytcRrP4/LX2e/G3zYfzMjmw8xQeHH rXqXu4RJGrTmaDfr+FcEkX+Tupj96Op52O0EdcePV71Ysg0VXgMUxpkCFAJbcGf7Ab/6 ZsXw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="P3/Z0alP"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-56325-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56325-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=2; AJvYcCXm2IMcXTn7glEWNGWhat8YijfbrRfKVZcp2oCR7wX0WRpku4JmE1MlpQhibmUKtG/EPVu66hxmTnbTv52mbhj3VWvTBY3QF5ZMYUUJsQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t18-20020a0cb712000000b0068c7d55794bsi800511qvd.135.2024.02.07.02.33.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 02:33:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56325-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="P3/Z0alP"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-56325-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56325-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1D53D1C25025 for ; Wed, 7 Feb 2024 10:33:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B553B14273; Wed, 7 Feb 2024 10:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P3/Z0alP" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C846134BD for ; Wed, 7 Feb 2024 10:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707302007; cv=none; b=Xpw1r+8Ko8biRFd5Q7NqVkkKWkZvzeddY5t8ngCee53fxseKBSLoTBly3N8cOAKmvnk2uYwx0A0p3lm4Uq74mvVst1WhaA+YyMRLEd1QFy9dviCOX/SguMUyq0o79CRAqmCUgr19cmlzlRs+x+ybLWRVVItP431J6b3LJe3WH8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707302007; c=relaxed/simple; bh=vLXGv1EUKmS8dtKvb8mpu+/jx8nLcaWSFNexa86Ni+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pL9nsHwm3mDtA6eAz0IYGHrKV/3pOB0MbN/zWlJIVR/rso3iaf/dVSrxOKhjCimNJhSF9fpgOFpUct+RiHBn42EGwLYaZR1qfr7ZjDTi4NZ8h9WMJGVWCqi4zt43ElBBSojY0dyhD9oMhNgUNGUws4k1AuXfrLGZ1ux2L/iYoLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P3/Z0alP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707302005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vLXGv1EUKmS8dtKvb8mpu+/jx8nLcaWSFNexa86Ni+A=; b=P3/Z0alP1JcsqnySkFRKLD7jwDAsoLq/q9uxpp6ShaJ/OkPpwU3kvNR0HOC+VrgaEAe6Xq zfn6mfyR/a636EUtZYQBsJA9JeTngVQP2j7iHaMlSioJU823rWX76xRbBcpjrQ/trSIVDu VDKcdvlGopkQMzjWB3nGcC/k807Lj80= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-2idMZ__JM6qpwL81IFxJCg-1; Wed, 07 Feb 2024 05:33:20 -0500 X-MC-Unique: 2idMZ__JM6qpwL81IFxJCg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F358785A58A; Wed, 7 Feb 2024 10:33:19 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.212]) by smtp.corp.redhat.com (Postfix) with SMTP id 559DB2026D06; Wed, 7 Feb 2024 10:33:18 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 7 Feb 2024 11:32:03 +0100 (CET) Date: Wed, 7 Feb 2024 11:32:01 +0100 From: Oleg Nesterov To: Christian Brauner Cc: Tycho Andersen , "Eric W . Biederman" , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH v2] pidfd: getfd should always report ESRCH if a task is exiting Message-ID: <20240207103201.GB6627@redhat.com> References: <20240206192357.81942-1-tycho@tycho.pizza> <20240207-vibrieren-waldarbeiten-30eeade05203@brauner> <20240207-daran-fliesen-6039a2e36f39@brauner> <20240207-blumen-neulich-f1507e0c5cc0@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207-blumen-neulich-f1507e0c5cc0@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 On 02/07, Christian Brauner wrote: > > So this is what I have applied currently where I moved the check into > __pidfd_fget() where it makes more sense imho. But please double check > that I didn't mess anything up: LGTM. You have already applied this patch, no need to add my ack, but FWIW Reviewed-by: Oleg Nesterov