Received-SPF: pass (google.com: domain of linux-kernel+bounces-56338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240201162758.50733-1-brgl@bgdev.pl>
In-Reply-To: <20240201162758.50733-1-brgl@bgdev.pl>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 7 Feb 2024 11:45:39 +0100
Message-ID: <CACRpkdbAw5NfSr8GSNiQhOzSi-tERyn=-ZroLfF-FRbsW2JviQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: set device type for GPIO chips
To: Bartosz Golaszewski <brgl@bgdev.pl>, Greg KH <gregkh@linuxfoundation.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 1, 2024 at 5:28=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev.pl> =
wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> It's useful to have the device type information for those sub-devices
> that are actually GPIO chips registered with GPIOLIB. While at it: use
> the device type struct to setup the release callback which is the
> preferred way to use the device API.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
(...=3D
> +static struct device_type gpio_dev_type =3D {
> +       .name =3D "gpio_chip",
> +       .release =3D gpiodev_release,
> +};
> +       gdev->dev.type =3D &gpio_dev_type;
>         gdev->dev.bus =3D &gpio_bus_type;
>         gdev->dev.parent =3D gc->parent;

Looks good to me (TM) but we should run this by Greg so he get the chance
to chime in, I doubt he will see it on LKML.

FWIW:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij