Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp229291rdh; Wed, 7 Feb 2024 03:09:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkM09fTeg9Wr5dKpP9QkADjaGE2Z+C51OWDvCw+M1N/7IP8+Vm16XeIhyKzS9x/RJB381w X-Received: by 2002:a17:902:ec86:b0:1d9:1b55:a37 with SMTP id x6-20020a170902ec8600b001d91b550a37mr5210568plg.50.1707304143284; Wed, 07 Feb 2024 03:09:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707304143; cv=pass; d=google.com; s=arc-20160816; b=owWlMnLWTU/QBT1A426e6QvsC2VPk3vhQ8Os6m04mwgWR0PkNschbk34sm35A5rlFH JdhqyrPxbFCB0oxXuBzogHY5+UlOseq0R0gu6rOqUL40Y1ZiSmvKc6DnIfuZ93Q4nN18 rbjsyOXfKI4IcoJLH4q9vicjhiy7OQzOlvIyae+Mzr7uzjcaYeujVdFqB2opLI8jA3BO t4nNGnKVKQfARCvVpa3lcddXzlU0L6twLD/TyDfaUzbiFtGSU4KxWKGRmL8ApQh5a2r4 5p95UiTgSQNlVZi/XUQBeV846U3FAsO5u9dAfWvpWJZoVANrKvnn24osKRE224996RGn 7ftg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=MTbn+GOfkOr21qW6Nz7BLbVuS4irHTaMYjeowJjFN98=; fh=SujhZLeLylQ9GdE3GqPVebyEIlZbZ7xXhhIc0JQGwAA=; b=TJeh3CUA/oqOaQaarHBgnIT+MQi9cpcpwcfV2CMujIIuMLhzwhI5CRrZh/pKPJaFfK rgMjNnUugEXk3NHZ7Y/sku9gBQ58JjEAEOP+yawDqPX5T1eWKeGrkGAzknSc+Ll9U5/Z F+0ct3Dit1T2T34KVaMpE5jm2S1yDdxZG5qypsRVWASR4B6ZDPY7EaDN17XlC00PFyif bOGlznoDHbrbq0GMyXo5TM7SruB23JdVD8GJSgjzfevQOFPeV70Jn/vNQ6SluafN6nVK TA6ta5XDm9Li2hvBkLRaZnkoJ9OthPr019tlXydUpSxFWgkkSq4D/LAaGT11NWzRO81Q tpAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-56359-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56359-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCUI43qUV4U71nCpYK53zaiG6/P+u4iEjY06l/heXwZrKlAf22L4kJX13c6UhfY6HTIUkWRAlwF7jNy5Jp69U51lHyIfnTjAA+l+/vJVEA== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9-20020a170902cec900b001d981d6e0fesi1331073plg.317.2024.02.07.03.09.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 03:09:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56359-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-56359-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56359-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E5A94B22447 for ; Wed, 7 Feb 2024 11:09:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3E3CC18641; Wed, 7 Feb 2024 11:08:58 +0000 (UTC) Received: from mail115-171.sinamail.sina.com.cn (mail115-171.sinamail.sina.com.cn [218.30.115.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D446618054 for ; Wed, 7 Feb 2024 11:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707304137; cv=none; b=KI/XVGZca9jch6+rottVdMEkA+uGDvda0yWMIn/gZiVBjBstIznPPZWqMkpKn9lDiDi28Px4StZdVwNpvWnQJS5+90CvrL1YTs9AiAl2mpC3QTwa8MBhK/+AbJ5Gnzqe+GNRCnIp/VcapW+kRPQgDDtBUZd1Qfv08w+ZUFz/+2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707304137; c=relaxed/simple; bh=fSkGu1grBMmUs+bEAKUTAl8fA3smrFicyaEfve5sDiQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MYSz6InyjvE6rtGbkRXwH5V4lN9IWMPgT8lojH70h7YwXCsSP0NxJBkyf+WKK55u+zPQf3L2sHKS3qdPOurucX7l8mcMFWHz1F8NMvvVTJ4Vw3lR1XNmDnen/mW9/MYHD/QWLZPNqYlRWceoWmKYpwmW/hQLdOG6T4fALXIudho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.69.212]) by sina.com (172.16.235.25) with ESMTP id 65C3649600004B49; Wed, 7 Feb 2024 19:08:08 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 25631334210355 X-SMAIL-UIID: 2A2F7888B4C648ACA50BBE55DBC3BC60-20240207-190808-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [usb?] [media?] possible deadlock in vb2_video_unregister_device Date: Wed, 7 Feb 2024 19:07:56 +0800 Message-Id: <20240207110756.936-1-hdanton@sina.com> In-Reply-To: <0000000000008b96230610c6b3fe@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 07 Feb 2024 00:44:22 -0800 > HEAD commit: ed5551279c91 Merge 6.8-rc3 into usb-next > git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1603629fe80000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing --- x/drivers/media/usb/usbtv/usbtv-video.c +++ y/drivers/media/usb/usbtv/usbtv-video.c @@ -963,11 +963,11 @@ ctrl_fail: void usbtv_video_free(struct usbtv *usbtv) { + usbtv_stop(usbtv); + vb2_video_unregister_device(&usbtv->vdev); mutex_lock(&usbtv->vb2q_lock); mutex_lock(&usbtv->v4l2_lock); - usbtv_stop(usbtv); - vb2_video_unregister_device(&usbtv->vdev); v4l2_device_disconnect(&usbtv->v4l2_dev); mutex_unlock(&usbtv->v4l2_lock); --