Received-SPF: pass (google.com: domain of linux-kernel+bounces-56368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 7 Feb 2024 06:14:29 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Huang Yiwei <quic_hyiwei@quicinc.com>, mhiramat@kernel.org,
 mark.rutland@arm.com, mcgrof@kernel.org, keescook@chromium.org,
 j.granados@samsung.com, mathieu.desnoyers@efficios.com, corbet@lwn.net,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
 quic_bjorande@quicinc.com, quic_tsoni@quicinc.com, quic_satyap@quicinc.com,
 quic_aiquny@quicinc.com, kernel@quicinc.com, Ross Zwisler
 <zwisler@google.com>
Subject: Re: [PATCH v4] tracing: Support to dump instance traces by
 ftrace_dump_on_oops
Message-ID: <20240207061429.3e29afc8@rorschach.local.home>
In-Reply-To: <50cdbe95-c14c-49db-86aa-458e87ae9513@joelfernandes.org>
References: <20240206094650.1696566-1-quic_hyiwei@quicinc.com>
	<50cdbe95-c14c-49db-86aa-458e87ae9513@joelfernandes.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 7 Feb 2024 05:24:58 -0500
Joel Fernandes <joel@joelfernandes.org> wrote:

> Btw, hopefully the "trace off on warning" and related boot parameters also apply
> to instances, I haven't personally checked but I often couple those with the
> dump-on-oops ones.

Currently they do not. It would require an updated interface to do so,
as sometimes instances can be used to continue tracing after a warning,
so I don't want to make it for all instances.

Perhaps we need an option for these too, and have all options be
updated via the command line. That way we don't need to make special
boot line parameters for this. If we move these to options (keeping the
proc interface for backward compatibility) it would make most features
available to all with one change.

-- Steve