Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp235902rdh; Wed, 7 Feb 2024 03:21:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLDGSIyfUsZMEfe8zRKoNYju00/9ngeHqT6WoX9gJPVFbjMbFfkA7G+DgP018szRqbGfZe X-Received: by 2002:a05:6a20:a082:b0:19c:a30b:89e with SMTP id r2-20020a056a20a08200b0019ca30b089emr3159276pzj.16.1707304915891; Wed, 07 Feb 2024 03:21:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707304915; cv=pass; d=google.com; s=arc-20160816; b=PgEv1PNTCUviUt7lwVWFHgfLAQ+IoDE+XHXUnxzGe6V+NRTGO9oKQkQ8/mxJ45G6HT hDGHqdTMk8Hc2Ph/smDQJSiVDsdWiSFdZCx+kP1Idh5gmrxw8LMzjq+Fjkz2KlYS8iRq G3CtQcStcck52etX+o83gLAkqU9pucTmltfUy9Uakg7VlaL6xGhzEbIE/biTTzdel295 PecHn6HXElpJHXWy3OcB1A5XNcf8zvBWteoOCSFzHD+zbBKz62rISaI/TXmjreUGESUQ 2JTnOXcbDIBQBKpRIKT4OCcsj6O9X8tDToH78ygcZAFxsRhStOxh4m8B29FMhoLDR0PG BNrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qZYO+3J0BHmnXIn/Y1EB3ueXfuT+9kPRAY0cW3chaf8=; fh=qTWbWEFYI+w4pVmwoEF0r2CQec2SgtIpDxmi7ConsPw=; b=oXWhqStY90zkFv57wleIbRKF3+Z3dK26LluVE3nbuDAHB6MpVrE0Yacq158iT9J8Tj LRrdGpy1UpqKewuA4qpjqYEbS25uV6utn1X2lZ56fdnCrCp22t33aLvPgaulJr6fBDBF CEcubgwtkwS/MpJZ7AS+gO5M9/GqtB3Fjvr3dzyX/nsUP5R1QTTol6nRGDBI0FlYlkCT bke/1sSkTgld6LbJveHSUI4b6zwpeEsW88Axp5eO6mdWCbGLDQEjaxdZ2UUPihVe7+qn UfV7XOrsvStBh8U/s0AobgkWCFHBmNkx3jJ0t7PdWU1Sz1ftPIE6E+FIgUervAh0HFvd qBoQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N4RlBcm6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56379-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56379-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXiIK6h1myK+D7LvImr7on0el44VLZzvHYmEeDJQCY6jctorX5Sx9atsWh8/5tSiuHNW+0F2IttIl2R+vIhXDoh2EqQN+Ax0HZM1oITkQ== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id c19-20020a637253000000b005dbe215856dsi1326169pgn.765.2024.02.07.03.21.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 03:21:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56379-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N4RlBcm6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56379-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56379-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 689C9B22988 for ; Wed, 7 Feb 2024 11:18:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D46718EBF; Wed, 7 Feb 2024 11:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N4RlBcm6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A1451B7F2; Wed, 7 Feb 2024 11:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707304683; cv=none; b=fz2FVUbVQCQ1ITolVXwXeM9HkaZDuSgL8iww70LLCk/YVm6mpOnqOJNz14G09ZFgMwnzeAR4TLR3xpvCR/myT7kvoKl6CFbbrNigkblmhl8kJZ/nYPY60Yudc+va+CUxxQpw7QYKcwoXKfLra2MgB/0QmgrDVFP97KvuJyIsmTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707304683; c=relaxed/simple; bh=xmiZrYRxLnJlnMLs1bZ4Gdpk1VKKRQZbSJyawdxBg30=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVUc6Lc+cDxpOtIFk1ROOkrP+yEgZU/nqT8eFGoQ2bv1pFFyyFw4urebSRllJ/RtJ0icIuIqoNzt6dVR5dK+zJ655hZlgD7ncMxnwxH2celFSUv9DxP4z8qxECUlLiKwUqJDwZ0SoHkg9YJUJ/gzYf5Yk5rlvfFM4htGcmfU/LM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N4RlBcm6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A991C43394; Wed, 7 Feb 2024 11:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707304682; bh=xmiZrYRxLnJlnMLs1bZ4Gdpk1VKKRQZbSJyawdxBg30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N4RlBcm6dAq3HbU103w7LDHctDPZJ/A8mrPOOzknAc/IoNpn0MGDFReBWJBgbf5rY 2NgOh7VGW9R7sIiqoF/V87FlQzDrRqnjtJrwlqM5CWOSc0UPEzjor8wjbxOs+4eYeh j9saer13C5rihh9KUB46DWxQfCzebqD+QFp5+FdxmdzkhiMKmXfRlTpCWhmqbzuNi6 pxb5FtpD5+2LBEJztmOygFoV83cGh1ZMtOdjIzYkPJT4AmyE5aiGqwVdBS6JzUuLZj MidgtNbdRApMmMQccuuuXh0ph5Bi8it4K0BnUAA1kwLKZ/3lcCrlIhgK14Up0LtQbQ W5t3DAzU5ij5A== Date: Wed, 7 Feb 2024 12:17:58 +0100 From: Christian Brauner To: Oleg Nesterov Cc: Tycho Andersen , "Eric W . Biederman" , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH v2] pidfd: getfd should always report ESRCH if a task is exiting Message-ID: <20240207-unvorbereitet-drama-27d6b5f7c877@brauner> References: <20240206192357.81942-1-tycho@tycho.pizza> <20240207-vibrieren-waldarbeiten-30eeade05203@brauner> <20240207-daran-fliesen-6039a2e36f39@brauner> <20240207-blumen-neulich-f1507e0c5cc0@brauner> <20240207103201.GB6627@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240207103201.GB6627@redhat.com> On Wed, Feb 07, 2024 at 11:32:01AM +0100, Oleg Nesterov wrote: > On 02/07, Christian Brauner wrote: > > > > So this is what I have applied currently where I moved the check into > > __pidfd_fget() where it makes more sense imho. But please double check > > that I didn't mess anything up: > > LGTM. > > You have already applied this patch, no need to add my ack, but FWIW > > Reviewed-by: Oleg Nesterov Added. Thank you!