Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp246156rdh; Wed, 7 Feb 2024 03:45:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGP6I5f8TQ+r2O86tOMJobGJPNLrAhokPnwvy0AYAsEJHGx11nZcfDT9kGkFuR4f8eqHEA3 X-Received: by 2002:a17:907:3e20:b0:a38:8441:1e1b with SMTP id hp32-20020a1709073e2000b00a3884411e1bmr973520ejc.7.1707306333367; Wed, 07 Feb 2024 03:45:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707306333; cv=pass; d=google.com; s=arc-20160816; b=bzGEEF2BsnkxFcOSmjT+e3FDpEio2mDAK+5jjgUw8v0bKeyuDrruOsJE9Um5RCtZmb jW9RoQgYePQj4qxubIepov7wlgaEEbSjNDGg/I4DfxCqEUMxGQ0VnT1mUvF05dIDbINf ZCOrw0WtLDQsf2YqNn+yVzEYjyPecSKscG8+xrciWaR90QkqSCFhb6atHDSYOS2e/QGV crQh4mzUHw8e+o0+4kee1JLwkHnqCpKy933banbj+2Jw45/T5ydou2gjZ1p8CWqILR8m 40hzY7sQ9gVvo2re4LCMiHH734UMVMicBYmP5M1s1OsO1i5n7e7+F0FCvLs0vHZdqNIj CMWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=tGARMROwJ5G1/f5ZHurQ91O4l11qnnAZTefHl3wwVJI=; fh=HRthxLeEqlMsI4IREyVc0p9SbTzVyOo5SEjc0GUIuWY=; b=gd3ZLzH8QbyfhwzEzhXo4knfsvv/jGQcQEasVNR33wCoBRdW/iK89cjLHi/0lppINk k7+o9t3YGLYSSjSUlVIZyJ647cp/seSgKmvoHL7ymbmyJj81bz27d1AznPb9CfSvVeHx 7E0WMVTTRhCFwT+I616h1Pu5kYH764/GM1jCUsrf7S29otxBIOZ9KVgBCIAAasNGs3ds zLurFTvX4I5+LCEB4pQ/CRoDn0B81cUHMuMEd2bRzavSIE3o2EZ38Ta4NYy7sgFHfBX6 vk4xCsoqJuCPxiIAfw51oq6NPQNTbr6P37Nv9feUa6xWNAaCQ+DZcfAOY414Ffr0RUJr Mttg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-56414-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56414-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVqcXGLUtq/SlQ7lNiIo4VLElbJrnqg7pWT+SVkXoMtwxZaT1874rzDkj7Tcxi7pdhwssUhYXzpa1BgIJT6ht3zjg+Q4lQl7zYxSqMpjw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id k26-20020a1709065fda00b00a37bc6b8154si855356ejv.439.2024.02.07.03.45.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 03:45:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56414-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-56414-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56414-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 20BAF1F2380D for ; Wed, 7 Feb 2024 11:45:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8F63D1B811; Wed, 7 Feb 2024 11:45:24 +0000 (UTC) Received: from mail115-95.sinamail.sina.com.cn (mail115-95.sinamail.sina.com.cn [218.30.115.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7491B7E4 for ; Wed, 7 Feb 2024 11:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707306324; cv=none; b=WKZPq3MIO/8Mki84kW0rVa7+rh10sPu1cBrY527bmTpKLL5POt6dn9w9IC4pl18P/spQkBVOoCRenhP0NFOBnWzxSOmVrW/GgHY9D87QCn+jos2Ky5JtvDgjz1/+ZLpQh9g+D0v/quFLgCCbOkjqQo1xBgACT0YOFqfLa93m0c0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707306324; c=relaxed/simple; bh=stlP0vmieVdfUXs897eV+2lDHbI2JnfyviKh7jFm2EM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Fkj52+2NzBr6q1XqQ+k4ycgCK5IuYqNBVDDKGurfGGFNcjCTAz1dKL4yN9b6PYw1aVu0ZOaOyGOfyaynmAQb5LW9jt62EqA3xQa6idDnfwSydu7viQa3UFiDKx4GEN4VgffA4X+dlW+RkGB1A6ME7tPhdG1budhgpsrBgtyCp4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.69.212]) by sina.com (172.16.235.24) with ESMTP id 65C36D43000042CF; Wed, 7 Feb 2024 19:45:10 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 40857945089154 X-SMAIL-UIID: 8F64AA2310FE48E6B16A23EFFA41A0FA-20240207-194510-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [xfs?] INFO: task hung in xfs_inodegc_flush Date: Wed, 7 Feb 2024 19:44:59 +0800 Message-Id: <20240207114459.1057-1-hdanton@sina.com> In-Reply-To: <00000000000088268a0610c6b3ae@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 07 Feb 2024 00:44:21 -0800 > HEAD commit: 076d56d74f17 Add linux-next specific files for 20240202 > git tree: linux-next > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13811004180000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 076d56d74f17 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1999,6 +1999,8 @@ static int try_to_grab_pending(struct wo */ pwq = get_work_pwq(work); if (pwq && pwq->pool == pool) { + unsigned long work_data; + debug_work_deactivate(work); /* @@ -2016,11 +2018,12 @@ static int try_to_grab_pending(struct wo list_del_init(&work->entry); + work_data = *work_data_bits(work); /* work->data points to pwq iff queued, point to pool */ set_work_pool_and_keep_pending(work, pool->id); /* must be the last step, see the function comment */ - pwq_dec_nr_in_flight(pwq, *work_data_bits(work)); + pwq_dec_nr_in_flight(pwq, work_data); raw_spin_unlock(&pool->lock); rcu_read_unlock(); --