Received-SPF: pass (google.com: domain of linux-kernel+bounces-56508-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ZcKk6QJXfGGo2DH9@pengutronix.de>
References: <ZcFx7P30Su_Mx4AV@pengutronix.de> <20240206032301.6e4tmbvmk7vs72gg@synopsys.com> <ZcKk6QJXfGGo2DH9@pengutronix.de>
Subject: Re: duplicate requests on host side while streaming via uvcvideo gadget
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>, linux-usb@vger.kernel.org <linux-usb@vger.kernel.org>
To: Michael Grzeschik <mgr@pengutronix.de>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Date: Wed, 07 Feb 2024 13:04:48 +0000
Message-ID: <170731108881.252503.6282895768429052406@ping.linuxembedded.co.uk>
User-Agent: alot/0.10

Hi Michael,

Quoting Michael Grzeschik (2024-02-06 21:30:17)
> On Tue, Feb 06, 2024 at 03:23:17AM +0000, Thinh Nguyen wrote:
> >On Tue, Feb 06, 2024, Michael Grzeschik wrote:
> >> Hi Thinh
> >>
> >> I found some strange situation while streaming via uvc-gadget to some
> >> usb host. It happens when some requests are missed due to higher load =
on
> >> the gadget machine. In some cases some requests will reach the host
> >> twice. In my special case, I added the following changes [1] for the
> >> host and gadget side.
> >
> >Does this only happen to some specific hosts?
>=20
> >Are all the data of the duplicate requests matching or just some bits of
> >the transfer? Were you able to confirm from some usb analyzer/sniffer
> >that the data out the wire is actually duplicate?
>=20
> Turns out, this duplicates are just misinterpretations.

I'm glad there's no deeper issue to worry about here.

> The linux uvcvideo driver will parse the uvc header payload twice. (If
> the FID was incremented inbetween). This led to those double misleading
> outputs. Although this means that there is a bug in
> uvc_video_stats_decode for incrementing the error count.

Do you plan/are you able to submit a patch to fix this?  Hopefully that
would prevent anyone else following the same rabbit-hole.

--
Kieran


>=20
> Anyway, so just ignore this whole thread and be thanked for even having a=
ny
> thoghts on this.
>=20
> Regards,
> Michael
>=20
> --=20
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |