Received-SPF: pass (google.com: domain of linux-kernel+bounces-56546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b19c4280-df54-409e-b3fd-00de6d6958d4@gmail.com>
Date: Wed, 7 Feb 2024 15:23:47 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] eth: mlx5: link NAPI instances to queues and
 IRQs
Content-Language: en-US
To: Joe Damato <jdamato@fastly.com>, Tariq Toukan <tariqt@nvidia.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
 Gal Pressman <gal@nvidia.com>, rrameshbabu@nvidia.com,
 Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 "open list:MELLANOX MLX5 core VPI driver" <linux-rdma@vger.kernel.org>
References: <20240206010311.149103-1-jdamato@fastly.com>
 <7e338c2a-6091-4093-8ca2-bb3b2af3e79d@gmail.com>
 <20240206171159.GA11565@fastly.com>
 <44d321bf-88a0-4d6f-8572-dfbda088dd8f@nvidia.com>
 <20240206192314.GA11982@fastly.com>
From: Tariq Toukan <ttoukan.linux@gmail.com>
In-Reply-To: <20240206192314.GA11982@fastly.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 06/02/2024 21:23, Joe Damato wrote:
> On Tue, Feb 06, 2024 at 09:10:27PM +0200, Tariq Toukan wrote:
>>
>>
>> On 06/02/2024 19:12, Joe Damato wrote:
>>> On Tue, Feb 06, 2024 at 10:11:28AM +0200, Tariq Toukan wrote:
>>>>
>>>>
>>>> On 06/02/2024 3:03, Joe Damato wrote:
>>>>> Make mlx5 compatible with the newly added netlink queue GET APIs.
>>>>>
>>>>> Signed-off-by: Joe Damato <jdamato@fastly.com>

..

> 
> OK, well I tweaked the v3 I had queued  based on your feedback. I am
> definitiely not an mlx5 expert, so I have no idea if it's correct.
> 
> The changes can be summed up as:
>    - mlx5e_activate_channel and mlx5e_deactivate_channel to use
>      netif_queue_set_napi for each mlx5e_txqsq as it is
>      activated/deactivated. I assumed sq->txq_ix is the correct index, but I
>      have no idea.
>    - mlx5e_activate_qos_sq and mlx5e_deactivate_qos_sq to handle the QOS/HTB
>      case, similar to the above.
>    - IRQ storage removed
> 
> If you think that sounds vaguely correct, I can send the v3 tomorrow when
> it has been >24hrs as per Rahul's request.
> 

Sounds correct.
Please go on and send when it's time so we can review.