Received-SPF: pass (google.com: domain of linux-kernel+bounces-56549-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
 "Limonciello, Mario" <Mario.Limonciello@amd.com>,
 "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
 "Huang, Ray" <Ray.Huang@amd.com>,
 "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
 "Petkov, Borislav" <Borislav.Petkov@amd.com>,
 "Yuan, Perry" <Perry.Yuan@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
 "Huang, Shimmer" <Shimmer.Huang@amd.com>,
 "Du, Xiaojian" <Xiaojian.Du@amd.com>,
 "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject:
 Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for
 passive mode
Date: Wed, 07 Feb 2024 14:27:29 +0100
Message-ID: <5065083.31r3eYUQgx@natalenko.name>
In-Reply-To:
 <CYYPR12MB8655B6D156512E187F2A736B9C452@CYYPR12MB8655.namprd12.prod.outlook.com>
References:
 <cover.1707297581.git.perry.yuan@amd.com> <2887380.mvXUDI8C0e@natalenko.name>
 <CYYPR12MB8655B6D156512E187F2A736B9C452@CYYPR12MB8655.namprd12.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart4713795.LvFx2qVVIh";
 micalg="pgp-sha256"; protocol="application/pgp-signature"

--nextPart4713795.LvFx2qVVIh
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Oleksandr Natalenko <oleksandr@natalenko.name>
Date: Wed, 07 Feb 2024 14:27:29 +0100
Message-ID: <5065083.31r3eYUQgx@natalenko.name>
MIME-Version: 1.0

On st=C5=99eda 7. =C3=BAnora 2024 14:17:06 CET Yuan, Perry wrote:
> [AMD Official Use Only - General]
>=20
> Hi,
>=20
> > -----Original Message-----
> > From: Oleksandr Natalenko <oleksandr@natalenko.name>
> > Sent: Wednesday, February 7, 2024 6:11 PM
> > To: rafael.j.wysocki@intel.com; Limonciello, Mario
> > <Mario.Limonciello@amd.com>; viresh.kumar@linaro.org; Huang, Ray
> > <Ray.Huang@amd.com>; Shenoy, Gautham Ranjal
> > <gautham.shenoy@amd.com>; Petkov, Borislav
> > <Borislav.Petkov@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>
> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Shimmer
> > <Shimmer.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Meng,
> > Li (Jassmine) <Li.Meng@amd.com>; linux-pm@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost
> > callback for passive mode
> >
> > Hello.
> >
> > On st=C5=99eda 7. =C3=BAnora 2024 10:21:57 CET Perry Yuan wrote:
> > > With new freqency boost interface supported, legacy boost control
> > > doesn't make sense any more which only support passive mode.
> > > so it can remove the legacy set_boost interface from amd-pstate driver
> > > in case of there is conflict with new boost control logic.
> > >
> > > Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> > > ---
> > >  drivers/cpufreq/amd-pstate.c | 1 -
> > >  include/linux/amd-pstate.h   | 1 -
> > >  2 files changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/amd-pstate.c
> > > b/drivers/cpufreq/amd-pstate.c index 35791efc6e88..1dd523db3871
> > 100644
> > > --- a/drivers/cpufreq/amd-pstate.c
> > > +++ b/drivers/cpufreq/amd-pstate.c
> > > @@ -1675,7 +1675,6 @@ static struct cpufreq_driver amd_pstate_driver =
=3D
> > {
> > >     .exit           =3D amd_pstate_cpu_exit,
> > >     .suspend        =3D amd_pstate_cpu_suspend,
> > >     .resume         =3D amd_pstate_cpu_resume,
> > > -   .set_boost      =3D amd_pstate_set_boost,
> > >     .update_limits  =3D amd_pstate_update_limits,
> > >     .name           =3D "amd-pstate",
> > >     .attr           =3D amd_pstate_attr,
> > > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> > > index 465e9295a60c..ab7ca26974da 100644
> > > --- a/include/linux/amd-pstate.h
> > > +++ b/include/linux/amd-pstate.h
> > > @@ -93,7 +93,6 @@ struct amd_cpudata {
> > >     struct amd_aperf_mperf prev;
> > >
> > >     u64     freq;
> > > -   bool    boost_supported;
> >
> > As a result of this removal the kernel-doc for this struct should be am=
ended
> > too because even after this patch is applied the `boost_supported` field
> > remains documented.
>=20
> The set_boost is callback used by cpufreq.c, the boost_supported is not d=
ocumented before the patch.
> We just need to add new sysfs "cpb_boost" introduction in the "/Documenta=
tion/admin-guide/pm/amd-pstate.rst"
> The legacy boost is not supported any more, we have no need to document i=
t again as it is.

`boost_supported` as a field of `struct amd_cpudata` is documented in the k=
ernel-doc right before the structure, and this bit should be removed like s=
hown below:

```
=2D-- a/include/linux/amd-pstate.h
+++ b/include/linux/amd-pstate.h
@@ -56,7 +56,6 @@ struct amd_aperf_mperf {
  * @cur: Difference of Aperf/Mperf/tsc count between last and current samp=
le
  * @prev: Last Aperf/Mperf/tsc count value read from register
  * @freq: current cpu frequency value
=2D * @boost_supported: check whether the Processor or SBIOS supports boost=
 mode
  * @hw_prefcore: check whether HW supports preferred core featue.
  * 		  Only when hw_prefcore and early prefcore param are true,
  * 		  AMD P-State driver supports preferred core featue.

```

> Perry.
>=20
> >
> > >     bool    hw_prefcore;
> > >
> > >     /* EPP feature related attributes*/
> > >
> >
> >
> > --
> > Oleksandr Natalenko (post-factum)
>=20


=2D-=20
Oleksandr Natalenko (post-factum)
--nextPart4713795.LvFx2qVVIh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEZUOOw5ESFLHZZtOKil/iNcg8M0sFAmXDhUEACgkQil/iNcg8
M0viNA/+JgIrXfN2tea1g1fTzeFTG6W846DHmLLtTYZNsXjvObcK63bHl/Mr4dZp
4DiU49PMjfueTC8Smmt94hFJ0DjLJWMhK/IRQXvyUzMQG78FwFRjbE70rTfz96TQ
vwj1i95YcaPkgkBQUJFAFIOs/NONm4VjbpMMoXp0n3tqirMGArwxJVUXxZ+SkqDb
yioZ3Bq8o4qTeBd+A89XCNk1KKiGAtvRyuZMR1x0HUYdXyXG5ptIjkNe5DDtaMet
hacyeaubCgQw2+3i1t+EvYTnNjfgJG1HIiYslyrz0VvNv0VjhWx1Iql7LY1HHwR5
+W3eX/A6zwNuOCfmFitU9XgsN6yqKeuiATz8oCNJOjOVs+G7YZtqV0GNuF1Oq8RP
nnHKfXPEsDNY653ITys6HNNz0e2GH4Z3ocyRFJEn6MWxvukEjZSzDa0FjiIp78Hs
q/+/HaA3BDqJwNrTrcS3GzO5fnnTqFjtaki7gFvEAA33uMbDtTX9utWxqdSAENEd
InTrlrpl2GFjdEn0jbIKOpHqEovCYnObw4eR8AJeO+htCKSTApVTPTI2p5I4Ap9f
jnHaleyKPom4yI92o7gIKTPRaB706HgzY1PSwQy1O/LtrWe+zHsHEYYLB0JBm3Gv
L0a/T4FZE9p4Higm3IpLrf4Nlo3iZX/7TlxQtbmm1iByx+ZRMSE=
=W5i2
-----END PGP SIGNATURE-----

--nextPart4713795.LvFx2qVVIh--