Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp310048rdh; Wed, 7 Feb 2024 05:38:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCw2TpGAvcI2OZGms6ynHyDCKTwbuLmoM8ZQPJfW0YNhXEgTQ2x2R4AEMDB7usmQrS1Hkt X-Received: by 2002:a17:906:3d31:b0:a38:3282:baf0 with SMTP id l17-20020a1709063d3100b00a383282baf0mr3599135ejf.75.1707313119586; Wed, 07 Feb 2024 05:38:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707313119; cv=pass; d=google.com; s=arc-20160816; b=I5KuRtXf4ZvjN0w54IpiNaT7DmTGulnmGLb71mDIhOdcRmu26GahT9Y9lhLcZHXvpv HLnTNm+l3ePzdfeFL6wFatC5cWVI5y6GoqdlmEXbgWyf4+E7DPk6y+s04gs0S0iw6pxc tWrePvRmhkdWlkiHqkz/BcNTpcNqJLJ//b8sMxFEoU8qFgk2rNQtYcL3BsGMZvoD7AJw btxEGgnbX7kKdNhQ1HcQHlUBt/PNEIvjreK/M9nSmUI+y/fyefS5Y50yKn6+Ky13r/f2 f7FeMWPm4JOXv3zikSzAhN2EvoAgqhRyipJjaaQllxEA0rXTKghdS+jHenxNx4EGMnPT UIBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:feedback-id:dkim-signature:dkim-signature; bh=Uwv/WJmwhyfFa3neNLcSwsw2I11UAjibajrmPfs5/Gg=; fh=ohV9080tew2sJtvm6cGt82LZzWUrjCSVpK81tMxpw04=; b=KmDfeG1hu+9lY7LIZeP10XSg0oR/w23vyjAdWSkfVLZCOiUArjewX86GvWu0kD4f73 rogj8jbrVcWYsF80Qff7g/exvkh79+ah1n0KtgRjnrYmvajDXkJURy/NXqKlKDrZK9ie crdeUUWz5+KwuDpznnDEXuReTaqikYb1orYYFB1s9Rpf8YgzAEo2+r/HKiiOvJ9E7ewa 21227gWhjoOqA/R+zLhQ77uIx5b7oGjNhmb0sUKixCa08Muc4XGsuJh2rTCa13r/xdeQ uJ471BL8JpxlJ3zfBUGYKwVjbmxwqHGTNbH+7OWRWTm67OtIC+SRS4pEgq/3jGawlIJp ZmCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tycho.pizza header.s=fm2 header.b=2ovkCmc7; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Z+fRcucR; arc=pass (i=1 spf=pass spfdomain=tycho.pizza dkim=pass dkdomain=tycho.pizza dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-56557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56557-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCW8YhIljgqTMf2bW95y+NdbVwjqCrj37HDcCEtFG9gO/V9g1tLpYGnge/KpQS9EarFg8zXJ5VCWGNFQB58tFg153HayCV+f7cAxQkHDfw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x12-20020a1709064a8c00b00a38460f719csi946471eju.216.2024.02.07.05.38.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 05:38:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tycho.pizza header.s=fm2 header.b=2ovkCmc7; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Z+fRcucR; arc=pass (i=1 spf=pass spfdomain=tycho.pizza dkim=pass dkdomain=tycho.pizza dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-56557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56557-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3C4A11F2244B for ; Wed, 7 Feb 2024 13:38:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DAA0A77644; Wed, 7 Feb 2024 13:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tycho.pizza header.i=@tycho.pizza header.b="2ovkCmc7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Z+fRcucR" Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61B583C062; Wed, 7 Feb 2024 13:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707313111; cv=none; b=OzSaAbysqI/DY33mZoEp+Wst2Ia5+zi7YMquaorHlbnlr+/YQaq8kwpSiYXqajRLjL+YCjnMsdIRIGXQfwzWeLp/tRBemf1l21NzXWIOp6tp196B95Qf67JaIwdgxFQ5qUIIjGSaN+DER2uFxPKfIRj6dD8jhSc2psgEMOZiY+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707313111; c=relaxed/simple; bh=Uwv/WJmwhyfFa3neNLcSwsw2I11UAjibajrmPfs5/Gg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tF0v/Vz2VL9mI3xUGQ3jS7Mr6iWM+rV/U6LGD02wB/ALS//cMfxnQA54duh9fikeEddiLqaJQuo8ekrzF218iEuZRX9hKSjURiath0+ZqAe7lpj/Ui+h1Q5MFHi5hHR5by5xMBXTLVvUAsL+oTHMMn6AWy7H/P5pMCwVeqCiCrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza; spf=pass smtp.mailfrom=tycho.pizza; dkim=pass (2048-bit key) header.d=tycho.pizza header.i=@tycho.pizza header.b=2ovkCmc7; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Z+fRcucR; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tycho.pizza Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 2E70713800A2; Wed, 7 Feb 2024 08:38:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 07 Feb 2024 08:38:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707313108; x=1707399508; bh=Uwv/WJmwhy fFa3neNLcSwsw2I11UAjibajrmPfs5/Gg=; b=2ovkCmc7b3vweBJqbF0JUDKVOV UCWiNDfPA3olqR8WShz32FyTUwtdjnD2mIRt2M4BjytuRTMOeikE4QT12/BfEQcn mHjRr4qdKQMSqV78ZkM2/mM6t/jyQPl4eV1tXf9wov3SiRphaU/nkbAJC6oyMWtv HOrAlTFkMn4Em2UDOhr/AVNxMakdwdJZ4luUpMkPs0CoInG+VZYPWqQhYiABQd14 IXOTvj6J/T/Va5bIb6MeNprd3ErfuC5UERvvCY109Q3JZaRCra6FfTL5ALWwy6ft Wo6swmJel4HXfkFSyEooRLkAO+v2OObjIM5jncuWXPKqZRIv9jlD3SeL5YMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707313108; x=1707399508; bh=Uwv/WJmwhyfFa3neNLcSwsw2I11U AjibajrmPfs5/Gg=; b=Z+fRcucRzmYBfCUoA0Sm14AV+itHbpEugXzpXfUC+rQ8 mOpJrtW/kTv4VNAas4Z13zQtpjk2DcDrdJ0a01jUfR0L3Vbr6vB2O/F3R6K5h/tv SjYrOSc7KgJaFaGJWQ6tYr93WJtFE7kKLS2FZEI66a5SjYayjBgQugJlV3b/QCf1 Xc48mRCi+fZ2WS0PUDPgENm4oufo/CkduwHaDHzVO+/nkLQLLPU45+L3dnEzxKXe +QTubQjZ0tExnCz4OKjf9yNryA2bEpfyeyxIpc0T0DCPIIBGnVCq7UFBuBYUKx9l DYnZiQr+2UJ5xFf3Mom6Y8im/11T+D1iubst+iR91Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddvgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvhigthhho ucetnhguvghrshgvnhcuoehthigthhhosehthigthhhordhpihiiiigrqeenucggtffrrg htthgvrhhnpeeutedttefgjeefffehffffkeejueevieefudelgeejuddtfeffteeklefh leelteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthigthhhosehthigthhhordhpihiiiigr X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Feb 2024 08:38:26 -0500 (EST) Date: Wed, 7 Feb 2024 06:38:24 -0700 From: Tycho Andersen To: Christian Brauner Cc: Oleg Nesterov , "Eric W . Biederman" , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH v2] pidfd: getfd should always report ESRCH if a task is exiting Message-ID: References: <20240206192357.81942-1-tycho@tycho.pizza> <20240207-vibrieren-waldarbeiten-30eeade05203@brauner> <20240207-daran-fliesen-6039a2e36f39@brauner> <20240207-blumen-neulich-f1507e0c5cc0@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207-blumen-neulich-f1507e0c5cc0@brauner> On Wed, Feb 07, 2024 at 10:50:26AM +0100, Christian Brauner wrote: > So this is what I have applied currently where I moved the check into > __pidfd_fget() where it makes more sense imho. But please double check > that I didn't mess anything up: Oof, good catch. Looks good to me. Thanks, Tycho