Received-SPF: pass (google.com: domain of linux-kernel+bounces-56581-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 7 Feb 2024 13:49:34 +0000
From: Greg KH <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpio: set device type for GPIO chips
Message-ID: <2024020723-arbitrary-harmful-53c3@gregkh>
References: <20240201162758.50733-1-brgl@bgdev.pl>
 <CACRpkdbAw5NfSr8GSNiQhOzSi-tERyn=-ZroLfF-FRbsW2JviQ@mail.gmail.com>
 <2024020732-duchess-husband-8b1b@gregkh>
 <CAMRc=MeWD-4xx9Y=P3ajO37XJAsBrZ2TyqNeCE8vkxXW1yXWVQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMRc=MeWD-4xx9Y=P3ajO37XJAsBrZ2TyqNeCE8vkxXW1yXWVQ@mail.gmail.com>

On Wed, Feb 07, 2024 at 01:19:37PM +0100, Bartosz Golaszewski wrote:
> On Wed, Feb 7, 2024 at 11:49 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Feb 07, 2024 at 11:45:39AM +0100, Linus Walleij wrote:
> > > On Thu, Feb 1, 2024 at 5:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > It's useful to have the device type information for those sub-devices
> > > > that are actually GPIO chips registered with GPIOLIB. While at it: use
> > > > the device type struct to setup the release callback which is the
> > > > preferred way to use the device API.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > (...=
> > > > +static struct device_type gpio_dev_type = {
> >
> > Can you make this structure const please?
> >
> 
> I have, there's a v2 on the list already.

Great, let me go dig that up and do a review...