Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp316774rdh; Wed, 7 Feb 2024 05:51:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5UmUdX77sBHP+NrKdeRaE8tfDyOY9hpTlG1dLmH64rFmVMoRCx1kRxsl/ivfP4my0ql5Z X-Received: by 2002:a05:6808:384b:b0:3bf:ee86:6ecc with SMTP id ej11-20020a056808384b00b003bfee866eccmr1563839oib.34.1707313864248; Wed, 07 Feb 2024 05:51:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707313864; cv=pass; d=google.com; s=arc-20160816; b=FI1wszWjvMo0OfaA157DoPNla5qEzYigmBmhyqTiDXRptDb8gkb/40/A3WFyCWTRwL zxS7mHjrvXnQluY5fAyWp++VBFpgoSXmulApp764DabdE/mGMRu2u7aVSn3D/qSW34My kvMBQfO/3FLievbxJ6i4pWO+ZpOFnTj3rCyHeI83aDSdoAwKwGDUrykA1AQIcNg6YFUW njqV72Hd5R1+crQZvG8oAMAt3AZnbqKvmkjhbcNAhBZ+5AWbJDsXRc35ZVQSe55Ib7y2 eggQBgcLuMlr3jnzJyYF65rPpL6iyALWs5otltOwqgcvPbAqZR1RKIK+QsEWHGQyHv9Z aC9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=JlakNdSdjpymzVj6r977DOdnguJBAVAgJvVlaPKXIko=; fh=xigCmSHEJR99mboA/qF9j5C9m7+2GC/czqZ1mCm2le0=; b=fAeSPILFX1vkqlguSSpTgT4P+ZfWscPPQW4n72/UiLKNkXJwlEvmnX4qjHBeMXkqn4 TWh/ci97T+d/3ATmjn+xZaPoGfufsneiMazkWFSIpzfGwH/6Sa/tCB7YfpJD0lz3zfvi Sgt8S8w4hNrah49wCsNbMjMnoc7upiFcfuc9u9/5g50wUkspCfa6wsGe0/RiWR8aTiL8 U0K95JMdJfurZ8GBAtN7KTr2mde6YDFSx6EOO99ZZywmOKwRRGUc7LCNuUcrXBeIBoKc XNYtjVaNsUHqZd4Ve4epCjLv81orskaAJTWe+IoABIBjFr1Up4jEgsoI5Pxc8b0wSHBU kMMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="sdUhc/Sj"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="sdUhc/Sj"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=8UqOy8GD; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-56576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56576-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCXjLVhjQBWcVVBpHkD3NBDtyjYA7KgYHB5/9aYos2wfiLJFMWnT7MVJw+GShhiboSRLElloyn8ys8wm9kLkRklRFRh0/j7x/vBNaLZvzg== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r25-20020a638f59000000b005d8e22b5258si1480291pgn.879.2024.02.07.05.51.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 05:51:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="sdUhc/Sj"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="sdUhc/Sj"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=8UqOy8GD; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-56576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56576-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3DCE8B239D7 for ; Wed, 7 Feb 2024 13:44:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 365647C08D; Wed, 7 Feb 2024 13:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sdUhc/Sj"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8UqOy8GD"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sdUhc/Sj"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8UqOy8GD" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 721987993D; Wed, 7 Feb 2024 13:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707313347; cv=none; b=a6Rr8w0eFkSX1u2TzOf0RXXo2eJseveOzRYH00Z3S/zzl9fb7N4XQRCb95yI0bl6ml1kouU4eguvVj9pDpN23iuFiF67qlrKyJ1P4BMRa2+Yysm7dY/Y0Slmg1lXa7mls+1JPzRz5EgTfnKJEtjr5jlEj6oz7eHIjpLK1rBZpns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707313347; c=relaxed/simple; bh=biTnfIR0P6z4A+HuIjLWtAZ/odQWEGrcuiQOu0E4WKo=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=gSXvH577EFNTR1JGR1r55AP1GkmjMsYrOCKqMzsuEiTD9ltWUiIeJbAaFK6RlWl8rLgwRUOKip+vEC/1bpHSMGrjc+f4wVzRNKupcpElz7S80gbO8Ctg/D6kHMWUaYEyE98bTrQ01O+K4r1nWdpHiTq9b2q5WTUE42T7gpa2IQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sdUhc/Sj; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=8UqOy8GD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sdUhc/Sj; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=8UqOy8GD; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 91B541FC04; Wed, 7 Feb 2024 13:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707313343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlakNdSdjpymzVj6r977DOdnguJBAVAgJvVlaPKXIko=; b=sdUhc/Sjbs2A0k+Pym4m6CwUvQKkyCQ2hR7gijqD2Jc+t4xUru8lwzYaK0+9gU5SJpZdFl 1NrLD8Qw72bJPWxhCPW2qENFySj27/dUgjVvcK3QxjkplpwkhLBX2x+5nyN4YXrEKRtoF/ 8nMuvnOUpTi4+AQJwjCRnnDeiWWYNSE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707313343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlakNdSdjpymzVj6r977DOdnguJBAVAgJvVlaPKXIko=; b=8UqOy8GDOjAR3qhJOSFIw2RfUbNLFOPvXVz+l/jqZAy0+eTi6TXvKkvJO4Z1CsjwAfbmtR Ut0XkK7Lu8XxmMAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707313343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlakNdSdjpymzVj6r977DOdnguJBAVAgJvVlaPKXIko=; b=sdUhc/Sjbs2A0k+Pym4m6CwUvQKkyCQ2hR7gijqD2Jc+t4xUru8lwzYaK0+9gU5SJpZdFl 1NrLD8Qw72bJPWxhCPW2qENFySj27/dUgjVvcK3QxjkplpwkhLBX2x+5nyN4YXrEKRtoF/ 8nMuvnOUpTi4+AQJwjCRnnDeiWWYNSE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707313343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JlakNdSdjpymzVj6r977DOdnguJBAVAgJvVlaPKXIko=; b=8UqOy8GDOjAR3qhJOSFIw2RfUbNLFOPvXVz+l/jqZAy0+eTi6TXvKkvJO4Z1CsjwAfbmtR Ut0XkK7Lu8XxmMAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 477DB139B9; Wed, 7 Feb 2024 13:42:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id EOvzD7+Iw2WdHwAAD6G6ig (envelope-from ); Wed, 07 Feb 2024 13:42:23 +0000 Date: Wed, 07 Feb 2024 14:42:22 +0100 Message-ID: <87o7cs5r29.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?Jean-Lo=EFc?= Charroud Cc: Takashi Iwai , Stefan Binding , Jaroslav Kysela , Takashi Iwai , Richard Fitzgerald , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD In-Reply-To: <726559913.576332068.1707239153891.JavaMail.zimbra@free.fr> References: <726559913.576332068.1707239153891.JavaMail.zimbra@free.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [2.07 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-0.33)[75.89%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[free.fr]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[linux]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; FREEMAIL_TO(0.00)[free.fr]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Level: ** X-Spam-Score: 2.07 X-Spam-Flag: NO On Tue, 06 Feb 2024 18:05:53 +0100, Jean-Lo?c Charroud wrote: > > Fix device ID for "ASUS UM3402" and "ASUS UM6702RA/RC". > Add _DSD values for "ASUS UM3402" to cs35l41_config_table[]. So far, so good, but... > Reorder alc269_fixup_tbl[] by device id and remove duplicate QUIRK > entry for device {0x1043, 0x1f62, "ASUS UX7602ZM"}. Don't mix up multiple things in a single patch. The sort of the existing entries has little to do with your change. Leave it to another patch instead (with Fixes tag for the corresponding commit, too). thanks, Takashi