Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp322483rdh; Wed, 7 Feb 2024 06:01:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHObgUH01Qq5cqjsoSAtjGyFW4gsK1cv1/87TdaqfXdJQ9jdORXsJbeXpQXSsB2YStQz4d+ X-Received: by 2002:a05:6122:4f04:b0:4c0:2802:a1d8 with SMTP id gh4-20020a0561224f0400b004c02802a1d8mr2707915vkb.15.1707314479668; Wed, 07 Feb 2024 06:01:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707314479; cv=pass; d=google.com; s=arc-20160816; b=CoqBEoYy9eaKMxMK4cEpIRvMZ9SxrWeWFwPQy2OwmAV/SV8QG8slBjetwW6R2GTSw8 OW+iraJrSdOl5JTm05xgaapJlvYDGL6kIyyuGTKauH5lJ3pTT37YWSnQvkLxZ8rfPfGY 2XDwlsD+iTYvC4QZJcWL1Vo1ye6fc2Seo4NkTDtG/OVYwdOGvJILkO+lKrOASGPVrCmw LLWPV2aI3l3z7WXNY6i+KWgpvrTI5AloUf/C9+w9XjE08j+iN4oatYFI1mTufVur6vOu AGRQ8f15cCJIwpoyGa+JCAmJCR7SlL89fOAwdXHybI3zUbp66bRjp1bXeedJrSUrrM+9 Dxzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=N6Gx8S6MRDtI2A9oUgOyFRMBblRIObpqj/BNWnjeZGE=; fh=KxVFRxNQovHu+9HvjLBt0VElHqkHnodNJBna0xhaSH8=; b=lg4jLWa7M/b6zNyCB7EFjxB+4b1Y0+fBTVxIpKhSbdSTgDGHZQCtRoU339UbvGYnfA 9UDcUEN1TE9x03GL0EscGLYBbn5nftnIGcSD6EgDE+K93joRHJnuLA7voXtWWnayHKWK UlWvAsoE5qqS8G4kp5vICKBz7LOKvbIMtkpEjchNGJ7KHLJtck8mYsejaFWqMC1IXZBP Ht1K3mvhpWq0PnsrsDK4ljq5b+LYbASCYdzKzMm6lsIiN1C3uQc0n+NmeeG/iJ8/fHqr 1fWRhASksuzg1SY+VX3W8hd3VAaWrRPo0RJu4N1awt9oDcckl3shGKR993BIqr968sX3 62vg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=upz6wTkP; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXOw+GdfeIgz7LfNkL2VLVh1uhwD4tH77Iyj8nzowYsy2wRtkVLE4rgfpRRMCcRck5b+hyp5Kl2U3bo0vRINeyGUdaVS0vdIJYyBNNC6A== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ch15-20020a056122318f00b004c02be0949csi161879vkb.322.2024.02.07.06.01.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 06:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=upz6wTkP; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 62FB91C2245C for ; Wed, 7 Feb 2024 14:01:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D648A7A723; Wed, 7 Feb 2024 14:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="upz6wTkP" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0532D23775; Wed, 7 Feb 2024 14:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707314472; cv=none; b=fESvB0HRvszTY8L1Mjc7uuZ6yvmipXoWs74SnbsnCPP+p7YDrNQfPt+yOFo73hr13R1TeJJ+lQkNptDgbRUW8HospahbGwCpNhyHyOqFiqTVi7ZxCINgwlBxQ/9kVqbk1BmHwgBC/+sBD5+OT7AIt99ZOZmXaRbVUUM6jXUreMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707314472; c=relaxed/simple; bh=QU4zHZ5yZeKhRA/NcZb3RGYc2aTKm/UNV58L0yHSg4g=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=I2ARtmwxlYYbIe4LqGPG95WNa4gIBEKI6mpfuDj5KXxd4u9NUCkl7CrnZi4XqNxxUqTbpDUmWOTevo5brVur56AilbRUXM28T99ot5PQ0DIhk8GfFYXuiwSlmrMMr7TDO8hFDKEV3hvgHyYyAyvNgssDRIhu2DrJhDoWW8vDUvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=upz6wTkP; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EC6FC43399; Wed, 7 Feb 2024 14:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707314471; bh=QU4zHZ5yZeKhRA/NcZb3RGYc2aTKm/UNV58L0yHSg4g=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=upz6wTkPOaXK7fDrCqAlhpvRtNW41LZp7hzefKj8TaSbqSsvri+h2NWWSK4EUpacc T7pofSj3QSVXF+ZeC8ARmOm4Xh5U7Gl2Q47BH7IATHvJVdxy5vYOMpveckm5zUluLZ ZX+RWMRDK7Cv/eEgONhjudY+dsF72jjGA9aoroNQZh+dUW2YMtXvAdc2Fr0scDMGis qUi7OkZkDkTkf0A7+6KRh7C9DXehkazqmIKiKy3//RzZVGIXDKOw3YIeH8Q3e10LqM XES8QOsD1tqm+EyKNWW45QbDiZxpL4/ALosiPCtXb6VFz6n+P0GCJOyhXpu0E0yJhM AtPW7WSeAh/HA== From: Vinod Koul To: Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Abel Vesa Cc: Elliot Berman , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20240201-phy-qcom-eusb2-repeater-fixes-v4-1-cf18c8cef6d7@linaro.org> References: <20240201-phy-qcom-eusb2-repeater-fixes-v4-1-cf18c8cef6d7@linaro.org> Subject: Re: [PATCH v4] phy: qualcomm: eusb2-repeater: Rework init to drop redundant zero-out loop Message-Id: <170731446925.147017.11723042709584104683.b4-ty@kernel.org> Date: Wed, 07 Feb 2024 15:01:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 On Thu, 01 Feb 2024 10:39:33 +0200, Abel Vesa wrote: > Instead of incrementing the base of the global reg fields, which renders > the second instance of the repeater broken due to wrong offsets, use > regmap with base and offset. As for zeroing out the rest of the tuning > regs, avoid looping though the table and just use the table as is, > as it is already zero initialized. > > > [...] Applied, thanks! [1/1] phy: qualcomm: eusb2-repeater: Rework init to drop redundant zero-out loop commit: 734550d60cdf634299f0eac7f7fe15763ed990bb Best regards, -- ~Vinod