Received-SPF: pass (google.com: domain of linux-kernel+bounces-56641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 7 Feb 2024 06:44:25 -0800
In-Reply-To: <6fdbeed0-980e-4371-a448-0c215c4bc48e@redhat.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240202231831.354848-1-seanjc@google.com> <170724566758.385340.17150738546447592707.b4-ty@google.com>
 <6fdbeed0-980e-4371-a448-0c215c4bc48e@redhat.com>
Message-ID: <ZcOXSZ2OPL5WCcRM@google.com>
Subject: Re: [PATCH] KVM: selftests: Fix a semaphore imbalance in the dirty
 ring logging test
From: Sean Christopherson <seanjc@google.com>
To: Eric Auger <eauger@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Shaoqin Huang <shahuang@redhat.com>
Content-Type: text/plain; charset="us-ascii"

On Wed, Feb 07, 2024, Eric Auger wrote:
> Hi Sean,
> 
> On 2/6/24 22:36, Sean Christopherson wrote:
> > On Fri, 02 Feb 2024 15:18:31 -0800, Sean Christopherson wrote:
> >> When finishing the final iteration of dirty_log_test testcase, set
> >> host_quit _before_ the final "continue" so that the vCPU worker doesn't
> >> run an extra iteration, and delete the hack-a-fix of an extra "continue"
> >> from the dirty ring testcase.  This fixes a bug where the extra post to
> >> sem_vcpu_cont may not be consumed, which results in failures in subsequent
> >> runs of the testcases.  The bug likely was missed during development as
> >> x86 supports only a single "guest mode", i.e. there aren't any subsequent
> >> testcases after the dirty ring test, because for_each_guest_mode() only
> >> runs a single iteration.
> >>
> >> [...]
> > 
> > Applied to kvm-x86 selftests, thanks!
> Do you plan to send this branch to Paolo for v6.8?

That wasn't my initial plan, but looking at what's in there, the only thing that
isn't a fix is Andrew's series to remove redundant newlines.  So yeah, I'll send
this along for 6.8.