Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754761AbXLUC3o (ORCPT ); Thu, 20 Dec 2007 21:29:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754130AbXLUC3f (ORCPT ); Thu, 20 Dec 2007 21:29:35 -0500 Received: from gate.crashing.org ([63.228.1.57]:57293 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbXLUC3c (ORCPT ); Thu, 20 Dec 2007 21:29:32 -0500 Subject: Re: PCI resource problems caused by improper address rounding From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Linus Torvalds Cc: Richard Henderson , Chuck Ebbert , linux-kernel , Ivan Kokshaysky , Daniel Ritz , Greg KH , Keith Packard , Bjorn Helgaas In-Reply-To: References: <47671377.6000405@redhat.com> <47680489.6040809@redhat.com> <20071218202234.GA24525@twiddle.net> <20071218215143.GA24769@twiddle.net> <20071220215204.GA5636@twiddle.net> Content-Type: text/plain Date: Fri, 21 Dec 2007 13:28:26 +1100 Message-Id: <1198204106.6779.40.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 26 > So in your case, it should *result* in the exact same situation that your > patch did, but at the same time, when dealing with the (more common) case > of smaller allocations, we still continue to try to avoid being too close > to the top-of-memory. > > So it's not perfect, but perhaps it is a good compromise between being > careful and having to make room? > > Does this work for your case? I'm not totally happy with changing the generic code like that, to possibly not enforce "min" anymore. Other archs may have very good reasons to provide a min value here... Though at the same time, at least on powerpc, the parent resource of the host bridge will be the real limit, so that may not be a big issue. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/