Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764284AbXLUCdQ (ORCPT ); Thu, 20 Dec 2007 21:33:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753734AbXLUCc7 (ORCPT ); Thu, 20 Dec 2007 21:32:59 -0500 Received: from mx1.redhat.com ([66.187.233.31]:60933 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbXLUCc6 (ORCPT ); Thu, 20 Dec 2007 21:32:58 -0500 Date: Thu, 20 Dec 2007 21:30:31 -0500 From: Dave Jones To: "Eric W. Biederman" Cc: Andrew Morton , Jan Beulich , linux-kernel@vger.kernel.org Subject: Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c Message-ID: <20071221023031.GA23320@redhat.com> Mail-Followup-To: Dave Jones , "Eric W. Biederman" , Andrew Morton , Jan Beulich , linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 25 On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote: > Remains the question whether it is intended that many, perhaps even > large, tables are compiled in without ever having a chance to get used, > i.e. whether there shouldn't #ifdef CONFIG_xxx get added. > -static struct trans_ctl_table trans_net_ax25_param_table[] = { > +static const struct trans_ctl_table trans_net_ax25_table[] = { we lost the _param, which will cause a duplicate definition with .. > -static struct trans_ctl_table trans_net_ax25_table[] = { > +static const struct trans_ctl_table trans_net_ax25_table[] = { cut-n-paste thinko ? Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/