Received-SPF: pass (google.com: domain of linux-kernel+bounces-56725-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <82889f67-adf3-4643-902e-2c8f581eb05a@oracle.com>
Date: Wed, 7 Feb 2024 09:37:02 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: core: really include kunit tests with
 SCSI_LIB_KUNIT_TEST
Content-Language: en-US
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>, Christoph Hellwig <hch@lst.de>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        linux-scsi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240207145603.15680-1-lukas.bulwahn@gmail.com>
From: michael.christie@oracle.com
In-Reply-To: <20240207145603.15680-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bFprOWhtQ2lmREs4ZnZGMmtGd0VBRWtFc3d3QU11a3FHKzdkSVdpcDFWVzda?=
 =?utf-8?B?eGVqcVQ0Wm9TY0owQk9QdzhONXp3Ymp3VE1xbzdJOVdOSHBYdGx4d25UellT?=
 =?utf-8?B?cXNtQXk1Q2lwQ2JLTHFLUkNsYjhVZHN0SVlIZ1p0MVBzd29OZE5pem5GNHZU?=
 =?utf-8?B?eTI2cytheU5ndTlaRVloOUlvTmMyaXJuQmo3YXhHZHcxeVZlaTRHN1g2LzhW?=
 =?utf-8?B?WUpleXo5WXA5UFFWS2RVZTNzdzlPcDRFWkdBOElmdU5hVWttb0RrUGtvMjJq?=
 =?utf-8?B?TjZVSGtiN3ZNK25HVWtyMmU0T0pqb1RrbnZhSGRXT2VzQzdsMlNWazNZWTlk?=
 =?utf-8?B?ZUhiQ0syS2ZhZHd6czBVRElKTDJmbVR4UjNpRUVTRXEwSWNUYndLcHNzYUJE?=
 =?utf-8?B?VVJSU0FGR3dpZEJkNXBaTzVlL0YxRkdSd2wvV3JrQ2RBU2x3QW91QnZGUy9H?=
 =?utf-8?B?S1RIdVJ0THVXWEVWb0Q3b29BM2wrOGRxbVdKTW1vK3hURkNlTlJnRVN0MmZa?=
 =?utf-8?B?N3RKOGROZkNITlUwc0FqTVowMnJqRy95cUQyMHZQQ1FSczIrRjdmaTNPMUZq?=
 =?utf-8?B?NXJwRzVGaGtwdjdwdytndENpdG1FaHYycUpwOWlidDVnQzJrcFJXK0JCTDAz?=
 =?utf-8?B?RFlnTmNPQ1pqTjFPRy8xbFc2TmVpcFlYRkhEYzhrR1lSeU9hMElOTDJqWFdF?=
 =?utf-8?B?TzhMek43K1VKNFFaN2FlR3N2a2R2TXIva2d6NlhGRW5IMnlMN2E4NUE0TDY5?=
 =?utf-8?B?Y3pTaytsWmlQK3VJcjJoYUJ0NTZCOTZYb1hmUXlJc2xTeVZ3UFNla3pES0Zq?=
 =?utf-8?B?eHhXVjJaSDhpcksrcVlpTjdsZTQzMVhneW9qWG12RUt6Ung2aFd4a3lya0th?=
 =?utf-8?B?b2JOUFQ3NWZXN0xXQXp1a2ErMU52cFlqM09QdTg0NWtCRlgrWE5QTEhyeDlT?=
 =?utf-8?B?bWJYbTNWeGR6QXFhSnZnRGhBN0FHRmx2RVR4eWNDRTBzVkYxUmxkMDhXU2pp?=
 =?utf-8?B?T25UYnFRZmpVcm96UjNqeG03cTlTNzhjK3FSVzVRMkdUT2EzTUc0eTBodzlt?=
 =?utf-8?B?U01mdUxLWXpNNG0vL1dQaVFQL2JCQS9DMlBibzNZN0x6c1Z3RzdHUUtTeDhx?=
 =?utf-8?B?NGFmWkt3ejJOMjQ3ek5ReXRkRXZHYzl4cWQzTkpVVFBLYkFyQjg3WEVNUXdL?=
 =?utf-8?B?WlkxcDl6MFROQjQyOTAzSjlHNEtjVEZlcVhFUTZQWTl0eDlnNDFLZmhNMXYz?=
 =?utf-8?B?eENkU0dib0hDY3Y1S0dYems2ZkRiTCs1c1VLQTZhR0VMUklNekNMU01JLzZr?=
 =?utf-8?B?TFFQUVJOTk9KRGY3NkFscXlwZSt1L3FCdEJPcHlRZ2ZZaElTRGJwb1UvUGdp?=
 =?utf-8?B?YnNxcTNsZkRJeXRieXZuZWhIdCsxQW55bXVaYVpsb3FHRnpzbE1reE1GNTE3?=
 =?utf-8?B?dER5ZUhiU3FaWGN0NTllS0w4akhZUUxkMlZoYy80enJJVDZrZlo1NTJhVmM0?=
 =?utf-8?B?NjJUWFI1TklHUFBSVmVZclBVUExWakVuQkhFSkU3QzBiYVhWS3VVbm9GMjJQ?=
 =?utf-8?B?bENxSXN5MzhTVUozL0hSbG41emg1aFBNdjlJYWRBZjI0dGkxU3dDckgvUGJq?=
 =?utf-8?B?a01VcU5JM0o3Q2dybUNkK3N1LzM4Y3BKT3RacTBmb3I3dzR5VUZWTWtGNTds?=
 =?utf-8?B?ZzJtcjg0OGR1bWRpeUxoQVNwV0FNMmZjZTdzdmJVMVBZWVRFeHU2RWpjYVQ2?=
 =?utf-8?B?dHBETll4a3RWUGM0RGV3RHBPaG9xcTFmUzFXdS9LSFlHbURLKzRuZko4ZG5z?=
 =?utf-8?B?MmpkVitqa1BmaG9LemR5bDVhc3Q4K1pHSG00dmJCR3puR0FaVHZuUjdhMDZj?=
 =?utf-8?B?RWF3dGJ2OUs4ZWs1cUhWQjFaam1lYXBXWEhOWmR1U0FGL2F6aE5sYVh4ZmlJ?=
 =?utf-8?B?RXF1eTc5NkpaWGk4RlVGaS9GbmZLemFkOGJsckI5d2E5SFFxQVZha0Q0UWpE?=
 =?utf-8?B?VUpuZkZ1bkdKK3I0UzZ0VjBPVkQwc1F6KzJTWlhITFBQNDEyWmdydUpxNzQz?=
 =?utf-8?B?SWZ4QWhFL2dSRTh0THhDeS93T2JMMGgwZ0pEd3l0N3F0QVR4SHU1dmc2TzNu?=
 =?utf-8?B?ck52WXNkSEM4WnVKZWdqa3B2VEdXOXJRaGkrSjV2S2ZramFxd216UkEweHRm?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	oj5NUtAgAZbps1yyAd0+KJooDjZSkndPoIgAlA9eDV+AFHqWdejpSKRc8Wi+InF4MTEJnAcoa/eTg7CJyKomti68wOiw3GgwmijyWQoNAAFb/E07LNUQiXZ+4cNdmasB5H9RoWUg0OMW23xkWYyiESvV/c/iReYOkfpG2/BQNp0zGDB3bDyoTOatRoE87xe46BxBXrcgTAcGYs3OhoI1ZFoqnqllkF9waMohhi1d+yJy8UsbWMZ7qSI+q/k9OJcxVQnkmn2WyYhinZeVYXgg0OlqjavbwyXPhpPfQzUUgi5IcGftk5r1fxFKwoyPJ81hkE+mg+/X8ASPUGWIfNonkmJa0KRxo0UfNcdPYFNMioHm18303QBJy9iUpD353gEG2fEur70Yp9jyaEWTMkaUmzymEYF9xA4+5N80vVerKqEdlZbunMY3boxHK0cLAEGK0kGLIXuiwzJJsc7yV7rzkXBYd7qwJAqFKC1Ooo9FKD1jWlANaLUqyO2r/GxviqMGTK7iYiISCN7M/iGoAHJmUgdgRytl5Te7ZTn/NEb7+11p2EYucWik9T6eE5Y+Kb1nsE4LgdLOYlE34pgr5NGNOiogzkI5LB4PQ8XVTG2CkJA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adcf56e3-23e1-462a-f455-08dc27f2a261
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 15:37:04.0552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dW5fift0K7S0zSiTV6Lr7XZ6PHhLCwuKpAzt7URnp3xeVo/y4NPG15nyuR8qs02+SSYmcyfCWob70UdQnLQnNqsp+TQ5+LDeTuUaq9bdtfw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6641
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-07_06,2024-02-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0
 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402070115
X-Proofpoint-GUID: 6sPQMxUNN9C8NfQvScVwn7rH7gA56UWa
X-Proofpoint-ORIG-GUID: 6sPQMxUNN9C8NfQvScVwn7rH7gA56UWa

On 2/7/24 8:56 AM, Lukas Bulwahn wrote:
> Commit 25a1f7a0a1fe ("scsi: core: Add kunit tests for
> scsi_check_passthrough()") adds the config SCSI_LIB_KUNIT_TEST and
> corresponding tests. Due to naming confusion, the actual tests would only
> be included when the non-existing config SCSI_KUNIT_TEST is enabled (note
> this missing 'LIB' in the config name). So, they are basically dead right
> now.
> 
> Adjust the name to actual existing config.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  drivers/scsi/scsi_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 23719b903259..0315a0dc3406 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -3428,6 +3428,6 @@ void scsi_build_sense(struct scsi_cmnd *scmd, int desc, u8 key, u8 asc, u8 ascq)
>  }
>  EXPORT_SYMBOL_GPL(scsi_build_sense);
>  
> -#ifdef CONFIG_SCSI_KUNIT_TEST
> +#ifdef CONFIG_SCSI_LIB_KUNIT_TEST
>  #include "scsi_lib_test.c"
>  #endif

I tried to sneak a rename in last minute and messed that up. Thanks.

Reviewed-by: Mike Christie <michael.christie@oracle.com>